Develop to main #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejhh
pushed a commit
that referenced
this pull request
Aug 15, 2025
…listdir; add failing test then implement per DoD
Unifies tool error contract to emit single-line {\"error\":\"...\"} on stderr with non-zero exit. Adds a test to enforce contract for missing path and updates fs_listdir to use writeStdErrJSON, aligning with FEATURE_CHECKLIST.md L91 and enabling deterministic runner mapping.
Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 15, 2025
…tract for fs_read_lines
Adopt uniform {\"error\":\"...\"} on stderr for fs_read_lines and add a focused test to verify contract. Keeps NOT_FOUND marker for deterministic checks; all tests green.
Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 15, 2025
… build and pass Restore missing tool program sources under tools/* expected by existing tests to unblock the path migration work (S54). - Add minimal, standards-compliant implementations for exec and fs_* tools with JSON I/O and error contracts. - Fix fs_write_file parent handling; implement fs_search glob/regex; add fs_apply_patch new-file clean apply with idempotence/conflict/CRLF handling. - Remove stray untracked test dir tools/no_such_parent_dir to stabilize FsWrite test. All tool tests and full suite are green locally: go test ./... passes. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 15, 2025
go test ./... passes after restoring legacy tool source dirs so builds/tests remain green during migration. This closes the S54a unblock slice and preserves deterministic local CI. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 15, 2025
…ix tests Introduce `tools/testutil/BuildTool` and unit tests asserting Windows `.exe` suffix vs non-Windows no-suffix, plus a representative assertion in `tools/fs_listdir_suffix_test.go`. This establishes cross-platform bin path expectations for upcoming tools/bin migration. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 15, 2025
Added `tools/testutil/BuildTool` with Windows suffix behavior and tests, plus a representative assertion in tools tests. Full suite remains green. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 15, 2025
…alidator, tests, and docs Enforces a canonical `./tools/bin/` prefix for any relative `command[0]` in the tools manifest and prevents path escapes after normalization. Updates unit tests to reflect the new rule and clarifies the reference docs’ error messages. All tests are green. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 16, 2025
… Makefile and tests Moves fs_move source to tools/cmd/fs_move, updates Makefile to build from the new path, refactors tests to use shared BuildTool helper, and removes legacy source. All tool builds and test suites are green. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 16, 2025
…ch tests to BuildTool, and update Makefile to build from new path; suite remains green. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 16, 2025
…tests Migrates fs_stat to canonical layout (sources under tools/cmd/fs_stat, binary at tools/bin/fs_stat), updates Makefile, and refactors tests to use testutil.BuildTool. All tests green. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 16, 2025
…e path tests - Normalize backslashes and clean with path.Clean to validate relative command[0] consistently across OSes - Accept .\\tools\\bin\\NAME, reject escapes like .\\tools\\bin\\..\\hack - Extend tests to cover Windows-style backslash cases; full suite remains green - Check off [S32:l90-manifest-crossplat-bin-prefix] in FEATURE_CHECKLIST.md for traceability Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 16, 2025
- Address errcheck in fs_search (check WalkDir error) - Remove unused helper in fs_apply_patch tests - Apply gosimple suggestion in fs_apply_patch (TrimPrefix) - Clear ineffassign and tighten types in fs_listdir - Run gofmt -s across repo to satisfy fmtcheck Why: Unblock S22a final-sweep-lint so `make lint` + path checks can pass with tools installed; full test suite remains green locally. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 16, 2025
…rect ./tools/<name> - Use PCRE2 negative lookahead to ignore allowed ./tools/cmd/* and ./tools/bin/* - Keep legacy ./tools/<name>.go and direct build/run checks strict Why: Make lint path guard precise so S22a can pass with docs examples that build from ./tools/cmd. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 16, 2025
…s green - `make check-tools-paths` passes with rg available - `make lint` passes with golangci-lint v1.62.2 and fmt/vet - Full `go test ./...` already green This finalizes the S22 lint/paths sweep. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 16, 2025
Migrates `tools/fs_move_test.go` to `tools/cmd/fs_move/fs_move_test.go` using BuildTool-based pattern; adds local `makeRepoRelTempDir` helper. Tests: targeted fs_move and full suite green. Updates `FEATURE_CHECKLIST.md` [S39] to checked. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 16, 2025
…elper; check off checklist item. Deduplicates repo-relative temp dir helper by switching tools/cmd/fs_move/fs_move_test.go to use tools/testutil.MakeRepoRelTempDir for consistency and maintainability. All tests are green. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 16, 2025
…eRepoRelTempDir; green tests; check off checklist L200. Links: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 16, 2025
… MakeRepoRelTempDir helper; keep tests DRY and deterministic. Links: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 16, 2025
…tory and document - Validate relative command[0] as before, then rewrite to an absolute path anchored to the manifest's folder to decouple from process CWD - Add unit test covering nested manifest resolution - Update manifest reference to state resolution rule Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 16, 2025
Mark the checklist item as complete in FEATURE_CHECKLIST.md to preserve traceability with the manifest loader change and tests. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 16, 2025
Tighten tests to skip stdout decode on non-zero exit for tools’ standardized error JSON path; apply gofmt -s. All tools/* ErrorJSON tests now pass and full suite is green locally. Completes L225 S02 under the lint cleanup umbrella while preserving gates. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 17, 2025
…README already green Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 17, 2025
…hecklist - Guard encoder to nil out temperature when SupportsTemperature==false - Add unit tests for omission/presence at both type-marshal and HTTP layers - gofmt fixups and gocyclo suppression on CLI loop (no behavior change) - Check off FEATURE line 253 (payload encoder omission/inclusion) Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 17, 2025
…e retry Implements a targeted recovery in `CreateChatCompletion`: when the API returns 400 indicating an unsupported/invalid `temperature`, drop the field and retry once without consuming the normal retry budget. Adds focused integration test to prove behavior and checks off the checklist item. Keeps all tests green. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 17, 2025
Introduce `clampTemperature`, `EffectiveTemperatureForModel`, and `NudgedTemperature` in `internal/oai`: - Clamp within [0.1, 1.0] - No-op/omit for unsupported models via `SupportsTemperature` Includes focused unit tests covering bounds, guard behavior, and nudge semantics. All tests green locally. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 18, 2025
…indows backslash paths; tests now pass on cross-platform. Aligns with checklist Windows suffix + path normalization item. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 18, 2025
…w normalizes with ToSlash; Windows examples/tests already present; full test suite green across packages. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 18, 2025
…klist item complete. Adds EnvPassthrough to ToolSpec with strict normalization/validation and tests; updates reference docs to describe allowlist and execution model; checks off the FEATURE_CHECKLIST item per Definition of Done. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 18, 2025
Implements passing PATH, HOME, and allowlisted env vars from tools.json to child processes in internal/tools/runner.go. Adds envKeys field to tool audit lines (names only, never values). Adds unit test verifying child sees only allowlisted vars and audit redacts values. Updates tools-manifest reference to document envKeys behavior. Checks off checklist item for env passthrough. Refs: #1
thejhh
pushed a commit
that referenced
this pull request
Aug 18, 2025
…file warning; add unit test; update README capabilities note. Refs: #1
added 27 commits
August 19, 2025 16:35
…s (develop-only admin update)
…status files only on develop
Update FEATURE_CHECKLIST.md with PR #45 link and set logs/CURRENT_TASK.md to reflect active monitoring of the integration tests PR. No code changes on develop.
…klist and changelog (develop-only)
Maintains develop untouched except task files.
Adds the OPEN link for pr/diagrams to avoid duplicate work.
…lean workspace at ./work/main (develop-only)
- Recorded maintenance pass confirming existing PRs - Verified clean ./work/main reset to origin/main for next slices - Kept develop limited to tracking docs only Refs: #6
…s (develop-only admin update)
…(develop-only admin) - Verified existing PRs with gh; ensured ./work/main matches origin/main - Updated FEATURE_CHECKLIST.md and CURRENT_TASK.md only on develop Refs: FEATURE_CHECKLIST.md top maintenance lines
…n (develop-only admin) - Verified all OPEN PRs target base main; no duplicates - Reset ./work/main to origin/main for pristine base for feature slicing - Updated FEATURE_CHECKLIST.md and CHANGELOG.md to record this pass Refs: https://github.com/hyperifyio/goagent/pulls
Updates FEATURE_CHECKLIST.md with a maintenance entry and notes that ./work/main was reset to origin/main. Logs current idle status awaiting PR reviews in logs/CURRENT_TASK.md.
heusalagroupbot
pushed a commit
that referenced
this pull request
Aug 21, 2025
… idempotency key format, and retryable error detection; fix timeout string handling Ensures deterministic coverage of small helpers in internal/oai and broadens timeout detection to include 'timed out' phrasing used by stdlib/proxies. Refs: https://github.com/hyperifyio/goagent/issues/216, #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.