[Suspense] Add Batched Mode variant to fuzz tester (facebook#15734)

hyyqcweb · May 28, 2019 · d915a4c · d915a4c
1 parent 7c5645d
commit d915a4c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 13 deletions.
diff --git a/packages/react-noop-renderer/src/createReactNoop.js b/packages/react-noop-renderer/src/createReactNoop.js
@@ -969,10 +969,10 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
           NoopRenderer.updateContainer(children, fiberRoot, null, null);
         },
         getChildren() {
-          return getChildren(fiberRoot);
+          return getChildren(container);
         },
         getChildrenAsJSX() {
-          return getChildrenAsJSX(fiberRoot);
+          return getChildrenAsJSX(container);
         },
       };
     },

diff --git a/packages/react-reconciler/src/__tests__/ReactSuspenseFuzz-test.internal.js b/packages/react-reconciler/src/__tests__/ReactSuspenseFuzz-test.internal.js
@@ -160,16 +160,14 @@ describe('ReactSuspenseFuzz', () => {
       );
 
       resetCache();
-      ReactNoop.renderToRootWithID(
+      const expectedRoot = ReactNoop.createRoot();
+      expectedRoot.render(
         <ShouldSuspendContext.Provider value={false}>
           {children}
         </ShouldSuspendContext.Provider>,
-        'expected',
       );
       resolveAllTasks();
-      const expectedOutput = ReactNoop.getChildrenAsJSX('expected');
-      ReactNoop.renderToRootWithID(null, 'expected');
-      Scheduler.unstable_flushWithoutYielding();
+      const expectedOutput = expectedRoot.getChildrenAsJSX();
 
       resetCache();
       ReactNoop.renderLegacySyncRoot(children);
@@ -179,13 +177,18 @@ describe('ReactSuspenseFuzz', () => {
       ReactNoop.renderLegacySyncRoot(null);
 
       resetCache();
-      ReactNoop.renderToRootWithID(children, 'concurrent');
-      Scheduler.unstable_flushWithoutYielding();
+      const batchedSyncRoot = ReactNoop.createSyncRoot();
+      batchedSyncRoot.render(children);
+      resolveAllTasks();
+      const batchedSyncOutput = batchedSyncRoot.getChildrenAsJSX();
+      expect(batchedSyncOutput).toEqual(expectedOutput);
+
+      resetCache();
+      const concurrentRoot = ReactNoop.createRoot();
+      concurrentRoot.render(children);
       resolveAllTasks();
-      const concurrentOutput = ReactNoop.getChildrenAsJSX('concurrent');
+      const concurrentOutput = concurrentRoot.getChildrenAsJSX();
       expect(concurrentOutput).toEqual(expectedOutput);
-      ReactNoop.renderToRootWithID(null, 'concurrent');
-      Scheduler.unstable_flushWithoutYielding();
     }
 
     function pickRandomWeighted(rand, options) {
@@ -321,7 +324,7 @@ describe('ReactSuspenseFuzz', () => {
     );
   });
 
-  it('generative tests', () => {
+  it(`generative tests (random seed: ${SEED})`, () => {
     const {generateTestCase, testResolvedOutput} = createFuzzer();
 
     const rand = Random.create(SEED);