feat: Allow Edit -> Jump to to jump to little and big endian addresses

Closes WerWolv#1324
hzqst · Sep 26, 2023 · b3ef615 · b3ef615
1 parent 25ddaa0
commit b3ef615
Showing 1 changed file with 20 additions and 5 deletions.
diff --git a/plugins/builtin/source/content/views/view_hex_editor.cpp b/plugins/builtin/source/content/views/view_hex_editor.cpp
@@ -1249,16 +1249,31 @@ namespace hex::plugin::builtin {
                                                 [] { return ImHexApi::HexEditor::isSelectionValid() && ImHexApi::Provider::isValid() && ImHexApi::Provider::get()->isWritable(); });
 
         /* Jump to */
-        ContentRegistry::Interface::addMenuItem({ "hex.builtin.menu.edit", "hex.builtin.view.hex_editor.menu.edit.jump_to" }, 1850, Shortcut::None,
+        ContentRegistry::Interface::addMenuItemSubMenu({ "hex.builtin.menu.edit", "hex.builtin.view.hex_editor.menu.edit.jump_to" }, 1850,
                                                 [] {
-                                                    auto provider = ImHexApi::Provider::get();
-                                                    auto selection      = ImHexApi::HexEditor::getSelection();
+                                                    auto provider   = ImHexApi::Provider::get();
+                                                    auto selection  = ImHexApi::HexEditor::getSelection();
 
                                                     u64 value = 0;
                                                     provider->read(selection->getStartAddress(), &value, selection->getSize());
 
-                                                    if (value < provider->getBaseAddress() + provider->getActualSize()) {
-                                                        ImHexApi::HexEditor::setSelection(value, 1);
+                                                    auto littleEndianValue = hex::changeEndianess(value, selection->size, std::endian::little);
+                                                    auto bigEndianValue    = hex::changeEndianess(value, selection->size,  std::endian::big);
+
+                                                    auto canJumpTo = [provider](u64 value) {
+                                                        return (value >= provider->getBaseAddress()) && (value < (provider->getBaseAddress() + provider->getActualSize()));
+                                                    };
+
+                                                    if (ImGui::MenuItem(hex::format("0x{:08X}", littleEndianValue).c_str(), "hex.builtin.common.little_endian"_lang, false, canJumpTo(littleEndianValue))) {
+                                                        if (value < provider->getBaseAddress() + provider->getActualSize()) {
+                                                            ImHexApi::HexEditor::setSelection(littleEndianValue, 1);
+                                                        }
+                                                    }
+
+                                                    if (ImGui::MenuItem(hex::format("0x{:08X}", bigEndianValue).c_str(), "hex.builtin.common.big_endian"_lang, false, canJumpTo(bigEndianValue))) {
+                                                        if (value < provider->getBaseAddress() + provider->getActualSize()) {
+                                                            ImHexApi::HexEditor::setSelection(bigEndianValue, 1);
+                                                        }
                                                     }
                                                 },
                                                 [] { return ImHexApi::Provider::isValid() && ImHexApi::HexEditor::isSelectionValid() && ImHexApi::HexEditor::getSelection()->getSize() <= sizeof(u64); });