fix(xgplayer): Let destroy api's behavior tend to be synchronized(Res…

…olves bytedance#689, resolves bytedance#466)
iHaust · Jul 22, 2022 · d96becf · d96becf
1 parent b21e409
commit d96becf
Show file tree

Hide file tree

Showing 2 changed files with 9,647 additions and 6 deletions.
diff --git a/packages/xgplayer/src/player.js b/packages/xgplayer/src/player.js
@@ -330,12 +330,12 @@ class Player extends Proxy {
       allOff(this)
     }
 
-    if (!this.paused) {
-      this.pause()
-      this.once('pause', destroyFunc)
-    } else {
-      destroyFunc.call(this)
-    }
+    // destroy immediately
+    // Don't use the paused property detection, it doesn't use MediaElement.paused, 
+    // so it's not accurate enough. Destroy after waiting for pause event, this 
+    // changes the synchronous behavior of destroy api
+    destroyFunc.call(this)
+
     super.destroy()
   }