Enable useDefineForClassFields TS flag
#7563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GytisCepk
requested review from
aruniverse,
calebmshafer,
wgoehrig,
a team,
ColinKerr,
christophermlawson and
StefanApfel-Bentley
as code owners
|
@wgoehrig when you get a chance, can you review this PR? |
|
This pull request is now in conflicts. Could you fix it @GytisCepk? 🙏 |
wgoehrig
reviewed
Jan 22, 2025
wgoehrig
approved these changes
Feb 4, 2025
aruniverse
approved these changes
Feb 4, 2025
christophermlawson
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript recommends setting
useDefineForClassFieldstotrue(default value starting ES2022). However, enabling this flag caused several issues. More info: #7474Additionally, noticed that some TypeScript types are incorrectly defined (e.g.
AuxCoordSystem2d.angleis defined asnumber, but in reality it can be anumber,objectorundefined). This PR fixes some of these.