Add yAxisUp to ReadGltfGraphicsArgs #7653
Open
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andremig-bentley
requested review from
bbastings,
aruniverse,
ben-polinsky and
a team
as code owners
|
/azp run iTwin.js |
|
/azp run iTwin.js Docs - YAML |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run iTwin.js Integration - GitHub |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
pmconne
requested changes
Feb 4, 2025
| @@ -2178,7 +2180,8 @@ export async function readGltfGraphics(args: ReadGltfGraphicsArgs): Promise<Rend | |||
| */ | |||
| export async function readGltfTemplate(args: ReadGltfGraphicsArgs): Promise<GltfTemplate | undefined> { | |||
| const baseUrl = typeof args.baseUrl === "string" ? new URL(args.baseUrl) : args.baseUrl; | |||
| const props = GltfReaderProps.create(args.gltf, true, baseUrl); // glTF supports exactly one coordinate system with y axis up. | |||
| const yAxisUp = args.yAxisUp ?? true; // default to true | |||
| const props = GltfReaderProps.create(args.gltf, yAxisUp, baseUrl); // glTF supports exactly one coordinate system with y axis up. | |||
There was a problem hiding this comment.
// glTF supports exactly one coordinate system with y axis up.
Per the comment, y is always up in glTF. Presumably the problem is in our attempt to align it to our z-up coordinate system. Caller should not have to fix that for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue: #7454
When calling
ReadGltf(),ReadGltfGraphics(), orReadGltfTemplate(), there is currently no option to specify theyAxisUpoption of theGltfGraphicsReaderwhen it is created as a part of these functions. Instead,yAxisUpis forced true. This leads to situations like the one outlined in the above issue, where a call toReadGltfTemplate()may create misplaced graphics due to axis orientation issues. To solve this, an optionalyAxisUpflag was added toReadGltfGraphicsArgs, and can now be passed in to any of the above function calls if desired. IfReadGltfGraphicsArgs.yAxisUpisundefined, the flag defaults to true.