Skip to content

Merge pull request #18 from iamyeka/fix/modify-baseRegistry-while-need #28

Merge pull request #18 from iamyeka/fix/modify-baseRegistry-while-need

Merge pull request #18 from iamyeka/fix/modify-baseRegistry-while-need #28

Triggered via push November 25, 2024 04:02
Status Failure
Total duration 56s
Artifacts

unit-test.yml

on: push
golangci-lint
45s
golangci-lint
Matrix: unit-test
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
golangci-lint: core/controller/cloudevent/controller_test.go#L283
cannot use clusterGitRepo (variable of type *mock_gitrepo.MockClusterGitRepo) as "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo value in assignment: *mock_gitrepo.MockClusterGitRepo does not implement "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo (missing method UpdateEnvValue) (typecheck)
golangci-lint: core/controller/cluster/controller_basic_v2_test.go#L64
cannot use mockClusterGitRepo (variable of type *"github.com/horizoncd/horizon/mock/pkg/cluster/gitrepo".MockClusterGitRepo) as "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo value in struct literal: *"github.com/horizoncd/horizon/mock/pkg/cluster/gitrepo".MockClusterGitRepo does not implement "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo (missing method UpdateEnvValue) (typecheck)
golangci-lint: core/controller/cluster/controller_test.go#L1414
cannot use clusterGitRepo (variable of type *"github.com/horizoncd/horizon/mock/pkg/cluster/gitrepo".MockClusterGitRepo) as "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo value in struct literal: *"github.com/horizoncd/horizon/mock/pkg/cluster/gitrepo".MockClusterGitRepo does not implement "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo (missing method UpdateEnvValue) (typecheck)
golangci-lint: core/controller/cluster/controller_test.go#L1639
cannot use clusterGitRepo (variable of type *"github.com/horizoncd/horizon/mock/pkg/cluster/gitrepo".MockClusterGitRepo) as "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo value in struct literal: *"github.com/horizoncd/horizon/mock/pkg/cluster/gitrepo".MockClusterGitRepo does not implement "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo (missing method UpdateEnvValue) (typecheck)
golangci-lint: core/controller/cluster/controller_test.go#L1761
cannot use clusterGitRepoMock (variable of type *"github.com/horizoncd/horizon/mock/pkg/cluster/gitrepo".MockClusterGitRepo) as "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo value in struct literal: *"github.com/horizoncd/horizon/mock/pkg/cluster/gitrepo".MockClusterGitRepo does not implement "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo (missing method UpdateEnvValue) (typecheck)
golangci-lint: core/controller/pipelinerun/controller_test.go#L101
cannot use mockClusterGitRepo (variable of type *mock_gitrepo.MockClusterGitRepo) as "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo value in struct literal: *mock_gitrepo.MockClusterGitRepo does not implement "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo (missing method UpdateEnvValue) (typecheck)
golangci-lint: core/controller/pipelinerun/controller_test.go#L180
cannot use mockClusterGitRepo (variable of type *mock_gitrepo.MockClusterGitRepo) as "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo value in struct literal: *mock_gitrepo.MockClusterGitRepo does not implement "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo (missing method UpdateEnvValue) (typecheck)
golangci-lint: core/controller/pipelinerun/controller_test.go#L434
cannot use mockClusterGitRepo (variable of type *mock_gitrepo.MockClusterGitRepo) as "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo value in argument to clusterservice.NewService: *mock_gitrepo.MockClusterGitRepo does not implement "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo (missing method UpdateEnvValue) (typecheck)
golangci-lint: core/controller/pipelinerun/controller_test.go#L445
cannot use mockClusterGitRepo (variable of type *mock_gitrepo.MockClusterGitRepo) as "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo value in struct literal: *mock_gitrepo.MockClusterGitRepo does not implement "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo (missing method UpdateEnvValue) (typecheck)
golangci-lint: core/controller/tag/controller_test.go#L115
cannot use clusterGitRepo (variable of type *mock_gitrepo.MockClusterGitRepo) as "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo value in struct literal: *mock_gitrepo.MockClusterGitRepo does not implement "github.com/horizoncd/horizon/pkg/cluster/gitrepo".ClusterGitRepo (missing method UpdateEnvValue) (typecheck)
golangci-lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3, golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/