Enable it build on Windows by unix → unix-compat transition
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I really don't want to drop |
develop7
force-pushed
the
fix-windows-drop-getpwuid
branch
from
deb41df to
ab36cdd
Compare
develop7
force-pushed
the
fix-windows-drop-getpwuid
branch
from
ab36cdd to
224e9a7
Compare
Done, check it out. A CI config for Windows is in order as well, let me know if that's a must. |
Extracts platform-dependent code to OpenTelemetry.Platform module
develop7
force-pushed
the
fix-windows-drop-getpwuid
branch
from
224e9a7 to
9b2cec0
Compare
|
@iand675 do you want me to introduce CI on Windows as well? |
|
It would be good to have some windows CI, but this seems like a definite improvement nonetheless. Could you add a note to the Changelog? Then I'll merge. |
|
@michaelpj done and done! |
|
Speaking of windows CI, I'm working on it at https://github.com/develop7/hs-opentelemetry/tree/ci-windows_builds |
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
unix-compatin place ofunix, enabling the project to build for Windows too.Unfortunately, had to leave
process.ownerfield empty because a non-POSIXgetEffectiveUserIDimplementation is absent inunix-compat(for reasons described in haskell-pkg-janitors/unix-compat#2 (comment)). Please let me know if the conditional compilation approach is welcome here, I'll update the code appropriately.A possible fix for #109.