Bug 1728357: Implement framesDropped. r=ng,webidl,smaug

Differential Revision: https://phabricator.services.mozilla.com/D168582
iaxat · Feb 3, 2023 · 00a342a · 00a342a
1 parent 70a42c8
commit 00a342a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/dom/media/webrtc/WebrtcGlobal.h b/dom/media/webrtc/WebrtcGlobal.h
@@ -299,6 +299,7 @@ struct ParamTraits<mozilla::dom::RTCInboundRtpStreamStats> {
     WriteParam(aWriter, aParam.mTrackIdentifier);
     WriteParam(aWriter, aParam.mRemoteId);
     WriteParam(aWriter, aParam.mFramesDecoded);
+    WriteParam(aWriter, aParam.mFramesDropped);
     WriteParam(aWriter, aParam.mFrameWidth);
     WriteParam(aWriter, aParam.mFrameHeight);
     WriteParam(aWriter, aParam.mFramesPerSecond);
@@ -336,6 +337,7 @@ struct ParamTraits<mozilla::dom::RTCInboundRtpStreamStats> {
     return ReadParam(aReader, &(aResult->mTrackIdentifier)) &&
            ReadParam(aReader, &(aResult->mRemoteId)) &&
            ReadParam(aReader, &(aResult->mFramesDecoded)) &&
+           ReadParam(aReader, &(aResult->mFramesDropped)) &&
            ReadParam(aReader, &(aResult->mFrameWidth)) &&
            ReadParam(aReader, &(aResult->mFrameHeight)) &&
            ReadParam(aReader, &(aResult->mFramesPerSecond)) &&

diff --git a/dom/media/webrtc/jsapi/RTCRtpReceiver.cpp b/dom/media/webrtc/jsapi/RTCRtpReceiver.cpp
@@ -482,13 +482,10 @@ nsTArray<RefPtr<RTCStatsPromise>> RTCRtpReceiver::GetStatsInternal(
                         webrtc::Timestamp::Millis(
                             *videoStats->estimated_playout_ntp_timestamp_ms)));
               }
-              local.mFramesReceived.Construct(
-                  videoStats->frame_counts.key_frames +
-                  videoStats->frame_counts.delta_frames);
+               */
               // Not including frames dropped in the rendering pipe, which
               // is not of webrtc's concern anyway?!
               local.mFramesDropped.Construct(videoStats->frames_dropped);
-               */
               if (!report->mInboundRtpStreamStats.AppendElement(
                       std::move(local), fallible)) {
                 mozalloc_handle_oom(0);

diff --git a/dom/webidl/RTCStatsReport.webidl b/dom/webidl/RTCStatsReport.webidl
@@ -66,6 +66,7 @@ dictionary RTCInboundRtpStreamStats : RTCReceivedRtpStreamStats {
   required DOMString trackIdentifier;
   DOMString remoteId;
   unsigned long framesDecoded;
+  unsigned long framesDropped;
   unsigned long frameWidth;
   unsigned long frameHeight;
   double framesPerSecond;