Skip to content

Commit

Permalink
Backed out 2 changesets (bug 1440203) for Backout conflicts with Bug …
Browse files Browse the repository at this point in the history
…1654103. CLOSED TREE

Backed out changeset 6e44c037b2dc (bug 1440203)
Backed out changeset ab11665d8607 (bug 1440203)
  • Loading branch information
dgluca committed Oct 22, 2020
1 parent 26b7826 commit 0b08f6e
Show file tree
Hide file tree
Showing 8 changed files with 96 additions and 480 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -809,14 +809,6 @@ add_task(async function() {
continue;
}

// "Files" from memfd_create() are similar to tmpfs but never
// exist in the filesystem; however, they have names which are
// exposed in procfs, and the I/O interposer observes when
// they're close()d.
if (LINUX && filename.startsWith("/memfd:")) {
continue;
}

// Shared memory uses temporary files on MacOS <= 10.11 to avoid
// a kernel security bug that will never be patched (see
// https://crbug.com/project-zero/1671 for details). This can
Expand Down
8 changes: 0 additions & 8 deletions build/moz.configure/headers.configure
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,6 @@ check_headers(
"byteswap.h",
)

# memfd_create(2) -- Note that older versions of the Linux man-pages
# project incorrectly cite <sys/memfd.h>, which doesn't exist; this
# was fixed in the man-pages-5.00 release.
set_define('HAVE_MEMFD_CREATE',
try_compile(includes=['sys/mman.h'],
body='memfd_create("", 0);',
check_msg='for memfd_create in sys/mman.h'))

# TODO: Move these checks to file specific to --enable-project=js.
have_perf_event_h = check_header("linux/perf_event.h", when=building_linux)

Expand Down
5 changes: 0 additions & 5 deletions config/system-headers.mozbuild
Original file line number Diff line number Diff line change
Expand Up @@ -1352,10 +1352,5 @@ if CONFIG['OS_TARGET'] == 'Linux' and CONFIG['CPU_ARCH'].startswith('mips'):
'sys/cachectl.h',
]

if CONFIG['OS_TARGET'] == 'FreeBSD':
system_headers += [
'sys/capsicum.h',
]

if CONFIG['MOZ_APP_SYSTEM_HEADERS']:
include("../" + CONFIG['MOZ_BUILD_APP'] + "/app-system-headers.mozbuild")
69 changes: 0 additions & 69 deletions ipc/chromium/src/base/linux_memfd_defs.h

This file was deleted.

3 changes: 1 addition & 2 deletions ipc/chromium/src/base/shared_memory.h
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,8 @@ class SharedMemory {
// If true indicates this came from an external source so needs extra checks
// before being mapped.
bool external_section_ = false;
#elif defined(OS_POSIX) && !defined(ANDROID)
#elif defined(OS_POSIX)
mozilla::UniqueFileHandle frozen_file_;
bool is_memfd_ = false;
#endif
bool read_only_ = false;
bool freezeable_ = false;
Expand Down
Loading

0 comments on commit 0b08f6e

Please sign in to comment.