Skip to content

Commit

Permalink
Bug 1401453 - Don't keep libmemory.a separate anymore. r=gps
Browse files Browse the repository at this point in the history
This was done in bug 736564 for the xulrunner SDK, which later became
the firefox SDK, which is now gone. So we don't actually need to keep it
separate anymore (except for logalloc/replay, which still needs to link
it directly, so we keep the library definition intact so it can be
referenced ; we just don't DIST_INSTALL it anymore, and always make it
linked into mozglue)
  • Loading branch information
glandium committed Sep 20, 2017
1 parent 0315399 commit 0d6d459
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 11 deletions.
7 changes: 2 additions & 5 deletions build/gecko_templates.mozbuild
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,8 @@ def GeckoBinary(linkage='dependent', msvcrt='dynamic', mozglue=None):
if mozglue == 'program':
USE_LIBS += ['mozglue']
DEFINES['MOZ_HAS_MOZGLUE'] = True
if CONFIG['MOZ_GLUE_IN_PROGRAM']:
if CONFIG['GNU_CC']:
LDFLAGS += ['-rdynamic']
if CONFIG['MOZ_MEMORY']:
USE_LIBS += ['memory']
if CONFIG['MOZ_GLUE_IN_PROGRAM'] and CONFIG['GNU_CC']:
LDFLAGS += ['-rdynamic']
elif mozglue == 'library':
LIBRARY_DEFINES['MOZ_HAS_MOZGLUE'] = True
if not CONFIG['MOZ_GLUE_IN_PROGRAM']:
Expand Down
7 changes: 1 addition & 6 deletions memory/build/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,12 @@ if CONFIG['OS_TARGET'] == 'Darwin' and (CONFIG['MOZ_REPLACE_MALLOC'] or

Library('memory')

if CONFIG['MOZ_GLUE_IN_PROGRAM']:
DIST_INSTALL = True

if CONFIG['OS_TARGET'] == 'Android' and CONFIG['CC_TYPE'] == 'clang':
CFLAGS += [
'-Wno-tautological-pointer-compare',
]

# Keep jemalloc separated when mozglue is statically linked
if CONFIG['MOZ_MEMORY'] and CONFIG['OS_TARGET'] in ('WINNT', 'Darwin', 'Android'):
FINAL_LIBRARY = 'mozglue'
FINAL_LIBRARY = 'mozglue'

if CONFIG['GNU_CXX']:
# too many warnings from functions generated through rb_wrab from rb.h.
Expand Down

0 comments on commit 0d6d459

Please sign in to comment.