Bug 1586817 - Skip some browser/base/content NPAPI tests when Fission…

… is enabled. r=kmag

NPAPI / Flash are EOL'ing in 2020, and we're unlikely to spend time trying to make
them work with Fission enabled. For now we can just disable these tests.

Differential Revision: https://phabricator.services.mozilla.com/D48444

browser/base/content/test/plugins/browser-rs-blocklist.ini

@@ -41,7 +41,7 @@ support-files =
 [browser_bug812562.js]
 [browser_clearplugindata.js]
 [browser_CTP_context_menu.js]
-skip-if = fission || toolkit == "gtk"   # fails intermittently on Linux (bug 909342)
+skip-if = fission || toolkit == "gtk" # Fails with Fission, and we're unlikely to spend time to fix it. fails intermittently on Linux (bug 909342)
 [browser_CTP_crashreporting.js]
 skip-if = !crashreporter || verify || os == 'win' # bug 1442837
 [browser_CTP_drag_drop.js]

browser/base/content/test/plugins/browser.ini

@@ -50,7 +50,7 @@ support-files =
 [browser_bug743421.js]
 tags = blocklist
 [browser_bug744745.js]
-fail-if = fission
+skip-if = fission # Fails with Fission, and we're unlikely to spend time to fix it.
 [browser_bug787619.js]
 [browser_bug797677.js]
 [browser_bug812562.js]
@@ -59,7 +59,7 @@ tags = blocklist
 [browser_clearplugindata.js]
 tags = blocklist
 [browser_CTP_context_menu.js]
-skip-if = fission || toolkit == "gtk"   # fails intermittently on Linux (bug 909342)
+skip-if = fission || toolkit == "gtk" # Fails with Fission, and we're unlikely to spend time to fix it. fails intermittently on Linux (bug 909342)
 tags = blocklist
 [browser_CTP_crashreporting.js]
 skip-if = !crashreporter || verify || os == 'win' # bug 1442837
@@ -99,9 +99,9 @@ skip-if = (os == 'win' && processor == 'aarch64') # bug 1533164
 [browser_globalplugin_crashinfobar.js]
 skip-if = !crashreporter
 [browser_pluginCrashCommentAndURL.js]
-skip-if = fission || !crashreporter
+skip-if = fission || !crashreporter # Fails with Fission, and we're unlikely to spend time to fix it.
 [browser_pluginCrashReportNonDeterminism.js]
 skip-if = !crashreporter
 [browser_private_clicktoplay.js]
 [browser_subframe_access_hidden_plugins.js]
-fail-if = fission
+skip-if = fission # Fails with Fission, and we're unlikely to spend time to fix it.