Skip to content

Commit

Permalink
Bug 1491999: Quote command line for multiple components. r=mhowell
Browse files Browse the repository at this point in the history
The macro expansion of ExecAndWaitForInputIdle consumes the quotes
around the macro argument. The argument has an extra layer of quotes
around the executable name, which keeps it together even if it has
spaces, but we need yet another layer around the whole command line or
else each component of the command line appears as another argument to
StrCpy.

Standard practice is to quote args in the macro definition, I overlooked
this in the initial implementation.

Differential Revision: https://phabricator.services.mozilla.com/D6111
  • Loading branch information
agashlin committed Sep 18, 2018
1 parent 277247e commit 13f12d6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion toolkit/mozapps/installer/windows/nsis/common.nsh
Original file line number Diff line number Diff line change
Expand Up @@ -8132,7 +8132,7 @@
Push $2

; Command line
StrCpy $0 ${CMDLINE}
StrCpy $0 "${CMDLINE}"

; STARTUPINFO
System::Alloc 68
Expand Down

0 comments on commit 13f12d6

Please sign in to comment.