Bug 1231378 - part 4 - Fix uninitialized members of classes in netwer…

…k/widget/storage/uriloader/memory/tools, r=smaug
iaxat · Jan 12, 2016 · 1461ee4 · 1461ee4
1 parent 71abb1e
commit 1461ee4
Show file tree

Hide file tree

Showing 19 changed files with 88 additions and 4 deletions.
diff --git a/memory/volatile/VolatileBuffer.h b/memory/volatile/VolatileBuffer.h
@@ -88,7 +88,11 @@ class VolatileBuffer
 
 class VolatileBufferPtr_base {
 public:
-  explicit VolatileBufferPtr_base(VolatileBuffer* vbuf) : mVBuf(vbuf) {
+  explicit VolatileBufferPtr_base(VolatileBuffer* vbuf)
+    : mVBuf(vbuf)
+    , mMapping(nullptr)
+    , mPurged(false)
+  {
     Lock();
   }
 

diff --git a/netwerk/dns/ChildDNSService.cpp b/netwerk/dns/ChildDNSService.cpp
@@ -43,6 +43,7 @@ NS_IMPL_ISUPPORTS(ChildDNSService,
 ChildDNSService::ChildDNSService()
   : mFirstTime(true)
   , mOffline(false)
+  , mDisablePrefetch(false)
   , mPendingRequestsLock("DNSPendingRequestsLock")
 {
   MOZ_ASSERT(IsNeckoChild());

diff --git a/netwerk/dns/DNS.cpp b/netwerk/dns/DNS.cpp
@@ -261,6 +261,9 @@ NetAddrElement::~NetAddrElement()
 
 AddrInfo::AddrInfo(const char *host, const PRAddrInfo *prAddrInfo,
                    bool disableIPv4, bool filterNameCollision, const char *cname)
+  : mHostName(nullptr)
+  , mCanonicalName(nullptr)
+  , ttl(NO_TTL_DATA)
 {
   MOZ_ASSERT(prAddrInfo, "Cannot construct AddrInfo with a null prAddrInfo pointer!");
   const uint32_t nameCollisionAddr = htonl(0x7f003535); // 127.0.53.53
@@ -281,6 +284,9 @@ AddrInfo::AddrInfo(const char *host, const PRAddrInfo *prAddrInfo,
 }
 
 AddrInfo::AddrInfo(const char *host, const char *cname)
+  : mHostName(nullptr)
+  , mCanonicalName(nullptr)
+  , ttl(NO_TTL_DATA)
 {
   Init(host, cname);
 }

diff --git a/netwerk/dns/DNSRequestParent.cpp b/netwerk/dns/DNSRequestParent.cpp
@@ -20,7 +20,8 @@ namespace mozilla {
 namespace net {
 
 DNSRequestParent::DNSRequestParent()
-  : mIPCClosed(false)
+  : mFlags(0)
+  , mIPCClosed(false)
 {
 
 }

diff --git a/netwerk/dns/nsDNSService2.cpp b/netwerk/dns/nsDNSService2.cpp
@@ -480,8 +480,12 @@ class NotifyDNSResolution: public nsRunnable
 
 nsDNSService::nsDNSService()
     : mLock("nsDNSServer.mLock")
+    , mDisableIPv6(false)
+    , mDisablePrefetch(false)
     , mFirstTime(true)
     , mOffline(false)
+    , mNotifyResolution(false)
+    , mOfflineLocalhost(false)
 {
 }
 

diff --git a/netwerk/dns/nsIDNService.cpp b/netwerk/dns/nsIDNService.cpp
@@ -132,6 +132,8 @@ void nsIDNService::prefsChanged(nsIPrefBranch *prefBranch, const char16_t *pref)
 }
 
 nsIDNService::nsIDNService()
+  : mShowPunycode(false)
+  , mIDNUseWhitelist(false)
 {
 #ifdef IDNA2008
   uint32_t IDNAOptions = UIDNA_CHECK_BIDI | UIDNA_CHECK_CONTEXTJ;

diff --git a/storage/mozStorageBindingParams.cpp b/storage/mozStorageBindingParams.cpp
@@ -108,6 +108,7 @@ BindingParams::BindingParams(mozIStorageBindingParamsArray *aOwningArray,
 : mLocked(false)
 , mOwningArray(aOwningArray)
 , mOwningStatement(aOwningStatement)
+, mParamCount(0)
 {
   (void)mOwningStatement->GetParameterCount(&mParamCount);
   mParameters.SetCapacity(mParamCount);

diff --git a/storage/mozStorageRow.h b/storage/mozStorageRow.h
@@ -24,6 +24,8 @@ class Row final : public mozIStorageRow
   NS_DECL_MOZISTORAGEROW
   NS_DECL_MOZISTORAGEVALUEARRAY
 
+  Row() : mNumCols(0) {}
+
   /**
    * Initializes the object with the given statement.  Copies the values from
    * the statement.

diff --git a/storage/mozStorageStatementData.h b/storage/mozStorageStatementData.h
@@ -44,6 +44,7 @@ class StatementData
     NS_PRECONDITION(mStatementOwner, "Must have a statement owner!");
   }
   StatementData()
+  : mStatement(nullptr)
   {
   }
   ~StatementData()

diff --git a/storage/mozStorageStatementParams.cpp b/storage/mozStorageStatementParams.cpp
@@ -21,7 +21,8 @@ namespace storage {
 //// StatementParams
 
 StatementParams::StatementParams(mozIStorageStatement *aStatement) :
-    mStatement(aStatement)
+    mStatement(aStatement),
+    mParamCount(0)
 {
   NS_ASSERTION(mStatement != nullptr, "mStatement is null");
   (void)mStatement->GetParameterCount(&mParamCount);

diff --git a/tools/profiler/public/GeckoProfilerImpl.h b/tools/profiler/public/GeckoProfilerImpl.h
@@ -432,6 +432,7 @@ class MOZ_STACK_CLASS SamplerStackFramePrintfRAII {
   // we only copy the strings at save time, so to take multiple parameters we'd need to copy them then.
   SamplerStackFramePrintfRAII(const char *aInfo,
     js::ProfileEntry::Category aCategory, uint32_t line, const char *aFormat, ...)
+    : mHandle(nullptr)
   {
     if (profiler_is_active() && !profiler_in_privacy_mode()) {
       va_list args;

diff --git a/uriloader/prefetch/OfflineCacheUpdateChild.cpp b/uriloader/prefetch/OfflineCacheUpdateChild.cpp
@@ -76,6 +76,7 @@ NS_IMPL_RELEASE(OfflineCacheUpdateChild)
 OfflineCacheUpdateChild::OfflineCacheUpdateChild(nsIDOMWindow* aWindow)
     : mState(STATE_UNINITIALIZED)
     , mIsUpgrade(false)
+    , mSucceeded(false)
     , mAppID(NECKO_NO_APP_ID)
     , mInBrowser(false)
     , mWindow(aWindow)

diff --git a/uriloader/prefetch/nsOfflineCacheUpdate.cpp b/uriloader/prefetch/nsOfflineCacheUpdate.cpp
@@ -687,6 +687,7 @@ nsOfflineManifestItem::nsOfflineManifestItem(nsIURI *aURI,
                                nsIApplicationCache::ITEM_MANIFEST)
     , mParserState(PARSE_INIT)
     , mNeedsUpdate(true)
+    , mStrictFileOriginPolicy(false)
     , mManifestHashInitialized(false)
 {
     ReadStrictFileOriginPolicyPref();
@@ -1168,6 +1169,7 @@ nsOfflineCacheUpdate::nsOfflineCacheUpdate()
     , mRescheduleCount(0)
     , mPinnedEntryRetriesCount(0)
     , mPinned(false)
+    , mByteProgress(0)
 {
 }
 

diff --git a/widget/BasicEvents.h b/widget/BasicEvents.h
@@ -190,6 +190,7 @@ class WidgetEvent
   }
 
   WidgetEvent()
+    : time(0)
   {
     MOZ_COUNT_CTOR(WidgetEvent);
   }
@@ -570,6 +571,7 @@ class WidgetInputEvent : public WidgetGUIEvent
   }
 
   WidgetInputEvent()
+    : modifiers(0)
   {
   }
 

diff --git a/widget/MouseEvents.h b/widget/MouseEvents.h
@@ -74,6 +74,11 @@ class WidgetMouseEventBase : public WidgetInputEvent
 
 protected:
   WidgetMouseEventBase()
+    : button(0)
+    , buttons(0)
+    , pressure(0)
+    , hitCluster(false)
+    , inputSource(nsIDOMMouseEvent::MOZ_SOURCE_MOUSE)
   {
   }
 
@@ -195,6 +200,9 @@ class WidgetMouseEvent : public WidgetMouseEventBase, public WidgetPointerHelper
 
 protected:
   WidgetMouseEvent()
+    : acceptActivation(false)
+    , ignoreRootScrollFrame(false)
+    , clickCount(0)
   {
   }
 
@@ -316,6 +324,8 @@ class WidgetDragEvent : public WidgetMouseEvent
   friend class mozilla::dom::PBrowserChild;
 protected:
   WidgetDragEvent()
+    : userCancelled(false)
+    , mDefaultPreventedOnContent(false)
   {
   }
 public:
@@ -373,6 +383,8 @@ class WidgetMouseScrollEvent : public WidgetMouseEventBase
 {
 private:
   WidgetMouseScrollEvent()
+    : delta(0)
+    , isHorizontal(false)
   {
   }
 
@@ -436,6 +448,20 @@ class WidgetWheelEvent : public WidgetMouseEventBase
   friend class mozilla::dom::PBrowserChild;
 
   WidgetWheelEvent()
+    : deltaX(0.0)
+    , deltaY(0.0)
+    , deltaZ(0.0)
+    , deltaMode(nsIDOMWheelEvent::DOM_DELTA_PIXEL)
+    , customizedByUserPrefs(false)
+    , isMomentum(false)
+    , mIsNoLineOrPageDelta(false)
+    , lineOrPageDeltaX(0)
+    , lineOrPageDeltaY(0)
+    , scrollType(SCROLL_DEFAULT)
+    , overflowDeltaX(0.0)
+    , overflowDeltaY(0.0)
+    , mViewPortIsOverscrolled(false)
+    , mCanTriggerSwipe(false)
   {
   }
 
@@ -605,6 +631,9 @@ class WidgetPointerEvent : public WidgetMouseEvent
   friend class mozilla::dom::PBrowserChild;
 
   WidgetPointerEvent()
+    : width(0)
+    , height(0)
+    , isPrimary(true)
   {
   }
 

diff --git a/widget/ScreenProxy.cpp b/widget/ScreenProxy.cpp
@@ -20,7 +20,11 @@ using namespace mozilla::dom;
 static NS_DEFINE_CID(kAppShellCID, NS_APPSHELL_CID);
 
 ScreenProxy::ScreenProxy(nsScreenManagerProxy* aScreenManager, ScreenDetails aDetails)
-  : mScreenManager(aScreenManager)
+  : mContentsScaleFactor(0)
+  , mScreenManager(aScreenManager)
+  , mId(0)
+  , mPixelDepth(0)
+  , mColorDepth(0)
   , mCacheValid(false)
   , mCacheWillInvalidate(false)
 {

diff --git a/widget/TextEvents.h b/widget/TextEvents.h
@@ -82,6 +82,20 @@ class WidgetKeyboardEvent : public WidgetInputEvent
 
 protected:
   WidgetKeyboardEvent()
+    : keyCode(0)
+    , charCode(0)
+    , location(nsIDOMKeyEvent::DOM_KEY_LOCATION_STANDARD)
+    , isChar(false)
+    , mIsRepeat(false)
+    , mIsComposing(false)
+    , mKeyNameIndex(mozilla::KEY_NAME_INDEX_Unidentified)
+    , mCodeNameIndex(CODE_NAME_INDEX_UNKNOWN)
+    , mNativeKeyEvent(nullptr)
+    , mUniqueId(0)
+#ifdef XP_MACOSX
+    , mNativeKeyCode(0)
+    , mNativeModifierFlags(0)
+#endif
   {
   }
 
@@ -470,6 +484,9 @@ class WidgetQueryContentEvent : public WidgetGUIEvent
   friend class dom::PBrowserChild;
 
   WidgetQueryContentEvent()
+    : mSucceeded(false)
+    , mUseNativeLineBreak(true)
+    , mWithFontRanges(false)
   {
     MOZ_CRASH("WidgetQueryContentEvent is created without proper arguments");
   }
@@ -650,6 +667,7 @@ class WidgetSelectionEvent : public WidgetGUIEvent
     , mReversed(false)
     , mExpandToClusterBoundary(true)
     , mSucceeded(false)
+    , mUseNativeLineBreak(true)
   {
   }
 

diff --git a/widget/nsFilePickerProxy.cpp b/widget/nsFilePickerProxy.cpp
@@ -16,6 +16,7 @@ using namespace mozilla::dom;
 NS_IMPL_ISUPPORTS(nsFilePickerProxy, nsIFilePicker)
 
 nsFilePickerProxy::nsFilePickerProxy()
+  : mSelectedType(0)
 {
 }
 

diff --git a/widget/xremoteclient/XRemoteClient.cpp b/widget/xremoteclient/XRemoteClient.cpp
@@ -62,9 +62,12 @@ XRemoteClient::XRemoteClient()
   mInitialized = false;
   mMozVersionAtom = 0;
   mMozLockAtom = 0;
+  mMozCommandLineAtom = 0;
   mMozResponseAtom = 0;
   mMozWMStateAtom = 0;
   mMozUserAtom = 0;
+  mMozProfileAtom = 0;
+  mMozProgramAtom = 0;
   mLockData = 0;
   if (!sRemoteLm)
     sRemoteLm = PR_NewLogModule("XRemoteClient");
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,6 +16,7 @@ using namespace mozilla::dom; @@
     NS_IMPL_ISUPPORTS(nsFilePickerProxy, nsIFilePicker)
     nsFilePickerProxy::nsFilePickerProxy()
+      : mSelectedType(0)
     {
     }
@@ Expand Down @@