Bug 1237151 (part 3) - Remove ignored qualifiers in all remaining cod…

…e. r=froydnj.

docshell/base/timeline/AbstractTimelineMarker.h

@@ -49,8 +49,8 @@ class AbstractTimelineMarker
   DOMHighResTimeStamp GetTime() const { return mTime; }
   MarkerTracingType GetTracingType() const { return mTracingType; }
 
-  const uint8_t GetProcessType() const { return mProcessType; };
-  const bool IsOffMainThread() const { return mIsOffMainThread; };
+  uint8_t GetProcessType() const { return mProcessType; };
+  bool IsOffMainThread() const { return mIsOffMainThread; };
 
 private:
   const char* mName;

dom/gamepad/cocoa/CocoaGamepad.cpp

@@ -93,7 +93,7 @@ class Gamepad {
   // Index given by our superclass.
   uint32_t mSuperIndex;
 
-  const bool isDpad(IOHIDElementRef element) const
+  bool isDpad(IOHIDElementRef element) const
   {
     return element == mDpad;
   }

dom/inputport/InputPortData.cpp

@@ -103,7 +103,7 @@ InputPortData::GetId() const
   return mId;
 }
 
-const InputPortType
+InputPortType
 InputPortData::GetType() const
 {
   return ToInputPortType(mType);

dom/inputport/InputPortData.h

@@ -33,7 +33,7 @@ class InputPortData final : public nsIInputPortData
 
   const nsString& GetId() const;
 
-  const InputPortType GetType() const;
+  InputPortType GetType() const;
 
 private:
   ~InputPortData();

dom/media/android/AndroidMediaDecoder.h

@@ -17,7 +17,7 @@ class AndroidMediaDecoder : public MediaDecoder
 public:
   AndroidMediaDecoder(MediaDecoderOwner* aOwner, const nsACString& aType);
 
-  const nsresult GetContentType(nsACString& aType) const {
+  nsresult GetContentType(nsACString& aType) const {
     aType = mType;
     return NS_OK;
   }

dom/media/omx/OMXCodecWrapper.cpp

@@ -805,7 +805,7 @@ class InputBufferHelper final {
 private:
   uint8_t* GetPointer() { return mData + mOffset; }
 
-  const size_t AvailableSize() { return mCapicity - mOffset; }
+  size_t AvailableSize() const { return mCapicity - mOffset; }
 
   void IncreaseOffset(size_t aValue)
   {
@@ -814,12 +814,12 @@ class InputBufferHelper final {
     mOffset += aValue;
   }
 
-  bool IsEmpty()
+  bool IsEmpty() const
   {
     return (mOffset == 0);
   }
 
-  const size_t GetCapacity()
+  size_t GetCapacity() const
   {
     return mCapicity;
   }

dom/notification/Notification.h

@@ -344,7 +344,7 @@ class Notification : public DOMEventTargetHelper
     }
   }
 
-  static const NotificationDirection StringToDirection(const nsAString& aDirection)
+  static NotificationDirection StringToDirection(const nsAString& aDirection)
   {
     if (aDirection.EqualsLiteral("ltr")) {
       return NotificationDirection::Ltr;

dom/plugins/ipc/PluginMessageUtils.h

@@ -120,7 +120,7 @@ typedef mozilla::null_t DXGISharedSurfaceHandle;
 // XXX maybe not the best place for these. better one?
 
 #define VARSTR(v_)  case v_: return #v_
-inline const char* const
+inline const char*
 NPPVariableToString(NPPVariable aVar)
 {
     switch (aVar) {

dom/presentation/provider/MulticastDNSDeviceProvider.h

@@ -86,12 +86,12 @@ class MulticastDNSDeviceProvider final
       return mAddress;
     }
 
-    const uint16_t Port() const
+    uint16_t Port() const
     {
       return mPort;
     }
 
-    const DeviceState State() const
+    DeviceState State() const
     {
       return mState;
     }

dom/smil/nsSMILCSSValueType.cpp

@@ -72,7 +72,7 @@ GetZeroValueForUnit(StyleAnimationValue::Unit aUnit)
 // with a eUnit_Float value.  (See comment below.)
 //
 // Returns true on success, or false.
-static const bool
+static bool
 FinalizeStyleAnimationValues(const StyleAnimationValue*& aValue1,
                              const StyleAnimationValue*& aValue2)
 {

dom/svg/SVGTransform.h

@@ -134,7 +134,7 @@ class SVGTransform final : public nsWrapperCache
 
   // Interface for SVGMatrix's use
   friend class dom::SVGMatrix;
-  const bool IsAnimVal() const {
+  bool IsAnimVal() const {
     return mIsAnimValItem;
   }
   const gfxMatrix& Matrixgfx() const {

embedding/components/printingui/unixshared/nsPrintingPromptService.cpp

@@ -43,7 +43,7 @@ class ParamBlock {
       return CallCreateInstance(NS_DIALOGPARAMBLOCK_CONTRACTID, &mBlock);
     }
     nsIDialogParamBlock * operator->() const MOZ_NO_ADDREF_RELEASE_ON_RETURN { return mBlock; }
-    operator nsIDialogParamBlock * const ()  { return mBlock; }
+    operator nsIDialogParamBlock * () const { return mBlock; }
 
 private:
     nsIDialogParamBlock *mBlock;

gfx/layers/Layers.cpp

@@ -941,7 +941,7 @@ Layer::ApplyPendingUpdatesForThisTransaction()
   }
 }
 
-const float
+float
 Layer::GetLocalOpacity()
 {
   float opacity = mOpacity;

gfx/layers/Layers.h

@@ -1354,7 +1354,7 @@ class Layer {
    * Returns the local opacity for this layer: either mOpacity or,
    * for shadow layers, GetShadowOpacity()
    */
-  const float GetLocalOpacity();
+  float GetLocalOpacity();
 
   /**
    * DRAWING PHASE ONLY
@@ -1637,7 +1637,7 @@ class Layer {
    * marked as needed to be recomposited.
    */
   const nsIntRegion& GetInvalidRegion() { return mInvalidRegion; }
-  const void AddInvalidRegion(const nsIntRegion& aRegion) {
+  void AddInvalidRegion(const nsIntRegion& aRegion) {
     mInvalidRegion.Or(mInvalidRegion, aRegion);
   }
 

gfx/thebes/gfxUtils.cpp

@@ -92,11 +92,11 @@ void mozilla_dump_image(void* bytes, int width, int height, int bytepp,
 
 }
 
-static const uint8_t PremultiplyValue(uint8_t a, uint8_t v) {
+static uint8_t PremultiplyValue(uint8_t a, uint8_t v) {
     return gfxUtils::sPremultiplyTable[a*256+v];
 }
 
-static const uint8_t UnpremultiplyValue(uint8_t a, uint8_t v) {
+static uint8_t UnpremultiplyValue(uint8_t a, uint8_t v) {
     return gfxUtils::sUnpremultiplyTable[a*256+v];
 }
 

ipc/chromium/src/chrome/common/ipc_message.h

@@ -194,7 +194,7 @@ class Message : public Pickle {
     header()->seqno = aSeqno;
   }
 
-  const char* const name() const {
+  const char* name() const {
     return name_;
   }
 

ipc/chromium/src/chrome/common/ipc_message_utils.h

@@ -53,7 +53,7 @@ class MessageIterator {
       NOTREACHED();
     return val;
   }
-  const void NextData(const char** data, int* length) const {
+  void NextData(const char** data, int* length) const {
     if (!msg_.ReadData(&iter_, data, length)) {
       NOTREACHED();
     }

ipc/ipdl/ipdl/lower.py

@@ -577,7 +577,7 @@ def _cxxConstPtrToType(ipdltype, side):
         t.ptrconstptr = 1
         return t
     t.const = 1
-    t.ptrconst = 1
+    t.ptr = 1
     return t
 
 def _allocMethod(ptype, side):

layout/base/nsPresContext.h

@@ -403,18 +403,18 @@ class nsPresContext : public nsIObserver {
   /**
    * Get the default colors
    */
-  const nscolor DefaultColor() const { return mDefaultColor; }
-  const nscolor DefaultBackgroundColor() const { return mBackgroundColor; }
-  const nscolor DefaultLinkColor() const { return mLinkColor; }
-  const nscolor DefaultActiveLinkColor() const { return mActiveLinkColor; }
-  const nscolor DefaultVisitedLinkColor() const { return mVisitedLinkColor; }
-  const nscolor FocusBackgroundColor() const { return mFocusBackgroundColor; }
-  const nscolor FocusTextColor() const { return mFocusTextColor; }
+  nscolor DefaultColor() const { return mDefaultColor; }
+  nscolor DefaultBackgroundColor() const { return mBackgroundColor; }
+  nscolor DefaultLinkColor() const { return mLinkColor; }
+  nscolor DefaultActiveLinkColor() const { return mActiveLinkColor; }
+  nscolor DefaultVisitedLinkColor() const { return mVisitedLinkColor; }
+  nscolor FocusBackgroundColor() const { return mFocusBackgroundColor; }
+  nscolor FocusTextColor() const { return mFocusTextColor; }
 
   /**
    * Body text color, for use in quirks mode only.
    */
-  const nscolor BodyTextColor() const { return mBodyTextColor; }
+  nscolor BodyTextColor() const { return mBodyTextColor; }
   void SetBodyTextColor(nscolor aColor) { mBodyTextColor = aColor; }
 
   bool GetUseFocusColors() const { return mUseFocusColors; }

layout/generic/nsGridContainerFrame.cpp

@@ -321,7 +321,7 @@ class MOZ_STACK_CLASS nsGridContainerFrame::LineNameMap
   }
 
   // Return true if aName exists at aIndex.
-  const bool Contains(uint32_t aIndex, const nsString& aName) const
+  bool Contains(uint32_t aIndex, const nsString& aName) const
   {
     if (!mHasRepeatAuto) {
       return mLineNameLists[aIndex].Contains(aName);

mozglue/linker/Mappable.h

@@ -239,18 +239,18 @@ class MappableSeekableZStream: public Mappable
     }
 
     /* Returns offset + length */
-    const off_t endOffset() const {
+    off_t endOffset() const {
       return offset + length;
     }
 
     /* Returns the offset corresponding to the given address */
-    const off_t offsetOf(const void *ptr) const {
+    off_t offsetOf(const void *ptr) const {
       return reinterpret_cast<uintptr_t>(ptr)
              - reinterpret_cast<uintptr_t>(addr) + offset;
     }
 
     /* Returns whether the given address is in the LazyMap range */
-    const bool Contains(const void *ptr) const {
+    bool Contains(const void *ptr) const {
       return (ptr >= addr) && (ptr < end());
     }
   };

mozglue/linker/SeekableZStream.h

@@ -77,18 +77,18 @@ class SeekableZStream {
   bool DecompressChunk(void *where, size_t chunk, size_t length = 0);
 
   /* Returns the uncompressed size of the complete zstream */
-  const size_t GetUncompressedSize() const
+  size_t GetUncompressedSize() const
   {
     return (offsetTable.numElements() - 1) * chunkSize + lastChunkSize;
   }
 
   /* Returns the chunk size of the given chunk */
-  const size_t GetChunkSize(size_t chunk = 0) const {
+  size_t GetChunkSize(size_t chunk = 0) const {
     return (chunk == offsetTable.numElements() - 1) ? lastChunkSize : chunkSize;
   }
 
   /* Returns the number of chunks */
-  const size_t GetChunksNum() const {
+  size_t GetChunksNum() const {
     return offsetTable.numElements();
   }
 

netwerk/cache2/CacheObserver.cpp

@@ -240,7 +240,7 @@ CacheObserver::AttachToPreferences()
 }
 
 // static
-uint32_t const CacheObserver::MemoryCacheCapacity()
+uint32_t CacheObserver::MemoryCacheCapacity()
 {
   if (sMemoryCacheCapacity >= 0)
     return sMemoryCacheCapacity << 10;
@@ -278,7 +278,7 @@ uint32_t const CacheObserver::MemoryCacheCapacity()
 }
 
 // static
-bool const CacheObserver::UseNewCache()
+bool CacheObserver::UseNewCache()
 {
   uint32_t useNewCache = sUseNewCache;
 
@@ -441,7 +441,7 @@ nsresult Run(NeckoOriginAttributes const &aOa)
 } // anon
 
 // static
-bool const CacheObserver::EntryIsTooBig(int64_t aSize, bool aUsingDisk)
+bool CacheObserver::EntryIsTooBig(int64_t aSize, bool aUsingDisk)
 {
   // If custom limit is set, check it.
   int64_t preferredLimit = aUsingDisk ? sMaxDiskEntrySize : sMaxMemoryEntrySize;

netwerk/cache2/CacheObserver.h

@@ -27,49 +27,49 @@ class CacheObserver : public nsIObserver
   static CacheObserver* Self() { return sSelf; }
 
   // Access to preferences
-  static bool const UseNewCache();
-  static bool const UseDiskCache()
+  static bool UseNewCache();
+  static bool UseDiskCache()
     { return sUseDiskCache; }
-  static bool const UseMemoryCache()
+  static bool UseMemoryCache()
     { return sUseMemoryCache; }
-  static uint32_t const MetadataMemoryLimit() // result in bytes.
+  static uint32_t MetadataMemoryLimit() // result in bytes.
     { return sMetadataMemoryLimit << 10; }
-  static uint32_t const MemoryCacheCapacity(); // result in bytes.
-  static uint32_t const DiskCacheCapacity() // result in bytes.
+  static uint32_t MemoryCacheCapacity(); // result in bytes.
+  static uint32_t DiskCacheCapacity() // result in bytes.
     { return sDiskCacheCapacity << 10; }
   static void SetDiskCacheCapacity(uint32_t); // parameter in bytes.
-  static uint32_t const DiskFreeSpaceSoftLimit() // result in bytes.
+  static uint32_t DiskFreeSpaceSoftLimit() // result in bytes.
     { return sDiskFreeSpaceSoftLimit << 10; }
-  static uint32_t const DiskFreeSpaceHardLimit() // result in bytes.
+  static uint32_t DiskFreeSpaceHardLimit() // result in bytes.
     { return sDiskFreeSpaceHardLimit << 10; }
-  static bool const SmartCacheSizeEnabled()
+  static bool SmartCacheSizeEnabled()
     { return sSmartCacheSizeEnabled; }
-  static uint32_t const PreloadChunkCount()
+  static uint32_t PreloadChunkCount()
     { return sPreloadChunkCount; }
-  static uint32_t const MaxMemoryEntrySize() // result in bytes.
+  static uint32_t MaxMemoryEntrySize() // result in bytes.
     { return sMaxMemoryEntrySize << 10; }
-  static uint32_t const MaxDiskEntrySize() // result in bytes.
+  static uint32_t MaxDiskEntrySize() // result in bytes.
     { return sMaxDiskEntrySize << 10; }
-  static uint32_t const MaxDiskChunksMemoryUsage(bool aPriority) // result in bytes.
+  static uint32_t MaxDiskChunksMemoryUsage(bool aPriority) // result in bytes.
     { return aPriority ? sMaxDiskPriorityChunksMemoryUsage << 10
                        : sMaxDiskChunksMemoryUsage << 10; }
-  static uint32_t const CompressionLevel()
+  static uint32_t CompressionLevel()
     { return sCompressionLevel; }
-  static uint32_t const HalfLifeSeconds()
+  static uint32_t HalfLifeSeconds()
     { return sHalfLifeHours * 60.0F * 60.0F; }
-  static int32_t const HalfLifeExperiment()
+  static int32_t HalfLifeExperiment()
     { return sHalfLifeExperiment; }
-  static bool const ClearCacheOnShutdown()
+  static bool ClearCacheOnShutdown()
     { return sSanitizeOnShutdown && sClearCacheOnShutdown; }
-  static bool const CacheFSReported()
+  static bool CacheFSReported()
     { return sCacheFSReported; }
   static void SetCacheFSReported();
-  static bool const HashStatsReported()
+  static bool HashStatsReported()
     { return sHashStatsReported; }
   static void SetHashStatsReported();
   static void ParentDirOverride(nsIFile ** aDir);
 
-  static bool const EntryIsTooBig(int64_t aSize, bool aUsingDisk);
+  static bool EntryIsTooBig(int64_t aSize, bool aUsingDisk);
 
 private:
   static CacheObserver* sSelf;

netwerk/cache2/CacheStorageService.cpp

@@ -88,7 +88,7 @@ CacheStorageService::MemoryPool::~MemoryPool()
   }
 }
 
-uint32_t const
+uint32_t
 CacheStorageService::MemoryPool::Limit() const
 {
   switch (mType) {

netwerk/cache2/CacheStorageService.h

@@ -324,7 +324,7 @@ class CacheStorageService final : public nsICacheStorageService
     void PurgeAll(uint32_t aWhat);
 
   private:
-    uint32_t const Limit() const;
+    uint32_t Limit() const;
     MemoryPool() = delete;
   };