Skip to content

Commit

Permalink
Bug 1140261 - Fix compiler error comparison of unsigned expression >=…
Browse files Browse the repository at this point in the history
… 0 is always true. r=hchang
  • Loading branch information
chuck-lee committed Mar 9, 2015
1 parent fe23163 commit 4536b2e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions ipc/keystore/KeyStore.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -137,15 +137,15 @@ status_t BnKeystoreService::onTransact(uint32_t code, const Parcel& data, Parcel
case SIGN: {
CHECK_INTERFACE(IKeystoreService, data, reply);
String16 name = data.readString16();
size_t signDataSize = data.readInt32();
ssize_t signDataSize = data.readInt32();
const uint8_t *signData = nullptr;
if (signDataSize >= 0 && signDataSize <= data.dataAvail()) {
if (signDataSize >= 0 && (size_t)signDataSize <= data.dataAvail()) {
signData = (const uint8_t *)data.readInplace(signDataSize);
}

uint8_t *signResult = nullptr;
size_t signResultSize;
int32_t ret = sign(name, signData, signDataSize, &signResult,
int32_t ret = sign(name, signData, (size_t)signDataSize, &signResult,
&signResultSize);

reply->writeNoException();
Expand Down

0 comments on commit 4536b2e

Please sign in to comment.