Bug 1832582 part 1 - Remove unused IonBytecodeInfo::modifiesArguments…

… flag. r=iain Differential Revision: https://phabricator.services.mozilla.com/D178650
iaxat · May 30, 2023 · 542a9eb · 542a9eb
1 parent 12d9d9e
commit 542a9eb
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 10 deletions.
diff --git a/js/src/jit/BytecodeAnalysis.cpp b/js/src/jit/BytecodeAnalysis.cpp
@@ -252,10 +252,6 @@ IonBytecodeInfo js::jit::AnalyzeBytecodeForIon(JSContext* cx,
 
   for (const BytecodeLocation& location : iterator) {
     switch (location.getOp()) {
-      case JSOp::SetArg:
-        result.modifiesArguments = true;
-        break;
-
       case JSOp::GetName:
       case JSOp::BindName:
       case JSOp::BindVar:

diff --git a/js/src/jit/JitScript.h b/js/src/jit/JitScript.h
@@ -57,7 +57,6 @@ class JitZone;
 // in JitScript.
 struct IonBytecodeInfo {
   bool usesEnvironmentChain = false;
-  bool modifiesArguments = false;
 };
 
 // Magic BaselineScript value indicating Baseline compilation has been disabled.
@@ -430,9 +429,6 @@ class alignas(uintptr_t) JitScript final : public TrailingArray {
 
   EnvironmentObject* templateEnvironment() const { return templateEnv_.ref(); }
 
-  bool modifiesArguments() const {
-    return cachedIonBytecodeInfo().modifiesArguments;
-  }
   bool usesEnvironmentChain() const {
     return cachedIonBytecodeInfo().usesEnvironmentChain;
   }

diff --git a/js/src/jit/WarpBuilder.cpp b/js/src/jit/WarpBuilder.cpp
@@ -929,8 +929,6 @@ bool WarpBuilder::build_GetFrameArg(BytecodeLocation loc) {
 }
 
 bool WarpBuilder::build_SetArg(BytecodeLocation loc) {
-  MOZ_ASSERT(script_->jitScript()->modifiesArguments());
-
   uint32_t arg = loc.arg();
   MDefinition* val = current->peek(-1);