Skip to content

Commit

Permalink
Bug 1607193 - Remove MOZ_AUTOMATION_L10N_CHECK; r=firefox-build-syste…
Browse files Browse the repository at this point in the history 
…m-reviewers,rstewart

Differential Revision: https://phabricator.services.mozilla.com/D66715
  • Loading branch information
@mshal
mshal committed Mar 13, 2020
1 parent 998f915 commit 6a1005d
Show file tree
Hide file tree
Showing 45 changed files with 0 additions and 66 deletions.
3 changes: 0 additions & 3 deletions browser/config/mozconfigs/linux32/debug
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
ac_add_options --enable-debug

. $topsrcdir/build/mozconfig.stylo

MOZ_AUTOMATION_L10N_CHECK=0

. $topsrcdir/build/unix/mozconfig.linux32

# Needed to enable breakpad in application.ini
Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/linux32/profile-generate
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
. $topsrcdir/browser/config/mozconfigs/linux32/nightly

mk_add_options "export MOZ_AUTOMATION_PACKAGE_GENERATED_SOURCES=0"
mk_add_options "export MOZ_AUTOMATION_L10N_CHECK=0"

ac_add_options --enable-profile-generate=cross
ac_add_options --disable-tests
1 change: 0 additions & 1 deletion browser/config/mozconfigs/linux32/rusttests
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0

mk_add_options MOZ_MAKE_FLAGS=--output-sync=line

Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/linux32/rusttests-debug
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0

mk_add_options MOZ_MAKE_FLAGS=--output-sync=line

Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/linux64/asan-fuzzing-ccov
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
MOZ_AUTOMATION_L10N_CHECK=0
# We still need to build with debug symbols
ac_add_options --disable-debug
ac_add_options --enable-optimize="-O2 -gline-tables-only"
Expand Down
2 changes: 0 additions & 2 deletions browser/config/mozconfigs/linux64/code-coverage
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
MOZ_AUTOMATION_L10N_CHECK=0

. "$topsrcdir/browser/config/mozconfigs/linux64/nightly"

TOOLTOOL_DIR=${TOOLTOOL_DIR:-$topsrcdir}
Expand Down
3 changes: 0 additions & 3 deletions browser/config/mozconfigs/linux64/debug
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ ac_add_options --enable-debug

. $topsrcdir/build/mozconfig.stylo
. $topsrcdir/build/mozconfig.wasm-sandboxing

MOZ_AUTOMATION_L10N_CHECK=0

. $topsrcdir/build/unix/mozconfig.linux

# Needed to enable breakpad in application.ini
Expand Down
3 changes: 0 additions & 3 deletions browser/config/mozconfigs/linux64/debug-fuzzing
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ ac_add_options --enable-debug

. $topsrcdir/build/mozconfig.stylo
. $topsrcdir/build/mozconfig.wasm-sandboxing

MOZ_AUTOMATION_L10N_CHECK=0

. $topsrcdir/build/unix/mozconfig.linux

# Package js shell.
Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/linux64/debug-searchfox-clang
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0
MOZ_AUTOMATION_CHECK=0

. "$topsrcdir/build/unix/mozconfig.unix"
Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/linux64/debug-static-analysis-clang
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0

. "$topsrcdir/build/mozconfig.common"

Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/linux64/profile-generate
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
. $topsrcdir/browser/config/mozconfigs/linux64/nightly

mk_add_options "export MOZ_AUTOMATION_PACKAGE_GENERATED_SOURCES=0"
mk_add_options "export MOZ_AUTOMATION_L10N_CHECK=0"

ac_add_options --enable-profile-generate=cross
ac_add_options --disable-tests
1 change: 0 additions & 1 deletion browser/config/mozconfigs/linux64/rusttests
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0

mk_add_options MOZ_MAKE_FLAGS=--output-sync=line

Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/linux64/rusttests-debug
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0

mk_add_options MOZ_MAKE_FLAGS=--output-sync=line

Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/linux64/tup
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0
MOZ_AUTOMATION_PACKAGE=0
MOZ_AUTOMATION_UPLOAD=0
MOZ_AUTOMATION_UPLOAD_SYMBOLS=0
Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/macosx64/debug-searchfox
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0
MOZ_AUTOMATION_CHECK=0

. $topsrcdir/build/macosx/mozconfig.common
Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/macosx64/debug-static-analysis
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0

. $topsrcdir/build/macosx/mozconfig.common
. $topsrcdir/build/mozconfig.wasm-sandboxing
Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/macosx64/opt-static-analysis
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0

. $topsrcdir/build/macosx/mozconfig.common
. $topsrcdir/build/mozconfig.wasm-sandboxing
Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/macosx64/profile-generate
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
. $topsrcdir/browser/config/mozconfigs/macosx64/nightly

mk_add_options "export MOZ_AUTOMATION_PACKAGE_GENERATED_SOURCES=0"
mk_add_options "export MOZ_AUTOMATION_L10N_CHECK=0"

ac_add_options --enable-profile-generate=cross
ac_add_options --disable-tests
1 change: 0 additions & 1 deletion browser/config/mozconfigs/win32/debug
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
. "$topsrcdir/build/mozconfig.win-common"
MOZ_AUTOMATION_L10N_CHECK=0
. "$topsrcdir/browser/config/mozconfigs/common"
. "$topsrcdir/browser/config/mozconfigs/win32/common-win32"

Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/win32/debug-static-analysis
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0

. "$topsrcdir/build/mozconfig.win-common"
. "$topsrcdir/browser/config/mozconfigs/common"
Expand Down
2 changes: 0 additions & 2 deletions browser/config/mozconfigs/win32/mingwclang-debug
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
MOZ_AUTOMATION_L10N_CHECK=0

. "$topsrcdir/browser/config/mozconfigs/win32/mingwclang"

ac_add_options --enable-debug
1 change: 0 additions & 1 deletion browser/config/mozconfigs/win32/profile-generate
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
. $topsrcdir/browser/config/mozconfigs/win32/nightly

mk_add_options "export MOZ_AUTOMATION_PACKAGE_GENERATED_SOURCES=0"
mk_add_options "export MOZ_AUTOMATION_L10N_CHECK=0"

ac_add_options --enable-profile-generate=cross
ac_add_options --disable-tests
1 change: 0 additions & 1 deletion browser/config/mozconfigs/win32/rusttests
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0

. "$topsrcdir/browser/config/mozconfigs/win32/nightly"

Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/win32/rusttests-debug
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0

. "$topsrcdir/browser/config/mozconfigs/win32/debug"

Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/win64-aarch64/debug
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
. "$topsrcdir/build/mozconfig.win-common"
MOZ_AUTOMATION_L10N_CHECK=0
. "$topsrcdir/browser/config/mozconfigs/common"

. "$topsrcdir/browser/config/mozconfigs/win64-aarch64/common-win64"
Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/win64/code-coverage
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
. "$topsrcdir/build/mozconfig.win-common"
MOZ_AUTOMATION_L10N_CHECK=0
. "$topsrcdir/browser/config/mozconfigs/common"
. "$topsrcdir/browser/config/mozconfigs/win64/common-win64"

Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/win64/debug
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
. "$topsrcdir/build/mozconfig.win-common"
MOZ_AUTOMATION_L10N_CHECK=0
. "$topsrcdir/browser/config/mozconfigs/common"
. "$topsrcdir/browser/config/mozconfigs/win64/common-win64"

Expand Down
2 changes: 0 additions & 2 deletions browser/config/mozconfigs/win64/debug-asan
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
MOZ_AUTOMATION_L10N_CHECK=0

. "$topsrcdir/build/mozconfig.win-common"
. "$topsrcdir/browser/config/mozconfigs/common"
. "$topsrcdir/browser/config/mozconfigs/win64/common-win64"
Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/win64/debug-searchfox
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0
MOZ_AUTOMATION_CHECK=0

. "$topsrcdir/build/mozconfig.win-common"
Expand Down
2 changes: 0 additions & 2 deletions browser/config/mozconfigs/win64/mingwclang-debug
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
MOZ_AUTOMATION_L10N_CHECK=0

. "$topsrcdir/browser/config/mozconfigs/win64/mingwclang"

ac_add_options --enable-debug
2 changes: 0 additions & 2 deletions browser/config/mozconfigs/win64/nightly-asan
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
MOZ_AUTOMATION_L10N_CHECK=0

. "$topsrcdir/build/mozconfig.win-common"
. "$topsrcdir/browser/config/mozconfigs/common"
. "$topsrcdir/browser/config/mozconfigs/win64/common-win64"
Expand Down
2 changes: 0 additions & 2 deletions browser/config/mozconfigs/win64/nightly-asan-reporter
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
MOZ_AUTOMATION_L10N_CHECK=0

. "$topsrcdir/build/mozconfig.win-common"
. "$topsrcdir/browser/config/mozconfigs/win64/common-win64"
. "$topsrcdir/browser/config/mozconfigs/win64/common-opt"
Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/win64/profile-generate
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
. $topsrcdir/browser/config/mozconfigs/win64/nightly

mk_add_options "export MOZ_AUTOMATION_PACKAGE_GENERATED_SOURCES=0"
mk_add_options "export MOZ_AUTOMATION_L10N_CHECK=0"

ac_add_options --enable-profile-generate=cross
ac_add_options --disable-tests
1 change: 0 additions & 1 deletion browser/config/mozconfigs/win64/rusttests
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0

. "$topsrcdir/browser/config/mozconfigs/win64/nightly"

Expand Down
1 change: 0 additions & 1 deletion browser/config/mozconfigs/win64/rusttests-debug
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0

. "$topsrcdir/browser/config/mozconfigs/win64/debug"

Expand Down
2 changes: 0 additions & 2 deletions build/macosx/cross-mozconfig.common
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

MOZ_AUTOMATION_L10N_CHECK=0

. "$topsrcdir/build/mozconfig.common"

# cctools for ld, ar, and other related tools ; dsymutil for rust.
Expand Down
7 changes: 0 additions & 7 deletions build/moz-automation.mk
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ endif
# Helper variables to convert from MOZ_AUTOMATION_* variables to the
# corresponding the make target
tier_MOZ_AUTOMATION_BUILD_SYMBOLS = buildsymbols
tier_MOZ_AUTOMATION_L10N_CHECK = l10n-check
tier_MOZ_AUTOMATION_PACKAGE = package
tier_MOZ_AUTOMATION_PACKAGE_TESTS = package-tests
tier_MOZ_AUTOMATION_PACKAGE_GENERATED_SOURCES = package-generated-sources
Expand All @@ -65,7 +64,6 @@ moz_automation_symbols = \
MOZ_AUTOMATION_UPLOAD_SYMBOLS \
MOZ_AUTOMATION_PACKAGE \
MOZ_AUTOMATION_PACKAGE_GENERATED_SOURCES \
MOZ_AUTOMATION_L10N_CHECK \
MOZ_AUTOMATION_UPLOAD \
MOZ_AUTOMATION_CHECK \
$(NULL)
Expand All @@ -74,8 +72,6 @@ MOZ_AUTOMATION_TIERS := $(foreach sym,$(moz_automation_symbols),$(if $(filter 1,
# Dependencies between automation build steps
automation-start/uploadsymbols: automation/buildsymbols

automation-start/l10n-check: automation/package

automation-start/upload: automation/package
automation-start/upload: automation/package-tests
automation-start/upload: automation/buildsymbols
Expand All @@ -87,9 +83,6 @@ automation-start/check: $(addprefix automation/,$(filter-out check,$(MOZ_AUTOMAT
automation/build: $(addprefix automation/,$(MOZ_AUTOMATION_TIERS))
@echo Automation steps completed.

# Note: We have to force -j1 here, at least until bug 1036563 is fixed.
AUTOMATION_EXTRA_CMDLINE-l10n-check = -j1

# Run as many tests as possible, even in case of one of them failing.
AUTOMATION_EXTRA_CMDLINE-check = --keep-going

Expand Down
1 change: 0 additions & 1 deletion build/mozconfig.artifact.automation
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@
# This gets included before mozconfig.automation.

MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0
MOZ_AUTOMATION_PACKAGE_GENERATED_SOURCES=0
MOZ_AUTOMATION_ARTIFACT_BUILDS=1
1 change: 0 additions & 1 deletion build/mozconfig.automation
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
# overridden by setting them earlier in the appropriate mozconfig.

mk_add_options "export MOZ_AUTOMATION_BUILD_SYMBOLS=${MOZ_AUTOMATION_BUILD_SYMBOLS-1}"
mk_add_options "export MOZ_AUTOMATION_L10N_CHECK=${MOZ_AUTOMATION_L10N_CHECK-0}"
mk_add_options "export MOZ_AUTOMATION_PACKAGE=${MOZ_AUTOMATION_PACKAGE-1}"
mk_add_options "export MOZ_AUTOMATION_PACKAGE_GENERATED_SOURCES=${MOZ_AUTOMATION_PACKAGE_GENERATED_SOURCES-1}"
mk_add_options "export MOZ_AUTOMATION_UPLOAD=${MOZ_AUTOMATION_UPLOAD-1}"
Expand Down
2 changes: 0 additions & 2 deletions build/unix/mozconfig.asan
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
MOZ_AUTOMATION_L10N_CHECK=0

. "$topsrcdir/build/unix/mozconfig.unix"

export LLVM_SYMBOLIZER="$MOZ_FETCHES_DIR/clang/bin/llvm-symbolizer"
Expand Down
2 changes: 0 additions & 2 deletions build/unix/mozconfig.tsan
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
MOZ_AUTOMATION_L10N_CHECK=0

. "$topsrcdir/build/unix/mozconfig.unix"

export LLVM_SYMBOLIZER="$MOZ_FETCHES_DIR/clang/bin/llvm-symbolizer"
Expand Down
1 change: 0 additions & 1 deletion js/src/devtools/rootAnalysis/mozconfig.haz
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ MOZ_HAZARD=1

# Skip as many non-compile steps as we can.
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0
MOZ_AUTOMATION_PACKAGE=0
MOZ_AUTOMATION_UPLOAD=0

Expand Down
1 change: 0 additions & 1 deletion mobile/android/config/mozconfigs/android-api-16-gradle-dependencies/nightly
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# Many things aren't appropriate for a frontend-only build.
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0
MOZ_AUTOMATION_PACKAGE=0
MOZ_AUTOMATION_UPLOAD=0
MOZ_AUTOMATION_PACKAGE_GENERATED_SOURCES=0
Expand Down
1 change: 0 additions & 1 deletion mobile/android/config/mozconfigs/android-api-16/nightly-android-lints
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# Many things aren't appropriate for a frontend-only build.
MOZ_AUTOMATION_BUILD_SYMBOLS=0
MOZ_AUTOMATION_L10N_CHECK=0
MOZ_AUTOMATION_PACKAGE=0
MOZ_AUTOMATION_UPLOAD=0
MOZ_AUTOMATION_PACKAGE_GENERATED_SOURCES=0
Expand Down
1 change: 0 additions & 1 deletion mobile/android/config/mozconfigs/common
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ if [ -z "$NO_NDK" -a -z "$USE_ARTIFACT" ]; then
. "$topsrcdir/build/mozconfig.stylo"
fi

MOZ_AUTOMATION_L10N_CHECK=0
. "$topsrcdir/build/mozconfig.common"

# For Android builds in TaskCluster, the system image is Debian, and
Expand Down

0 comments on commit 6a1005d

Please sign in to comment.