Bug 1656852 click on a link in Network Headers Panel r=Honza,bomsy

Differential Revision: https://phabricator.services.mozilla.com/D129426

devtools/client/netmonitor/src/components/request-details/HeadersPanel.js

@@ -73,6 +73,12 @@ loader.lazyRequireGetter(
   "devtools/client/shared/components/menu/utils",
   true
 );
+loader.lazyRequireGetter(
+  this,
+  "openContentLink",
+  "devtools/client/shared/link",
+  true
+);
 
 const { div, input, label, span, textarea, tr, td, button } = dom;
 
@@ -455,6 +461,7 @@ class HeadersPanel extends Component {
           member: Object.assign({}, member, { open: false }),
           mode: MODE.TINY,
           noGrip: true,
+          openLink: openContentLink,
         })
       ),
       headerDocURL ? MDNLink({ url: headerDocURL }) : null

devtools/client/netmonitor/test/browser.ini

@@ -182,6 +182,7 @@ skip-if = verify # Bug 1607678
 [browser_net_decode-params.js]
 [browser_net_headers-alignment.js]
 [browser_net_headers_filter.js]
+[browser_net_headers-link_clickable.js]
 [browser_net_headers_sorted.js]
 [browser_net_headers-resize.js]
 [browser_net_image-tooltip.js]

devtools/client/netmonitor/test/browser_net_headers-link_clickable.js

@@ -0,0 +1,44 @@
+/* Any copyright is dedicated to the Public Domain.
+   http://creativecommons.org/publicdomain/zero/1.0/ */
+
+"use strict";
+
+/**
+ * Test if links in headers panel are clickable.
+ */
+
+add_task(async function() {
+  const { tab, monitor } = await initNetMonitor(JSON_LONG_URL, {
+    requestCount: 1,
+  });
+  info("Starting test... ");
+
+  const { document, store, windowRequire } = monitor.panelWin;
+  const Actions = windowRequire("devtools/client/netmonitor/src/actions/index");
+
+  store.dispatch(Actions.batchEnable(false));
+
+  await performRequests(monitor, tab, 1);
+
+  info("Selecting first request");
+  EventUtils.sendMouseEvent(
+    { type: "mousedown" },
+    document.querySelectorAll(".request-list-item")[0]
+  );
+
+  info("Waiting for request and response headers");
+  await waitForRequestData(store, ["requestHeaders", "responseHeaders"]);
+
+  const headerLink = document.querySelector(".objectBox-string .url");
+  const expectedURL =
+    "http://example.com/browser/devtools/client/netmonitor/test/html_json-long-test-page.html";
+  const onTabOpen = BrowserTestUtils.waitForNewTab(gBrowser, expectedURL, true);
+
+  info("Click on a first link in Headers panel");
+  headerLink.click();
+  await onTabOpen;
+
+  ok(onTabOpen, "New tab opened from link");
+
+  return teardown(monitor);
+});