Bug 1736371 - Default new actors to be refcounted, r=alwu,media-playb…

…ack-reviewers,mccr8 The changes to ipdl actors were mechanical, and largely automated using a script. Differential Revision: https://phabricator.services.mozilla.com/D137237
iaxat · Feb 9, 2022 · 760a897 · 760a897
1 parent 1258eda
commit 760a897
Show file tree

Hide file tree

Showing 259 changed files with 267 additions and 236 deletions.
diff --git a/accessible/ipc/extension/android/PDocAccessiblePlatformExt.ipdl b/accessible/ipc/extension/android/PDocAccessiblePlatformExt.ipdl
@@ -9,6 +9,7 @@ include protocol PDocAccessible;
 namespace mozilla {
 namespace a11y {
 
+[ManualDealloc]
 protocol PDocAccessiblePlatformExt {
   manager PDocAccessible;
 

diff --git a/accessible/ipc/extension/mac/PDocAccessiblePlatformExt.ipdl b/accessible/ipc/extension/mac/PDocAccessiblePlatformExt.ipdl
@@ -23,7 +23,7 @@ struct TextAttributesRun {
 };
 
 
-[NestedUpTo=inside_sync] sync protocol PDocAccessiblePlatformExt {
+[ManualDealloc, NestedUpTo=inside_sync] sync protocol PDocAccessiblePlatformExt {
   manager PDocAccessible;
 
 child:

diff --git a/accessible/ipc/extension/other/PDocAccessiblePlatformExt.ipdl b/accessible/ipc/extension/other/PDocAccessiblePlatformExt.ipdl
@@ -9,6 +9,7 @@ include protocol PDocAccessible;
 namespace mozilla {
 namespace a11y {
 
+[ManualDealloc]
 protocol PDocAccessiblePlatformExt {
   manager PDocAccessible;
 

diff --git a/accessible/ipc/other/PDocAccessible.ipdl b/accessible/ipc/other/PDocAccessible.ipdl
@@ -79,7 +79,7 @@ struct TextRangeData
   int32_t EndOffset;
 };
 
-[NestedUpTo=inside_sync, ChildImpl=virtual, ParentImpl=virtual]
+[ManualDealloc, NestedUpTo=inside_sync, ChildImpl=virtual, ParentImpl=virtual]
 sync protocol PDocAccessible
 {
   manager PBrowser;

diff --git a/accessible/ipc/win/PDocAccessible.ipdl b/accessible/ipc/win/PDocAccessible.ipdl
@@ -43,7 +43,7 @@ struct ShowEventData
   bool EventSuppressed;
 };
 
-[ChildImpl=virtual, ParentImpl=virtual]
+[ManualDealloc, ChildImpl=virtual, ParentImpl=virtual]
 sync protocol PDocAccessible
 {
   manager PBrowser;

diff --git a/devtools/shared/heapsnapshot/PHeapSnapshotTempFileHelper.ipdl b/devtools/shared/heapsnapshot/PHeapSnapshotTempFileHelper.ipdl
@@ -22,6 +22,7 @@ union OpenHeapSnapshotTempFileResponse
     OpenedFile;
 };
 
+[ManualDealloc]
 sync protocol PHeapSnapshotTempFileHelper
 {
     manager PContent;

diff --git a/dom/broadcastchannel/PBroadcastChannel.ipdl b/dom/broadcastchannel/PBroadcastChannel.ipdl
@@ -16,7 +16,7 @@ namespace mozilla {
 namespace dom {
 
 // This protocol is used for the BroadcastChannel API
-[ChildImpl=virtual, ParentImpl=virtual]
+[ManualDealloc, ChildImpl=virtual, ParentImpl=virtual]
 protocol PBroadcastChannel
 {
   manager PBackground;

diff --git a/dom/cache/PCache.ipdl b/dom/cache/PCache.ipdl
@@ -15,6 +15,7 @@ namespace mozilla {
 namespace dom {
 namespace cache {
 
+[ManualDealloc]
 protocol PCache
 {
   manager PBackground;

diff --git a/dom/cache/PCacheOp.ipdl b/dom/cache/PCacheOp.ipdl
@@ -19,6 +19,7 @@ namespace mozilla {
 namespace dom {
 namespace cache {
 
+[ManualDealloc]
 protocol PCacheOp
 {
   manager PCache or PCacheStorage;

diff --git a/dom/cache/PCacheStorage.ipdl b/dom/cache/PCacheStorage.ipdl
@@ -16,6 +16,7 @@ namespace mozilla {
 namespace dom {
 namespace cache {
 
+[ManualDealloc]
 protocol PCacheStorage
 {
   manager PBackground;

diff --git a/dom/cache/PCacheStreamControl.ipdl b/dom/cache/PCacheStreamControl.ipdl
@@ -14,7 +14,7 @@ namespace mozilla {
 namespace dom {
 namespace cache {
 
-[RefCounted] protocol PCacheStreamControl
+protocol PCacheStreamControl
 {
   manager PBackground;
 

diff --git a/dom/canvas/PWebGL.ipdl b/dom/canvas/PWebGL.ipdl
@@ -35,7 +35,7 @@ namespace dom {
  * command from the content process, and a WebGLParent in the compositor
  * process that runs the commands.
  */
-[RefCounted] sync protocol PWebGL
+sync protocol PWebGL
 {
   manager PCanvasManager;
 

diff --git a/dom/clients/manager/PClientHandle.ipdl b/dom/clients/manager/PClientHandle.ipdl
@@ -15,7 +15,7 @@ include "mozilla/ipc/ProtocolMessageUtils.h";
 namespace mozilla {
 namespace dom {
 
-[ChildImpl=virtual, ParentImpl=virtual]
+[ManualDealloc, ChildImpl=virtual, ParentImpl=virtual]
 protocol PClientHandle
 {
   manager PClientManager;

diff --git a/dom/clients/manager/PClientHandleOp.ipdl b/dom/clients/manager/PClientHandleOp.ipdl
@@ -8,7 +8,7 @@ include ClientIPCTypes;
 namespace mozilla {
 namespace dom {
 
-[ChildImpl=virtual, ParentImpl=virtual]
+[ManualDealloc, ChildImpl=virtual, ParentImpl=virtual]
 protocol PClientHandleOp
 {
   manager PClientHandle;

diff --git a/dom/clients/manager/PClientManager.ipdl b/dom/clients/manager/PClientManager.ipdl
@@ -16,7 +16,7 @@ include ClientIPCTypes;
 namespace mozilla {
 namespace dom {
 
-[ChildImpl=virtual, ParentImpl=virtual]
+[ManualDealloc, ChildImpl=virtual, ParentImpl=virtual]
 sync protocol PClientManager
 {
   manager PBackground;

diff --git a/dom/clients/manager/PClientManagerOp.ipdl b/dom/clients/manager/PClientManagerOp.ipdl
@@ -8,7 +8,7 @@ include ClientIPCTypes;
 namespace mozilla {
 namespace dom {
 
-[ChildImpl=virtual, ParentImpl=virtual]
+[ManualDealloc, ChildImpl=virtual, ParentImpl=virtual]
 protocol PClientManagerOp
 {
   manager PClientManager;

diff --git a/dom/clients/manager/PClientNavigateOp.ipdl b/dom/clients/manager/PClientNavigateOp.ipdl
@@ -8,7 +8,7 @@ include ClientIPCTypes;
 namespace mozilla {
 namespace dom {
 
-[ChildImpl=virtual, ParentImpl=virtual]
+[ManualDealloc, ChildImpl=virtual, ParentImpl=virtual]
 protocol PClientNavigateOp
 {
   manager PClientManager;

diff --git a/dom/clients/manager/PClientSource.ipdl b/dom/clients/manager/PClientSource.ipdl
@@ -13,7 +13,7 @@ include ClientIPCTypes;
 namespace mozilla {
 namespace dom {
 
-[ChildImpl=virtual, ParentImpl=virtual]
+[ManualDealloc, ChildImpl=virtual, ParentImpl=virtual]
 sync protocol PClientSource
 {
   manager PClientManager;

diff --git a/dom/clients/manager/PClientSourceOp.ipdl b/dom/clients/manager/PClientSourceOp.ipdl
@@ -8,7 +8,7 @@ include ClientIPCTypes;
 namespace mozilla {
 namespace dom {
 
-[ChildImpl=virtual, ParentImpl=virtual]
+[ManualDealloc, ChildImpl=virtual, ParentImpl=virtual]
 protocol PClientSourceOp
 {
   manager PClientSource;

diff --git a/dom/file/ipc/PFileCreator.ipdl b/dom/file/ipc/PFileCreator.ipdl
@@ -29,6 +29,7 @@ union FileCreationResult
   FileCreationErrorResult;
 };
 
+[ManualDealloc]
 protocol PFileCreator
 {
   manager PBackground;

diff --git a/dom/file/ipc/PRemoteLazyInputStream.ipdl b/dom/file/ipc/PRemoteLazyInputStream.ipdl
@@ -13,7 +13,7 @@ include IPCStream;
 
 namespace mozilla {
 
-[RefCounted] protocol PRemoteLazyInputStream
+protocol PRemoteLazyInputStream
 {
   manager PBackground or PContent or PSocketProcess;
 

diff --git a/dom/file/ipc/PTemporaryIPCBlob.ipdl b/dom/file/ipc/PTemporaryIPCBlob.ipdl
@@ -19,6 +19,7 @@ union IPCBlobOrError
   nsresult;
 };
 
+[ManualDealloc]
 protocol PTemporaryIPCBlob
 {
   manager PBackground;

diff --git a/dom/filehandle/PBackgroundFileHandle.ipdl b/dom/filehandle/PBackgroundFileHandle.ipdl
@@ -69,7 +69,7 @@ union FileRequestParams
   FileRequestFlushParams;
 };
 
-[ChildImpl="indexedDB::BackgroundFileHandleChild", ParentImpl=virtual]
+[ManualDealloc, ChildImpl="indexedDB::BackgroundFileHandleChild", ParentImpl=virtual]
 protocol PBackgroundFileHandle
 {
   manager PBackgroundMutableFile;

diff --git a/dom/filehandle/PBackgroundFileRequest.ipdl b/dom/filehandle/PBackgroundFileRequest.ipdl
@@ -49,7 +49,7 @@ union FileRequestResponse
   FileRequestFlushResponse;
 };
 
-[ChildImpl="indexedDB::BackgroundFileRequestChild", ParentImpl=virtual]
+[ManualDealloc, ChildImpl="indexedDB::BackgroundFileRequestChild", ParentImpl=virtual]
 protocol PBackgroundFileRequest
 {
   manager PBackgroundFileHandle;

diff --git a/dom/filehandle/PBackgroundMutableFile.ipdl b/dom/filehandle/PBackgroundMutableFile.ipdl
@@ -15,7 +15,7 @@ using mozilla::dom::FileMode
 namespace mozilla {
 namespace dom {
 
-[ChildImpl="indexedDB::BackgroundMutableFileChild", ParentImpl="BackgroundMutableFileParentBase"]
+[ManualDealloc, ChildImpl="indexedDB::BackgroundMutableFileChild", ParentImpl="BackgroundMutableFileParentBase"]
 sync protocol PBackgroundMutableFile
 {
   manager PBackgroundIDBDatabase;

diff --git a/dom/filesystem/PFileSystemRequest.ipdl b/dom/filesystem/PFileSystemRequest.ipdl
@@ -68,7 +68,7 @@ union FileSystemResponseValue
   FileSystemErrorResponse;
 };
 
-[RefCounted, ChildImpl="FileSystemTaskChildBase"]
+[ChildImpl="FileSystemTaskChildBase"]
 protocol PFileSystemRequest
 {
   manager PBackground;

diff --git a/dom/gamepad/ipc/PGamepadEventChannel.ipdl b/dom/gamepad/ipc/PGamepadEventChannel.ipdl
@@ -10,7 +10,7 @@ using mozilla::dom::GamepadHandle from "mozilla/dom/GamepadHandle.h";
 namespace mozilla {
 namespace dom {
 
-[RefCounted] protocol PGamepadEventChannel {
+protocol PGamepadEventChannel {
   manager PBackground;
   parent:
     async __delete__();

diff --git a/dom/gamepad/ipc/PGamepadTestChannel.ipdl b/dom/gamepad/ipc/PGamepadTestChannel.ipdl
@@ -10,7 +10,7 @@ using mozilla::dom::GamepadHandle from "mozilla/dom/GamepadHandle.h";
 namespace mozilla {
 namespace dom {
 
-[RefCounted] protocol PGamepadTestChannel {
+protocol PGamepadTestChannel {
   manager PBackground;
   parent:
     async GamepadTestEvent(uint32_t aID, GamepadChangeEvent aGamepadEvent);

diff --git a/dom/indexedDB/PBackgroundIDBCursor.ipdl b/dom/indexedDB/PBackgroundIDBCursor.ipdl
@@ -84,7 +84,7 @@ union CursorResponse
   IndexKeyCursorResponse[];
 };
 
-[RefCounted, ChildImpl="indexedDB::BackgroundCursorChildBase", ParentImpl=virtual]
+[ChildImpl="indexedDB::BackgroundCursorChildBase", ParentImpl=virtual]
 protocol PBackgroundIDBCursor
 {
   manager PBackgroundIDBTransaction or PBackgroundIDBVersionChangeTransaction;

diff --git a/dom/indexedDB/PBackgroundIDBDatabase.ipdl b/dom/indexedDB/PBackgroundIDBDatabase.ipdl
@@ -40,7 +40,7 @@ union DatabaseRequestParams
   CreateFileParams;
 };
 
-[ChildImpl="indexedDB::BackgroundDatabaseChild", ParentImpl=virtual]
+[ManualDealloc, ChildImpl="indexedDB::BackgroundDatabaseChild", ParentImpl=virtual]
 sync protocol PBackgroundIDBDatabase
 {
   manager PBackgroundIDBFactory;

diff --git a/dom/indexedDB/PBackgroundIDBDatabaseFile.ipdl b/dom/indexedDB/PBackgroundIDBDatabaseFile.ipdl
@@ -8,7 +8,7 @@ namespace mozilla {
 namespace dom {
 namespace indexedDB {
 
-[ChildImpl=virtual, ParentImpl=virtual]
+[ManualDealloc, ChildImpl=virtual, ParentImpl=virtual]
 protocol PBackgroundIDBDatabaseFile
 {
   manager PBackgroundIDBDatabase;

diff --git a/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl b/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl
@@ -22,7 +22,7 @@ union DatabaseRequestResponse
   CreateFileRequestResponse;
 };
 
-[ChildImpl="indexedDB::BackgroundDatabaseRequestChild", ParentImpl=virtual]
+[ManualDealloc, ChildImpl="indexedDB::BackgroundDatabaseRequestChild", ParentImpl=virtual]
 protocol PBackgroundIDBDatabaseRequest
 {
   manager PBackgroundIDBDatabase;

diff --git a/dom/indexedDB/PBackgroundIDBFactory.ipdl b/dom/indexedDB/PBackgroundIDBFactory.ipdl
@@ -40,7 +40,7 @@ union FactoryRequestParams
   DeleteDatabaseRequestParams;
 };
 
-[RefCounted, ChildImpl="indexedDB::BackgroundFactoryChild", ParentImpl=virtual]
+[ChildImpl="indexedDB::BackgroundFactoryChild", ParentImpl=virtual]
 sync protocol PBackgroundIDBFactory
 {
   manager PBackground;

diff --git a/dom/indexedDB/PBackgroundIDBFactoryRequest.ipdl b/dom/indexedDB/PBackgroundIDBFactoryRequest.ipdl
@@ -30,7 +30,7 @@ union FactoryRequestResponse
   DeleteDatabaseRequestResponse;
 };
 
-[ChildImpl="indexedDB::BackgroundFactoryRequestChild", ParentImpl=virtual]
+[ManualDealloc, ChildImpl="indexedDB::BackgroundFactoryRequestChild", ParentImpl=virtual]
 protocol PBackgroundIDBFactoryRequest
 {
   manager PBackgroundIDBFactory;

diff --git a/dom/indexedDB/PBackgroundIDBRequest.ipdl b/dom/indexedDB/PBackgroundIDBRequest.ipdl
@@ -147,7 +147,7 @@ union PreprocessResponse
   ObjectStoreGetAllPreprocessResponse;
 };
 
-[ChildImpl="indexedDB::BackgroundRequestChild", ParentImpl=virtual]
+[ManualDealloc, ChildImpl="indexedDB::BackgroundRequestChild", ParentImpl=virtual]
 protocol PBackgroundIDBRequest
 {
   manager PBackgroundIDBTransaction or PBackgroundIDBVersionChangeTransaction;

diff --git a/dom/indexedDB/PBackgroundIDBTransaction.ipdl b/dom/indexedDB/PBackgroundIDBTransaction.ipdl
@@ -16,7 +16,7 @@ namespace mozilla {
 namespace dom {
 namespace indexedDB {
 
-[RefCounted, ChildImpl="indexedDB::BackgroundTransactionChild", ParentImpl=virtual]
+[ChildImpl="indexedDB::BackgroundTransactionChild", ParentImpl=virtual]
 protocol PBackgroundIDBTransaction {
   manager PBackgroundIDBDatabase;
 

diff --git a/dom/indexedDB/PBackgroundIDBVersionChangeTransaction.ipdl b/dom/indexedDB/PBackgroundIDBVersionChangeTransaction.ipdl
@@ -20,7 +20,7 @@ namespace mozilla {
 namespace dom {
 namespace indexedDB {
 
-[RefCounted, ChildImpl="indexedDB::BackgroundVersionChangeTransactionChild", ParentImpl=virtual]
+[ChildImpl="indexedDB::BackgroundVersionChangeTransactionChild", ParentImpl=virtual]
 protocol PBackgroundIDBVersionChangeTransaction {
   manager PBackgroundIDBDatabase;
 

diff --git a/dom/indexedDB/PBackgroundIndexedDBUtils.ipdl b/dom/indexedDB/PBackgroundIndexedDBUtils.ipdl
@@ -14,7 +14,7 @@ namespace mozilla {
 namespace dom {
 namespace indexedDB {
 
-[ChildImpl="indexedDB::BackgroundUtilsChild", ParentImpl=virtual]
+[ManualDealloc, ChildImpl="indexedDB::BackgroundUtilsChild", ParentImpl=virtual]
 sync protocol PBackgroundIndexedDBUtils
 {
   manager PBackground;

diff --git a/dom/ipc/PBrowser.ipdl b/dom/ipc/PBrowser.ipdl
@@ -178,7 +178,7 @@ struct PrintPreviewResultInfo
  * See `dom/docs/Fission-IPC-Diagram.svg` for an overview of the DOM IPC
  * actors.
  */
-[NestedUpTo=inside_cpow, RefCounted] sync protocol PBrowser
+[NestedUpTo=inside_cpow] sync protocol PBrowser
 {
     manager PContent;
 

diff --git a/dom/ipc/PBrowserBridge.ipdl b/dom/ipc/PBrowserBridge.ipdl
@@ -41,7 +41,7 @@ namespace dom {
  * See `dom/docs/Fission-IPC-Diagram.svg` for an overview of the DOM IPC
  * actors.
  */
-[RefCounted] async protocol PBrowserBridge {
+async protocol PBrowserBridge {
   manager PBrowser;
 
 child:

diff --git a/dom/ipc/PColorPicker.ipdl b/dom/ipc/PColorPicker.ipdl
@@ -10,7 +10,7 @@ include protocol PBrowser;
 namespace mozilla {
 namespace dom {
 
-[ChildImpl=virtual, ParentImpl=virtual]
+[ManualDealloc, ChildImpl=virtual, ParentImpl=virtual]
 protocol PColorPicker
 {
     manager PBrowser;

diff --git a/dom/ipc/PContent.ipdl b/dom/ipc/PContent.ipdl
@@ -430,7 +430,7 @@ union BlobURLDataRequestResult
  * and a content process. There is exactly one PContentParent/PContentChild pair
  * for each content process.
  */
-[NestedUpTo=inside_cpow, NeedsOtherPid]
+[ManualDealloc, NestedUpTo=inside_cpow, NeedsOtherPid]
 sync protocol PContent
 {
     manages PBrowser;

diff --git a/dom/ipc/PContentPermissionRequest.ipdl b/dom/ipc/PContentPermissionRequest.ipdl
@@ -10,7 +10,7 @@ include "nsContentPermissionHelper.h";
 namespace mozilla {
 namespace dom {
 
-[ChildImpl="RemotePermissionRequest", ParentImpl=virtual]
+[ManualDealloc, ChildImpl="RemotePermissionRequest", ParentImpl=virtual]
 protocol PContentPermissionRequest
 {
   manager PContent;

diff --git a/dom/ipc/PCycleCollectWithLogs.ipdl b/dom/ipc/PCycleCollectWithLogs.ipdl
@@ -8,7 +8,7 @@ include protocol PContent;
 namespace mozilla {
 namespace dom {
 
-[ChildImpl=virtual, ParentImpl=virtual]
+[ManualDealloc, ChildImpl=virtual, ParentImpl=virtual]
 protocol PCycleCollectWithLogs {
     manager PContent;
 

diff --git a/dom/ipc/PFilePicker.ipdl b/dom/ipc/PFilePicker.ipdl
@@ -34,7 +34,7 @@ union MaybeInputData
   void_t;
 };
 
-[ChildImpl=virtual]
+[ManualDealloc, ChildImpl=virtual]
 protocol PFilePicker
 {
   manager PBrowser;
-Original file line number
+Diff line change
@@ Expand Up / @@ -23,7 +23,7 @@ struct TextAttributesRun { @@
     };
-    [NestedUpTo=inside_sync] sync protocol PDocAccessiblePlatformExt {
+    [ManualDealloc, NestedUpTo=inside_sync] sync protocol PDocAccessiblePlatformExt {
       manager PDocAccessible;
     child:
@@ Expand Down @@