Bug 1556854 - Enable ESLint for dom/media/test/ - Enable ESLint rules…

… no-undef and no-unused-vars. r=jya

Differential Revision: https://phabricator.services.mozilla.com/D50132

.eslintrc.js

@@ -396,9 +396,7 @@ module.exports = {
       "no-nested-ternary": "off",
       "no-self-assign": "off",
       "no-new-object": "off",
-      "no-undef": "off",
       "no-unsanitized/property": "off",
-      "no-unused-vars": "off",
     }
   }]
 };

dom/media/test/AutoplayTestUtils.js

@@ -1,3 +1,5 @@
+/* import-globals-from manifest.js */
+
 function playAndPostResult(muted, parent_window) {
   let element = document.createElement("video");
   element.preload = "auto";

dom/media/test/background_video.js

@@ -1,8 +1,10 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-/* jshint esversion: 6, -W097 */
-/* globals SimpleTest, SpecialPowers, document, info, is, manager, ok */
+
+// This file expects manager to be defined in the global scope.
+/* global manager */
+/* import-globals-from manifest.js */
 
 "use strict";
 

dom/media/test/can_play_type_webm.js

@@ -31,14 +31,6 @@ async function check_webm(v, enabled) {
   check("video/webm; codecs=xyz,vorbis", "");
   check("video/webm; codecs=vorbis,xyz", "");
 
-  function getPref(name) {
-    var pref = false;
-    try {
-      pref = SpecialPowers.getBoolPref(name);
-    } catch (ex) {}
-    return pref;
-  }
-
   await SpecialPowers.pushPrefEnv({ set: [["media.av1.enabled", true]] });
   check('video/webm; codecs="av1"', "probably");
 

dom/media/test/chromeHelper.js

@@ -4,6 +4,8 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
+/* eslint-env mozilla/frame-script */
+
 "use strict";
 
 const dirSvc = Cc["@mozilla.org/file/directory_service;1"].getService(

dom/media/test/eme.js

@@ -1,3 +1,5 @@
+/* import-globals-from manifest.js */
+
 const CLEARKEY_KEYSYSTEM = "org.w3.clearkey";
 
 const gCencMediaKeySystemConfig = [
@@ -173,15 +175,13 @@ function AppendTrack(test, ms, track, token) {
   return new Promise(function(resolve, reject) {
     var sb;
     var curFragment = 0;
-    var resolved = false;
     var fragments = track.fragments;
     var fragmentFile;
 
     function addNextFragment() {
       if (curFragment >= fragments.length) {
         Log(token, track.name + ": end of track");
         resolve();
-        resolved = true;
         return;
       }
 

dom/media/test/gUM_support.js

@@ -85,7 +85,7 @@ async function pushGetUserMediaTestPrefs({
 // names already set in the prefs. If no loopback device name can be found then
 // prefs are setup such that a fake device is used.
 async function setupGetUserMediaTestPrefs() {
-  prefRequests = {};
+  let prefRequests = {};
   let audioLoopDev = SpecialPowers.getCharPref("media.audio_loopback_dev", "");
   if (audioLoopDev) {
     prefRequests.fakeAudio = false;

dom/media/test/manifest.js

@@ -2194,12 +2194,12 @@ function MediaTestManager() {
 // stacks.
 function mediaTestCleanup(callback) {
   var V = document.getElementsByTagName("video");
-  for (i = 0; i < V.length; i++) {
+  for (let i = 0; i < V.length; i++) {
     removeNodeAndSource(V[i]);
     V[i] = null;
   }
   var A = document.getElementsByTagName("audio");
-  for (i = 0; i < A.length; i++) {
+  for (let i = 0; i < A.length; i++) {
     removeNodeAndSource(A[i]);
     A[i] = null;
   }

dom/media/test/marionette/yttest/debug_info.js

@@ -1,3 +1,5 @@
+/* global video, result, resolve */
+
 video.mozRequestDebugInfo().then(debugInfo => {
   // The parsing won't be necessary once we have bug 1542674
   try {

dom/media/test/marionette/yttest/video_playback_quality.js

@@ -1 +1,2 @@
+/* global video */
 var result = { getVideoPlaybackQuality: video.getVideoPlaybackQuality() };

dom/media/test/seek_support.js

@@ -1,3 +1,7 @@
+// This file expects manifest.js to be included in the same scope.
+/* import-globals-from manifest.js */
+// This file expects SEEK_TEST_NUMBER to be defined by the test.
+/* global SEEK_TEST_NUMBER */
 var manager = new MediaTestManager();
 
 function createTestArray() {

dom/media/test/test_autoplay_policy_activation.html

@@ -136,7 +136,7 @@
         let child_url = "file_autoplay_policy_activation_window.html";
 
         async function runTest() {
-          for (test_case of test_cases) {
+          for (const test_case of test_cases) {
             // Run each test in a new window, to ensure its user gesture
             // activation state isn't tainted by preceeding tests.
             let child = window.open(child_url, "", "width=500,height=500");

dom/media/test/test_autoplay_policy_eventdown_activation.html

@@ -31,15 +31,15 @@
             let child = window.open(child_url, "", "width=500,height=500");
             await once(child, "load");
             child.postMessage("run keydown test", window.origin);
-            let result = await nextWindowMessage();
+            await nextWindowMessage();
             child.close();
           }
 
           {
             let child = window.open(child_url, "", "width=500,height=500");
             await once(child, "load");
             child.postMessage("run mousedown test", window.origin);
-            let result = await nextWindowMessage();
+            await nextWindowMessage();
             child.close();
           }
 

dom/media/test/test_autoplay_policy_key_blacklist.html

@@ -33,7 +33,7 @@
           let child = window.open(child_url, "", "width=500,height=500");
           await once(child, "load");
           child.postMessage("run test", window.origin);
-          let result = await nextWindowMessage();
+          await nextWindowMessage();
           child.close();
           SimpleTest.finish();
         }

dom/media/test/test_autoplay_policy_play_before_loadedmetadata.html

@@ -52,13 +52,13 @@
         let child_url = "file_autoplay_policy_play_before_loadedmetadata.html";
 
         async function runTest() {
-          for (testCase of testCases) {
+          for (const testCase of testCases) {
             // Run each test in a new window, to ensure its user gesture
             // activation state isn't tainted by preceeding tests.
             let child = window.open(child_url, "", "width=500,height=500");
             await once(child, "load");
             child.postMessage(testCase, window.origin);
-            let result = await nextWindowMessage();
+            await nextWindowMessage();
             child.close();
           }
           SimpleTest.finish();

dom/media/test/test_autoplay_policy_unmute_pauses.html

@@ -43,13 +43,13 @@
         let child_url = "file_autoplay_policy_unmute_pauses.html";
 
         async function runTest() {
-          for (testCase of testCases) {
+          for (const testCase of testCases) {
             // Run each test in a new window, to ensure its user gesture
             // activation state isn't tainted by preceeding tests.
             let child = window.open(child_url, "", "width=500,height=500");
             await once(child, "load");
             child.postMessage(testCase, window.origin);
-            let result = await nextWindowMessage();
+            await nextWindowMessage();
             child.close();
           }
           SimpleTest.finish();

dom/media/test/test_autoplay_policy_web_audio_AudioParamStream.html

@@ -51,6 +51,7 @@
 }
 
 function createAudioContext() {
+  /* global ac */
   window.ac = new AudioContext();
 
   ac.allowedToStart = new Promise(resolve => {
@@ -101,7 +102,7 @@
       return [ac.createStereoPanner().pan];
     default:
       ok(false, `non-defined node type ${nodeType}.`);
-      
+
   }
 }
 

dom/media/test/test_autoplay_policy_web_audio_createMediaStreamSource.html

@@ -46,6 +46,7 @@
 }
 
 function createAudioContexts() {
+  /* global ac1, ac2 */
   window.ac1 = new AudioContext();
   window.ac2 = new AudioContext();
 

dom/media/test/test_autoplay_policy_web_audio_mediaElementAudioSourceNode.html

@@ -49,6 +49,7 @@
 }
 
 function createAudioContext() {
+  /* global ac */
   window.ac = new AudioContext();
 
   ac.allowedToStart = new Promise(resolve => {

dom/media/test/test_autoplay_policy_web_audio_notResumePageInvokedSuspendedAudioContext.html

@@ -49,6 +49,7 @@
 }
 
 async function createAudioContext() {
+  /* global ac */
   window.ac = new AudioContext();
   await once(ac, "blocked");
   is(ac.state, "suspended", `AudioContext is blocked.`);

dom/media/test/test_background_video_drawimage_with_suspended_video.html

@@ -17,9 +17,7 @@
 
 function drawVideoToCanvas(v) {
   console.log('drawVideoToCanvas');
-  let w = v.width,
-      h = v.height,
-      c = document.createElement('canvas');
+  let c = document.createElement('canvas');
   c.width = 4;
   c.height = 4;
   c.style.width = 64;
@@ -75,4 +73,4 @@
       });
   }
 });
-</script>
+</script>

dom/media/test/test_background_video_tainted_by_capturestream.html

@@ -11,7 +11,7 @@
 var manager = new MediaTestManager;
 
 function captureVideoAsStream(v) {
-  let stream = v.mozCaptureStream();
+  v.mozCaptureStream();
 }
 
 startTest({
@@ -43,4 +43,4 @@
       });
   }
 });
-</script>
+</script>

dom/media/test/test_bug1248229.html

@@ -13,6 +13,7 @@
 SimpleTest.waitForExplicitFinish();
 
 function doTest() {
+  /* global v */
   window.oak = v.mozCaptureStreamUntilEnded();
   v.mozCaptureStreamUntilEnded();
   v.play();

dom/media/test/test_bug1431810_opus_downmix_to_mono.html

@@ -16,6 +16,8 @@
 */
 SimpleTest.waitForExplicitFinish();
 
+/* global a, b */
+
 function areChannelsInverted(b1, b2) {
   for (var i = 0; i < b1.length; i++) {
     if (Math.abs(b1[i] + b2[i]) > 9e-2) {

dom/media/test/test_bug1512958.html

@@ -42,7 +42,7 @@
     a.src = test.name;
     a.name = test.name;
     const ac = new AudioContext();
-    const src = ac.createMediaElementSource(a);
+    ac.createMediaElementSource(a);
     a.play();
     do {
       await new Promise(r => a.ontimeupdate = r);

dom/media/test/test_bug463162.xhtml

@@ -6,8 +6,8 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=463162
 -->
 <head>
   <title>Test for Bug 463162</title>
-  <script src="/tests/SimpleTest/SimpleTest.js"></script>        
-  <script src="/tests/SimpleTest/EventUtils.js"/>
+  <script src="/tests/SimpleTest/SimpleTest.js"></script>
+  <script src="/tests/SimpleTest/EventUtils.js"></script>
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css" />
   <script type="text/javascript" src="manifest.js"></script>
 </head>

dom/media/test/test_bug895305.html

@@ -22,6 +22,7 @@
 var audio = document.createElement("audio");
 
 // Check leaking on TextTrackList objects.
+/* global ttl, ttc */
 window.ttl = audio.textTracks;
 ttl.addEventListener("click", function(){});
 

dom/media/test/test_cloneElementVisually_ended_video.html

@@ -21,6 +21,8 @@ <h1>Results</h1>
 
 <script type="application/javascript">
 
+/* import-globals-from cloneElementVisually_helpers.js */
+
 /**
  * Test that when we start cloning a video that has already ended, the
  * clone displays the last frame from the video.

dom/media/test/test_cloneElementVisually_mediastream.html

@@ -23,6 +23,8 @@ <h1>Results</h1>
 
 <script type="application/javascript">
 
+/* import-globals-from cloneElementVisually_helpers.js */
+
 /**
  * Test that we can clone a video that is playing a MediaStream.
  */

dom/media/test/test_cloneElementVisually_no_suspend.html

@@ -23,6 +23,8 @@ <h1>Results</h1>
 
 <script type="application/javascript">
 
+/* import-globals-from cloneElementVisually_helpers.js */
+
 /**
  * Tests that cloning a video prevents the decoder from being suspended
  * if the original video stops being visible.

dom/media/test/test_cloneElementVisually_paused.html

@@ -21,6 +21,8 @@ <h1>Results</h1>
 
 <script type="application/javascript">
 
+/* import-globals-from cloneElementVisually_helpers.js */
+
 /**
  * Test that when we start cloning a paused video, the clone displays
  * the first paused frame.

dom/media/test/test_cloneElementVisually_poster.html

@@ -21,6 +21,8 @@ <h1>Results</h1>
 
 <script type="application/javascript">
 
+/* import-globals-from cloneElementVisually_helpers.js */
+
 /**
  * Test that when we start cloning a paused video, the clone displays
  * the first paused frame.

dom/media/test/test_cloneElementVisually_resource_change.html

@@ -23,6 +23,8 @@ <h1>Results</h1>
 
 <script type="application/javascript">
 
+/* import-globals-from cloneElementVisually_helpers.js */
+
 /**
  * Tests that cloning survives changes to the underlying video resource.
  */

dom/media/test/test_cueless_webm_seek-3.html

@@ -32,7 +32,6 @@
   var v = e.target;
   v.removeEventListener('loadeddata', testWebM3);
 
-  var startPassed = false;
   var completed = false;
   var gotTimeupdate = false;
 
@@ -58,7 +57,6 @@
       return;
 
     v.addEventListener("timeupdate", timeupdate);
-    startPassed = true;
   }
 
   function seekEnded() {

dom/media/test/test_eme_autoplay.html

@@ -10,6 +10,7 @@
 <body>
 <pre id="test">
 <script class="testbody" type="text/javascript">
+/* import-globals-from eme.js */
 var manager = new MediaTestManager;
 
 var EMEmanifest = [

dom/media/test/test_eme_detach_reattach_same_mediakeys_during_playback.html

@@ -11,6 +11,7 @@
 <pre id="test">
 <video id="v" controls></video>
 <script class="testbody" type="text/javascript">
+/* import-globals-from eme.js */
 var manager = new MediaTestManager;
 
 var EMEmanifest = [