Bug 1374735 - use DevToolsShim to create TabTarget in ext-devtools;r=…

…mixedpuppy

Removing dependencies from mozilla-central to devtools. Use DevTools shim instead
of directly depending on devtools code here.

MozReview-Commit-ID: CeV5tfw1Vnz

browser/components/extensions/ext-devtools.js

@@ -53,9 +53,8 @@ global.getDevToolsTargetForContext = async (context) => {
     throw new Error("Unexpected target type: only local tabs are currently supported.");
   }
 
-  const {TabTarget} = require("devtools/client/framework/target");
-
-  context.devToolsTarget = new TabTarget(context.devToolsToolbox.target.tab);
+  const tab = context.devToolsToolbox.target.tab;
+  context.devToolsTarget = DevToolsShim.getTargetForTab(tab);
   await context.devToolsTarget.makeRemote();
 
   return context.devToolsTarget;

devtools/shim/DevToolsShim.jsm

@@ -286,7 +286,6 @@ let addonSdkMethods = [
   "closeToolbox",
   "connectDebuggerServer",
   "createDebuggerClient",
-  "getTargetForTab",
   "getToolbox",
   "initBrowserToolboxProcessForAddon",
   "showToolbox",
@@ -299,6 +298,7 @@ let addonSdkMethods = [
  * therefore DevTools should always be available when they are called.
  */
 let webExtensionsMethods = [
+  "getTargetForTab",
   "getTheme",
 ];