Bug 1679522 - Fix include directives and forward declarations. r=andi…

…,necko-reviewers,jgilbert - Add missing include directives and forward declarations. - Remove some extra include directives. - Add missing namespace qualifications. - Move include directives out of namespace in toolkit/xre/GlobalSemaphore.h Differential Revision: https://phabricator.services.mozilla.com/D98894
iaxat · Mar 25, 2021 · 82d9aa2 · 82d9aa2
1 parent 8753073
commit 82d9aa2
Show file tree

Hide file tree

Showing 93 changed files with 238 additions and 37 deletions.
diff --git a/dom/base/MessageManagerCallback.h b/dom/base/MessageManagerCallback.h
@@ -7,12 +7,19 @@
 #ifndef dom_base_MessageManagerCallback_h__
 #define dom_base_MessageManagerCallback_h__
 
+#include "nsError.h"
 #include "nsStringFwd.h"
 #include "nsTArrayForwardDeclare.h"
 
 namespace mozilla {
+
+class ErrorResult;
+
 namespace dom {
 
+class ClonedMessageData;
+class ContentChild;
+class ContentParent;
 class ProcessMessageManager;
 
 namespace ipc {

diff --git a/dom/base/Pose.h b/dom/base/Pose.h
@@ -7,6 +7,8 @@
 #ifndef mozilla_dom_Pose_h
 #define mozilla_dom_Pose_h
 
+#include "js/RootingAPI.h"
+#include "nsCOMPtr.h"
 #include "nsWrapperCache.h"
 
 namespace mozilla {

diff --git a/dom/base/TextInputProcessor.h b/dom/base/TextInputProcessor.h
@@ -8,6 +8,7 @@
 #define mozilla_dom_textinputprocessor_h_
 
 #include "mozilla/Attributes.h"
+#include "mozilla/BasicEvents.h"
 #include "mozilla/EventForwards.h"
 #include "mozilla/Maybe.h"
 #include "mozilla/TextEventDispatcher.h"

diff --git a/dom/base/nsGlobalWindowOuter.h b/dom/base/nsGlobalWindowOuter.h
@@ -50,6 +50,7 @@
 #include "mozilla/dom/ImageBitmapSource.h"
 #include "mozilla/UniquePtr.h"
 #include "mozilla/dom/BrowsingContext.h"
+#include "X11UndefineNone.h"
 
 class nsDocShell;
 class nsIArray;

diff --git a/dom/canvas/WebGLTexelConversions.h b/dom/canvas/WebGLTexelConversions.h
@@ -39,6 +39,10 @@
 
 namespace mozilla {
 
+namespace gl {
+enum class OriginPos : uint8_t;
+}
+
 bool ConvertImage(size_t width, size_t height, const void* srcBegin,
                   size_t srcStride, gl::OriginPos srcOrigin,
                   WebGLTexelFormat srcFormat, bool srcPremultiplied,

diff --git a/dom/events/DataTransferItem.h b/dom/events/DataTransferItem.h
@@ -16,6 +16,7 @@ class ErrorResult;
 
 namespace dom {
 
+class DataTransfer;
 class FileSystemEntry;
 class FunctionStringCallback;
 

diff --git a/dom/events/DataTransferItemList.h b/dom/events/DataTransferItemList.h
@@ -11,9 +11,12 @@
 #include "mozilla/dom/DataTransferItem.h"
 #include "mozilla/dom/FileList.h"
 
+class nsIVariant;
+
 namespace mozilla {
 namespace dom {
 
+class DataTransfer;
 class DataTransferItem;
 
 class DataTransferItemList final : public nsISupports, public nsWrapperCache {

diff --git a/dom/events/PendingFullscreenEvent.h b/dom/events/PendingFullscreenEvent.h
@@ -7,6 +7,7 @@
 #ifndef mozilla_PendingFullscreenEvent_h_
 #define mozilla_PendingFullscreenEvent_h_
 
+#include "mozilla/dom/Document.h"
 #include "nsContentUtils.h"
 
 namespace mozilla {

diff --git a/dom/file/MutableBlobStorage.h b/dom/file/MutableBlobStorage.h
@@ -10,6 +10,7 @@
 #include "mozilla/RefPtr.h"
 #include "mozilla/Mutex.h"
 #include "nsCOMPtr.h"
+#include "nsString.h"
 #include "prio.h"
 
 class nsIEventTarget;

diff --git a/dom/gamepad/Gamepad.h b/dom/gamepad/Gamepad.h
@@ -25,6 +25,8 @@
 namespace mozilla {
 namespace dom {
 
+class GamepadHapticActuator;
+
 // Per spec:
 // https://dvcs.w3.org/hg/gamepad/raw-file/default/gamepad.html#remapping
 const int kStandardGamepadButtons = 17;

diff --git a/dom/gamepad/GamepadPose.h b/dom/gamepad/GamepadPose.h
@@ -10,6 +10,7 @@
 #include "mozilla/TypedEnumBits.h"
 #include "mozilla/dom/Pose.h"
 #include "mozilla/dom/GamepadPoseState.h"
+#include "nsCOMPtr.h"
 
 namespace mozilla {
 namespace dom {

diff --git a/dom/l10n/L10nMutations.h b/dom/l10n/L10nMutations.h
@@ -7,6 +7,8 @@
 #ifndef mozilla_dom_l10n_L10nMutations_h
 #define mozilla_dom_l10n_L10nMutations_h
 
+#include "nsCycleCollectionParticipant.h"
+#include "nsHashKeys.h"
 #include "nsRefreshObservers.h"
 #include "nsStubMutationObserver.h"
 #include "nsTHashSet.h"

diff --git a/dom/media/AudioChannelFormat.h b/dom/media/AudioChannelFormat.h
@@ -11,6 +11,7 @@
 #include "mozilla/PodOperations.h"
 #include "nsTArrayForwardDeclare.h"
 #include "AudioSampleFormat.h"
+#include "mozilla/PodOperations.h"
 #include "nsTArray.h"
 
 namespace mozilla {

diff --git a/dom/media/platforms/SimpleMap.h b/dom/media/platforms/SimpleMap.h
@@ -5,6 +5,7 @@
 #ifndef mozilla_SimpleMap_h
 #define mozilla_SimpleMap_h
 
+#include "mozilla/Mutex.h"
 #include "nsTArray.h"
 
 #include <utility>

diff --git a/dom/media/systemservices/video_engine/desktop_capture_impl.h b/dom/media/systemservices/video_engine/desktop_capture_impl.h
@@ -20,6 +20,7 @@
 
 #include "api/video/video_frame.h"
 #include "common_video/libyuv/include/webrtc_libyuv.h"
+#include "modules/video_capture/video_capture.h"
 #include "modules/video_capture/video_capture_config.h"
 #include "modules/desktop_capture/shared_memory.h"
 #include "modules/desktop_capture/desktop_device_info.h"

diff --git a/dom/media/webm/NesteggPacketHolder.h b/dom/media/webm/NesteggPacketHolder.h
@@ -6,6 +6,7 @@
 #if !defined(NesteggPacketHolder_h_)
 #  define NesteggPacketHolder_h_
 
+#  include <deque>
 #  include <stdint.h>
 #  include "nsAutoRef.h"
 #  include "nestegg/nestegg.h"

diff --git a/dom/media/webrtc/SineWaveGenerator.h b/dom/media/webrtc/SineWaveGenerator.h
@@ -6,6 +6,7 @@
 #define SINEWAVEGENERATOR_H_
 
 #include "MediaSegment.h"
+#include "prtime.h"
 
 namespace mozilla {
 

diff --git a/dom/media/webrtc/libwebrtcglue/GmpVideoCodec.h b/dom/media/webrtc/libwebrtcglue/GmpVideoCodec.h
@@ -5,9 +5,11 @@
 #ifndef GMPVIDEOCODEC_H_
 #define GMPVIDEOCODEC_H_
 
-#include "MediaConduitInterface.h"
-
 namespace mozilla {
+
+class WebrtcVideoDecoder;
+class WebrtcVideoEncoder;
+
 class GmpVideoCodec {
  public:
   static WebrtcVideoEncoder* CreateEncoder();

diff --git a/dom/payments/PaymentRequestUtils.h b/dom/payments/PaymentRequestUtils.h
@@ -7,6 +7,7 @@
 #ifndef mozilla_dom_PaymentRequestUtils_h
 #define mozilla_dom_PaymentRequestUtils_h
 
+#include "js/TypeDecls.h"
 #include "nsTArray.h"
 
 namespace mozilla {

diff --git a/dom/security/nsHTTPSOnlyStreamListener.h b/dom/security/nsHTTPSOnlyStreamListener.h
@@ -11,6 +11,8 @@
 #include "nsCOMPtr.h"
 #include "nsIStreamListener.h"
 
+class nsILoadInfo;
+
 /**
  * This event listener gets registered for requests that have been upgraded
  * using the HTTPS-only mode to log failed upgrades to the console.

diff --git a/dom/webauthn/WebAuthnManager.h b/dom/webauthn/WebAuthnManager.h
@@ -9,6 +9,7 @@
 
 #include "mozilla/Maybe.h"
 #include "mozilla/MozPromise.h"
+#include "mozilla/dom/AbortSignal.h"
 #include "mozilla/dom/PWebAuthnTransaction.h"
 #include "mozilla/dom/WebAuthnManagerBase.h"
 

diff --git a/dom/webgpu/Buffer.h b/dom/webgpu/Buffer.h
@@ -10,9 +10,17 @@
 #include "mozilla/dom/Nullable.h"
 #include "mozilla/ipc/Shmem.h"
 #include "mozilla/webgpu/WebGPUTypes.h"
+#include "nsTArray.h"
 #include "ObjectModel.h"
 
 namespace mozilla {
+class ErrorResult;
+
+namespace dom {
+template <typename T>
+class Optional;
+}
+
 namespace ipc {
 class Shmem;
 }  // namespace ipc

diff --git a/dom/webgpu/CommandBuffer.h b/dom/webgpu/CommandBuffer.h
@@ -7,6 +7,7 @@
 #define GPU_CommandBuffer_H_
 
 #include "mozilla/WeakPtr.h"
+#include "mozilla/webgpu/WebGPUTypes.h"
 #include "nsWrapperCache.h"
 #include "ObjectModel.h"
 

diff --git a/dom/webgpu/CommandEncoder.h b/dom/webgpu/CommandEncoder.h
@@ -13,6 +13,8 @@
 #include "ObjectModel.h"
 
 namespace mozilla {
+class ErrorResult;
+
 namespace dom {
 struct GPUComputePassDescriptor;
 struct GPUTextureDataLayout;

diff --git a/dom/webgpu/ComputePassEncoder.h b/dom/webgpu/ComputePassEncoder.h
@@ -11,6 +11,12 @@
 #include "ObjectModel.h"
 
 namespace mozilla {
+class ErrorResult;
+
+namespace dom {
+struct GPUComputePassDescriptor;
+}
+
 namespace webgpu {
 namespace ffi {
 struct WGPUComputePass;

diff --git a/dom/webgpu/Device.h b/dom/webgpu/Device.h
@@ -6,6 +6,7 @@
 #ifndef GPU_DEVICE_H_
 #define GPU_DEVICE_H_
 
+#include "ObjectModel.h"
 #include "mozilla/MozPromise.h"
 #include "mozilla/RefPtr.h"
 #include "mozilla/webgpu/WebGPUTypes.h"

diff --git a/dom/webgpu/Queue.h b/dom/webgpu/Queue.h
@@ -9,6 +9,7 @@
 #include "nsWrapperCache.h"
 #include "ObjectModel.h"
 #include "mozilla/dom/TypedArray.h"
+#include "mozilla/webgpu/WebGPUTypes.h"
 
 namespace mozilla {
 class ErrorResult;
@@ -19,6 +20,8 @@ template <typename T>
 class Optional;
 template <typename T>
 class Sequence;
+struct GPUTextureCopyView;
+struct GPUTextureDataLayout;
 struct TextureCopyView;
 struct TextureDataLayout;
 typedef RangeEnforcedUnsignedLongSequenceOrGPUExtent3DDict GPUExtent3D;

diff --git a/dom/webgpu/RenderPassEncoder.h b/dom/webgpu/RenderPassEncoder.h
@@ -11,8 +11,11 @@
 #include "ObjectModel.h"
 
 namespace mozilla {
+class ErrorResult;
+
 namespace dom {
 class DoubleSequenceOrGPUColorDict;
+struct GPURenderPassDescriptor;
 template <typename T>
 class Sequence;
 namespace binding_detail {
@@ -25,9 +28,12 @@ namespace ffi {
 struct WGPURenderPass;
 }  // namespace ffi
 
+class BindGroup;
+class Buffer;
 class CommandEncoder;
 class RenderBundle;
 class RenderPipeline;
+class TextureView;
 
 struct ScopedFfiRenderTraits {
   typedef ffi::WGPURenderPass* type;

diff --git a/dom/webgpu/Sampler.h b/dom/webgpu/Sampler.h
@@ -6,6 +6,7 @@
 #ifndef GPU_SAMPLER_H_
 #define GPU_SAMPLER_H_
 
+#include "mozilla/webgpu/WebGPUTypes.h"
 #include "nsWrapperCache.h"
 #include "ObjectModel.h"
 

diff --git a/dom/webgpu/ShaderModule.h b/dom/webgpu/ShaderModule.h
@@ -6,6 +6,7 @@
 #ifndef GPU_ShaderModule_H_
 #define GPU_ShaderModule_H_
 
+#include "mozilla/webgpu/WebGPUTypes.h"
 #include "nsWrapperCache.h"
 #include "ObjectModel.h"
 

diff --git a/dom/xslt/xslt/txKey.h b/dom/xslt/xslt/txKey.h
@@ -7,8 +7,9 @@
 #define txKey_h__
 
 #include "nsTHashtable.h"
-#include "txNodeSet.h"
+#include "txExpandedNameMap.h"
 #include "txList.h"
+#include "txNodeSet.h"
 #include "txXSLTPatterns.h"
 #include "txXMLUtils.h"
 

diff --git a/dom/xul/nsXULCommandDispatcher.h b/dom/xul/nsXULCommandDispatcher.h
@@ -17,8 +17,10 @@
 #include "nsWeakReference.h"
 #include "nsString.h"
 #include "nsCycleCollectionParticipant.h"
+#include "nsTArray.h"
 #include "mozilla/RefPtr.h"
 
+class nsPIDOMWindowOuter;
 class nsPIWindowRoot;
 
 namespace mozilla {

diff --git a/gfx/2d/FilterNodeD2D1.h b/gfx/2d/FilterNodeD2D1.h
@@ -10,6 +10,7 @@
 #include "2D.h"
 #include "Filters.h"
 #include <vector>
+#include <windows.h>
 #include <d2d1_1.h>
 #include <cguid.h>
 

diff --git a/gfx/2d/ssse3-scaler.h b/gfx/2d/ssse3-scaler.h
@@ -8,6 +8,7 @@
 #define MOZILLA_GFX_2D_SSSE3_SCALER_H_
 
 #include <stdbool.h>
+#include <stdint.h>
 
 #ifdef __cplusplus
 extern "C" {