Skip to content

Commit

Permalink
Bug 1529571 - Use in rather than hasOwnProperty to check property…
Browse files Browse the repository at this point in the history
… support r=heycam

This test is supposed to check CSS property support, but using
hasOwnProperty() is causing a lot of false positive because
hasOwnProperty() doesn't go up the proto chain even if the property
is actually supported.

Differential Revision: https://phabricator.services.mozilla.com/D35512
  • Loading branch information
violette77 committed Jun 21, 2019
1 parent 301dd47 commit 879142e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 233 deletions.
232 changes: 0 additions & 232 deletions testing/web-platform/meta/svg/styling/required-properties.svg.ini
Original file line number Diff line number Diff line change
Expand Up @@ -5,246 +5,14 @@
[Property "baseline-shift" is supported]
expected: FAIL

[Property "clip" is supported]
expected: FAIL

[Property "clip-path" is supported]
expected: FAIL

[Property "clip-rule" is supported]
expected: FAIL

[Property "color" is supported]
expected: FAIL

[Property "color-interpolation" is supported]
expected: FAIL

[Property "color-interpolation-filters" is supported]
expected: FAIL

[Property "color-rendering" is supported]
expected: FAIL

[Property "cursor" is supported]
expected: FAIL

[Property "direction" is supported]
expected: FAIL

[Property "display" is supported]
expected: FAIL

[Property "dominant-baseline" is supported]
expected: FAIL

[Property "fill" is supported]
expected: FAIL

[Property "fill-opacity" is supported]
expected: FAIL

[Property "fill-rule" is supported]
expected: FAIL

[Property "filter" is supported]
expected: FAIL

[Property "flood-color" is supported]
expected: FAIL

[Property "flood-opacity" is supported]
expected: FAIL

[Property "font" is supported]
expected: FAIL

[Property "font-family" is supported]
expected: FAIL

[Property "font-feature-settings" is supported]
expected: FAIL

[Property "font-kerning" is supported]
expected: FAIL

[Property "font-size" is supported]
expected: FAIL

[Property "font-size-adjust" is supported]
expected: FAIL

[Property "font-stretch" is supported]
expected: FAIL

[Property "font-style" is supported]
expected: FAIL

[Property "font-variant" is supported]
expected: FAIL

[Property "font-variant-caps" is supported]
expected: FAIL

[Property "font-variant-east-asian" is supported]
expected: FAIL

[Property "font-variant-ligatures" is supported]
expected: FAIL

[Property "font-variant-numeric" is supported]
expected: FAIL

[Property "font-variant-position" is supported]
expected: FAIL

[Property "font-weight" is supported]
expected: FAIL

[Property "glyph-orientation-vertical" is supported]
expected: FAIL

[Property "image-rendering" is supported]
expected: FAIL

[Property "isolation" is supported]
expected: FAIL

[Property "letter-spacing" is supported]
expected: FAIL

[Property "lighting-color" is supported]
expected: FAIL

[Property "line-height" is supported]
expected: FAIL

[Property "marker" is supported]
expected: FAIL

[Property "marker-end" is supported]
expected: FAIL

[Property "marker-mid" is supported]
expected: FAIL

[Property "marker-start" is supported]
expected: FAIL

[Property "mask" is supported]
expected: FAIL

[Property "opacity" is supported]
expected: FAIL

[Property "overflow" is supported]
expected: FAIL

[Property "paint-order" is supported]
expected: FAIL

[Property "pointer-events" is supported]
expected: FAIL

[Property "shape-rendering" is supported]
expected: FAIL

[Property "stop-color" is supported]
expected: FAIL

[Property "stop-opacity" is supported]
expected: FAIL

[Property "stroke" is supported]
expected: FAIL

[Property "stroke-dasharray" is supported]
expected: FAIL

[Property "stroke-dashoffset" is supported]
expected: FAIL

[Property "stroke-linecap" is supported]
expected: FAIL

[Property "stroke-linejoin" is supported]
expected: FAIL

[Property "stroke-miterlimit" is supported]
expected: FAIL

[Property "stroke-opacity" is supported]
expected: FAIL

[Property "stroke-width" is supported]
expected: FAIL

[Property "text-align" is supported]
expected: FAIL

[Property "text-align-all" is supported]
expected: FAIL

[Property "text-align-last" is supported]
expected: FAIL

[Property "text-anchor" is supported]
expected: FAIL

[Property "text-decoration" is supported]
expected: FAIL

[Property "text-decoration-color" is supported]
expected: FAIL

[Property "text-decoration-line" is supported]
expected: FAIL

[Property "text-decoration-style" is supported]
expected: FAIL

[Property "text-indent" is supported]
expected: FAIL

[Property "text-orientation" is supported]
expected: FAIL

[Property "text-overflow" is supported]
expected: FAIL

[Property "text-rendering" is supported]
expected: FAIL

[Property "text-space-collapse" is supported]
expected: FAIL

[Property "transform" is supported]
expected: FAIL

[Property "transform-box" is supported]
expected: FAIL

[Property "transform-origin" is supported]
expected: FAIL

[Property "unicode-bidi" is supported]
expected: FAIL

[Property "vector-effect" is supported]
expected: FAIL

[Property "vertical-align" is supported]
expected: FAIL

[Property "visibility" is supported]
expected: FAIL

[Property "white-space" is supported]
expected: FAIL

[Property "word-spacing" is supported]
expected: FAIL

[Property "writing-mode" is supported]
expected: FAIL

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 879142e

Please sign in to comment.