Skip to content

Commit

Permalink
Bug 1160897 - Fixing .ycm_extra_conf for Fennec. r=ehsan
Browse files Browse the repository at this point in the history
Looks like ycmd fails to parse the file if the -march=arm* option is given
Removing it doesn't solve all YCM problems for Fennec, but it allows us
to use JumpToDefinition, GetType and semantic auto-completion.
  • Loading branch information
Danilo Cesar Lemes de Paula committed May 4, 2015
1 parent e9932d9 commit 8e29483
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion .ycm_extra_conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,14 @@ def FlagsForFile(filename):
out.encoding = None
mach.run(['compileflags', filename], stdout=out, stderr=out)

flag_list = shlex.split(out.getvalue())

# This flag is added by Fennec for android build and causes ycmd to fail to parse the file.
# Removing this flag is a workaround until ycmd starts to handle this flag properly.
# https://github.com/Valloric/YouCompleteMe/issues/1490
final_flags = [x for x in flag_list if not x.startswith('-march=armv')]

return {
'flags': shlex.split(out.getvalue()),
'flags': final_flags,
'do_cache': True
}

0 comments on commit 8e29483

Please sign in to comment.