Skip to content

Commit

Permalink
Bug 1660818 - Add telemetry to track the number of times the scrollab…
Browse files Browse the repository at this point in the history
…le badge is clicked. r=gl

Differential Revision: https://phabricator.services.mozilla.com/D88049
  • Loading branch information
20manas committed Aug 31, 2020
1 parent 6b98014 commit 99887bf
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ add_task(async function() {
"Scrollable badge is active"
);

checkTelemetry("devtools.markup.scrollable.badge.clicked", "", 1, "scalar");

info(
"Changing CSS so elements update their overflow highlights accordingly."
);
Expand Down Expand Up @@ -90,6 +92,8 @@ add_task(async function() {
!container.editor._scrollableBadge.classList.contains("active"),
"Scrollable badge is not active"
);

checkTelemetry("devtools.markup.scrollable.badge.clicked", "", 2, "scalar");
});

async function getContainerForSelector(selector, inspector) {
Expand Down
5 changes: 5 additions & 0 deletions devtools/client/inspector/markup/views/element-editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -1041,6 +1041,11 @@ ElementEditor.prototype = {
);
}
}

this.markup.telemetry.scalarAdd(
"devtools.markup.scrollable.badge.clicked",
1
);
},

/**
Expand Down
17 changes: 17 additions & 0 deletions toolkit/components/telemetry/Scalars.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2906,6 +2906,23 @@ devtools.changesview:
record_in_processes:
- 'main'

devtools.markup.scrollable.badge:
clicked:
bug_numbers:
- 1660818
description: >
Number of times the scrollable inspector badge has been clicked.
expires: never
kind: uint
notification_emails:
- [email protected]
release_channel_collection: opt-out
products:
- 'firefox'
- 'fennec'
record_in_processes:
- 'main'

dom.event:
confluence_load_count:
bug_numbers:
Expand Down

0 comments on commit 99887bf

Please sign in to comment.