Backed out changeset 28a0487d0291 (bug 1693222) for reftest failure o…

…n themed-widget.html. CLOSED TREE
iaxat · Sep 1, 2021 · 9f1575d · 9f1575d
1 parent 10c6832
commit 9f1575d
Show file tree

Hide file tree

Showing 33 changed files with 122 additions and 98 deletions.
diff --git a/browser/components/search/content/contentSearchUI.css b/browser/components/search/content/contentSearchUI.css
@@ -67,8 +67,8 @@
 }
 
 .contentSearchSuggestionRow.selected {
-  background-color: SelectedItem;
-  color: SelectedItemText;
+  background-color: Highlight;
+  color: HighlightText;
 }
 
 .contentSearchHeader,
@@ -132,7 +132,7 @@
 }
 
 .contentSearchOneOffItem.selected {
-  background-color: SelectedItem;
+  background-color: Highlight;
   background-image: none;
 }
 

diff --git a/browser/extensions/formautofill/skin/windows/autocomplete-item.css b/browser/extensions/formautofill/skin/windows/autocomplete-item.css
@@ -11,7 +11,7 @@
 
 @media (-moz-windows-default-theme: 0) {
   xul|richlistitem[originaltype="autofill-profile"][selected="true"] > .autofill-item-box {
-    background-color: SelectedItem;
+    background-color: Highlight;
   }
 
   .autofill-item-box {

diff --git a/browser/themes/linux/browser.css b/browser/themes/linux/browser.css
@@ -98,8 +98,8 @@ menuitem.bookmark-item {
 
 /* Bookmark drag and drop styles */
 .bookmark-item[dragover-into="true"] {
-  background: SelectedItem !important;
-  color: SelectedItemText !important;
+  background: Highlight !important;
+  color: HighlightText !important;
 }
 
 .bookmark-item[cutting] > .toolbarbutton-icon,
@@ -202,8 +202,8 @@ menuitem.bookmark-item {
 
 :root:not(:-moz-lwtheme) {
   --urlbar-popup-action-color: -moz-nativehyperlinktext;
-  --autocomplete-popup-highlight-background: SelectedItem;
-  --autocomplete-popup-highlight-color: SelectedItemText;
+  --autocomplete-popup-highlight-background: Highlight;
+  --autocomplete-popup-highlight-color: HighlightText;
 }
 
 /* Translation infobar */

diff --git a/browser/themes/linux/pageInfo.css b/browser/themes/linux/pageInfo.css
@@ -16,8 +16,8 @@
 }
 
 #viewGroup > radio[selected="true"] {
-  background-color: SelectedItem;
-  color: SelectedItemText;
+  background-color: Highlight;
+  color: HighlightText;
 }
 
 #viewGroup > radio > .radio-label-box {

diff --git a/browser/themes/osx/browser.css b/browser/themes/osx/browser.css
@@ -437,8 +437,8 @@ moz-input-box > menupopup .context-menu-add-engine > .menu-iconic-left {
 /* Bookmark drag and drop styles */
 
 .bookmark-item[dragover-into="true"] {
-  background: SelectedItem !important;
-  color: SelectedItemText !important;
+  background: Highlight !important;
+  color: HighlightText !important;
 }
 
 /* Translation */

diff --git a/browser/themes/shared/autocomplete.inc.css b/browser/themes/shared/autocomplete.inc.css
@@ -38,8 +38,8 @@
 }
 
 .autocomplete-richlistitem[selected] {
-  background-color: SelectedItem;
-  color: SelectedItemText;
+  background-color: Highlight;
+  color: HighlightText;
 }
 
 /* Autocomplete richlistitem support for a two-line label display */
@@ -100,7 +100,7 @@
 #PopupAutoComplete > richlistbox > richlistitem[originaltype="importableLogins"][selected] > .two-line-wrapper > .ac-site-icon,
 #PopupAutoComplete > richlistbox > richlistitem[originaltype="loginWithOrigin"][selected] > .two-line-wrapper > .ac-site-icon,
 #PopupAutoComplete > richlistbox > richlistitem[originaltype="login"] > .ac-site-icon[selected] {
-  fill: SelectedItemText;
+  fill: HighlightText;
 }
 
 /* Login form autocompletion with origin showing and generated passwords */

diff --git a/browser/themes/shared/browser.inc.css b/browser/themes/shared/browser.inc.css
@@ -256,7 +256,7 @@ menupopup::part(drop-indicator) {
   list-style-image: none;
   height: 2px;
   margin-inline-end: -4em;
-  background-color: SelectedItem;
+  background-color: Highlight;
   pointer-events: none;
 }
 

diff --git a/browser/themes/shared/places/tree-icons.css b/browser/themes/shared/places/tree-icons.css
@@ -78,7 +78,7 @@ treechildren::-moz-tree-cell-text(title, separator) {
 }
 
 treechildren::-moz-tree-cell-text(title, separator, selected, focus) {
-  color: SelectedItemText;
+  color: HighlightText;
 }
 
 /* Remove tiny spacing in separators appearing after the twisty column */

diff --git a/browser/themes/shared/preferences/search.css b/browser/themes/shared/preferences/search.css
@@ -55,7 +55,7 @@
 }
 
 #engineList treechildren::-moz-tree-drop-feedback {
-  background-color: SelectedItem;
+  background-color: Highlight;
   width: 10000px; /* 100% doesn't work; 10k is hopefully larger than any window
                      we may have, overflow isn't visible. */
   height: 2px;

diff --git a/browser/themes/shared/syncedtabs/sidebar.inc.css b/browser/themes/shared/syncedtabs/sidebar.inc.css
@@ -77,8 +77,8 @@ body {
 }
 
 .item.selected:focus > .item-title-container {
-  background-color: SelectedItem;
-  color: SelectedItemText;
+  background-color: Highlight;
+  color: HighlightText;
 }
 
 .item.client .item-twisty-container {

diff --git a/browser/themes/shared/toolbarbuttons.inc.css b/browser/themes/shared/toolbarbuttons.inc.css
@@ -70,7 +70,7 @@
 }
 
 #tabbrowser-arrowscrollbox[highlight]::part(scrollbutton-down) {
-  background-color: SelectedItem;
+  background-color: Highlight;
 }
 
 toolbar .toolbarbutton-1 {

diff --git a/browser/themes/shared/urlbar-searchbar.inc.css b/browser/themes/shared/urlbar-searchbar.inc.css
@@ -109,8 +109,8 @@
 
 #urlbar-input:-moz-lwtheme::selection,
 .searchbar-textbox:-moz-lwtheme::selection {
-  background-color: var(--lwt-toolbar-field-highlight, -moz-system-color(Highlight, light));
-  color: var(--lwt-toolbar-field-highlight-text, -moz-system-color(HighlightText, light));
+  background-color: var(--lwt-toolbar-field-highlight, -moz-system-color(text-select-background, light));
+  color: var(--lwt-toolbar-field-highlight-text, -moz-system-color(text-select-foreground, light));
 }
 
 #urlbar-input:not(:focus):-moz-lwtheme::selection,
@@ -120,14 +120,14 @@
 
 :root[lwt-toolbar-field-focus-brighttext] #urlbar-input:focus::selection,
 :root[lwt-toolbar-field-focus-brighttext] .searchbar-textbox:focus-within::selection {
-  background-color: var(--lwt-toolbar-field-highlight, -moz-system-color(Highlight, dark));
-  color: var(--lwt-toolbar-field-highlight-text, -moz-system-color(HighlightText, dark));
+  background-color: var(--lwt-toolbar-field-highlight, -moz-system-color(text-select-background, dark));
+  color: var(--lwt-toolbar-field-highlight-text, -moz-system-color(text-select-foreground, dark));
 }
 
 :root[lwt-toolbar-field-brighttext] #urlbar-input:not(:focus)::selection,
 :root[lwt-toolbar-field-brighttext] .searchbar-textbox:not(:focus-within)::selection {
   background-color: var(--lwt-toolbar-field-highlight, -moz-system-color(text-select-background-disabled, dark));
-  color: var(--lwt-toolbar-field-highlight-text, -moz-system-color(HighlightText, dark));
+  color: var(--lwt-toolbar-field-highlight-text, -moz-system-color(text-select-foreground, dark));
 }
 
 #urlbar:not([focused="true"]) {
@@ -310,9 +310,9 @@
 /* Use system colors for low/high contrast mode */
 @media (prefers-contrast) {
   #urlbar-search-mode-indicator {
-    background-color: SelectedItem;
-    outline-color: SelectedItem;
-    color: SelectedItemText;
+    background-color: Highlight;
+    outline-color: Highlight;
+    color: HighlightText;
   }
 
   #urlbar-search-mode-indicator-close {

diff --git a/browser/themes/shared/urlbarView.inc.css b/browser/themes/shared/urlbarView.inc.css
@@ -14,8 +14,8 @@
 :root {
   --autocomplete-popup-background: var(--arrowpanel-background);
   --autocomplete-popup-color: var(--arrowpanel-color);
-  --autocomplete-popup-highlight-background: SelectedItem;
-  --autocomplete-popup-highlight-color: SelectedItemText;
+  --autocomplete-popup-highlight-background: Highlight;
+  --autocomplete-popup-highlight-color: HighlightText;
 
   --urlbar-popup-action-color: hsl(178, 100%, 28%);
 

diff --git a/browser/themes/windows/browser-aero.css b/browser/themes/windows/browser-aero.css
@@ -222,8 +222,8 @@
           stroke: ButtonText;
         }
         .titlebar-button:hover {
-          background-color: SelectedItem;
-          stroke: SelectedItemText;
+          background-color: Highlight;
+          stroke: HighlightText;
         }
 
         .titlebar-min {

diff --git a/browser/themes/windows/browser.css b/browser/themes/windows/browser.css
@@ -531,8 +531,8 @@ menuitem.bookmark-item {
 
 toolbarbutton.bookmark-item[dragover="true"][open="true"] {
   appearance: none;
-  background: SelectedItem !important;
-  color: SelectedItemText !important;
+  background: Highlight !important;
+  color: HighlightText !important;
 }
 
 /* Translation infobar */

diff --git a/browser/themes/windows/places/organizer.css b/browser/themes/windows/places/organizer.css
@@ -10,11 +10,11 @@
   --organizer-pane-background: -moz-Dialog;
   --organizer-content-background: -moz-Dialog;
 
-  --organizer-hover-background: SelectedItem;
-  --organizer-hover-color: SelectedItemText;
-  --organizer-selected-background: SelectedItem;
-  --organizer-selected-color: SelectedItemText;
-  --organizer-outline-color: SelectedItem;
+  --organizer-hover-background: Highlight;
+  --organizer-hover-color: HighlightText;
+  --organizer-selected-background: Highlight;
+  --organizer-selected-color: HighlightText;
+  --organizer-outline-color: Highlight;
 
   --organizer-separator-color: ThreeDDarkShadow;
   --organizer-border-color: ThreeDShadow;

diff --git a/browser/themes/windows/webRTC-indicator.css b/browser/themes/windows/webRTC-indicator.css
@@ -22,8 +22,8 @@
     --minimize-button-active-background-color: hsla(0,0%,70%,.6);
     --control-icon-unchecked-hover-background-color: hsla(0,0%,70%,.2);
     --control-icon-unchecked-active-background-color: hsla(0,0%,70%,.6);
-    --control-icon-checked-background-color: SelectedItem;
-    --control-icon-checked-icon-fill: SelectedItemText;
+    --control-icon-checked-background-color: Highlight;
+    --control-icon-checked-icon-fill: HighlightText;
     --control-icon-checked-hover-background-color: hsla(0,0%,70%,.2);
     --control-icon-checked-active-background-color: hsla(0,0%,70%,.6);
   }

diff --git a/layout/generic/nsContainerFrame.cpp b/layout/generic/nsContainerFrame.cpp
@@ -434,7 +434,7 @@ DeviceColor nsDisplaySelectionOverlay::ComputeColor() const {
     return ComputeColorFromSelectionStyle(*style);
   }
   if (mSelectionValue == nsISelectionController::SELECTION_ON) {
-    colorID = LookAndFeel::ColorID::Highlight;
+    colorID = LookAndFeel::ColorID::TextSelectBackground;
   } else if (mSelectionValue == nsISelectionController::SELECTION_ATTENTION) {
     colorID = LookAndFeel::ColorID::TextSelectBackgroundAttention;
   } else {

diff --git a/layout/generic/nsTextFrame.cpp b/layout/generic/nsTextFrame.cpp
@@ -4061,9 +4061,9 @@ void nsTextPaintStyle::InitCommonColors() {
   nscolor defaultWindowBackgroundColor =
       LookAndFeel::Color(LookAndFeel::ColorID::WindowBackground, mFrame);
   nscolor selectionTextColor =
-      LookAndFeel::Color(LookAndFeel::ColorID::Highlighttext, mFrame);
+      LookAndFeel::Color(LookAndFeel::ColorID::TextSelectForeground, mFrame);
   nscolor selectionBGColor =
-      LookAndFeel::Color(LookAndFeel::ColorID::Highlight, mFrame);
+      LookAndFeel::Color(LookAndFeel::ColorID::TextSelectBackground, mFrame);
 
   mSufficientContrast = std::min(
       std::min(NS_SUFFICIENT_LUMINOSITY_DIFFERENCE,
@@ -4111,7 +4111,7 @@ bool nsTextPaintStyle::InitSelectionColorsAndShadow() {
   }
 
   nscolor selectionBGColor =
-      LookAndFeel::Color(LookAndFeel::ColorID::Highlight, mFrame);
+      LookAndFeel::Color(LookAndFeel::ColorID::TextSelectBackground, mFrame);
 
   switch (selectionStatus) {
     case nsISelectionController::SELECTION_ATTENTION: {
@@ -4135,7 +4135,7 @@ bool nsTextPaintStyle::InitSelectionColorsAndShadow() {
   }
 
   mSelectionTextColor =
-      LookAndFeel::Color(LookAndFeel::ColorID::Highlighttext, mFrame);
+      LookAndFeel::Color(LookAndFeel::ColorID::TextSelectForeground, mFrame);
 
   if (mResolveColors) {
     // On MacOS X, only the background color gets set,

diff --git a/layout/mathml/nsMathMLChar.cpp b/layout/mathml/nsMathMLChar.cpp
@@ -1699,7 +1699,8 @@ void nsDisplayMathMLSelectionRect::Paint(nsDisplayListBuilder* aBuilder,
                                   mFrame->PresContext()->AppUnitsPerDevPixel(),
                                   *drawTarget);
   // get color to use for selection from the look&feel object
-  nscolor bgColor = LookAndFeel::Color(LookAndFeel::ColorID::Highlight, mFrame);
+  nscolor bgColor =
+      LookAndFeel::Color(LookAndFeel::ColorID::TextSelectBackground, mFrame);
   drawTarget->FillRect(rect, ColorPattern(ToDeviceColor(bgColor)));
 }
 
@@ -1856,8 +1857,8 @@ void nsMathMLChar::PaintForeground(nsIFrame* aForFrame,
       &nsStyleText::mWebkitTextFillColor);
   if (aIsSelected) {
     // get color to use for selection from the look&feel object
-    fgColor = LookAndFeel::Color(LookAndFeel::ColorID::Highlighttext, aForFrame,
-                                 fgColor);
+    fgColor = LookAndFeel::Color(LookAndFeel::ColorID::TextSelectForeground,
+                                 aForFrame, fgColor);
   }
   aRenderingContext.SetColor(sRGBColor::FromABGR(fgColor));
   aRenderingContext.Save();

diff --git a/layout/style/res/forms.css b/layout/style/res/forms.css
@@ -351,13 +351,14 @@ select > option {
 }
 
 option:checked {
-  background-color: text-select-background-disabled !important;
-  color: SelectedItemText !important;
+  background-color: -moz-html-cellhighlight !important;
+  color: -moz-html-cellhighlighttext !important;
 }
 
 select:focus > option:checked,
 select:focus > optgroup > option:checked {
-  background-color: SelectedItem !important;
+  background-color: Highlight !important;
+  color: HighlightText !important;
 }
 
 optgroup {

diff --git a/layout/tables/nsTableCellFrame.cpp b/layout/tables/nsTableCellFrame.cpp
@@ -263,7 +263,8 @@ void nsTableCellFrame::DecorateForSelection(DrawTarget* aDrawTarget,
       if (displaySelection == nsISelectionController::SELECTION_DISABLED) {
         bordercolor = NS_RGB(176, 176, 176);  // disabled color
       } else {
-        bordercolor = LookAndFeel::Color(LookAndFeel::ColorID::Highlight, this);
+        bordercolor = LookAndFeel::Color(
+            LookAndFeel::ColorID::TextSelectBackground, this);
       }
       nscoord threePx = nsPresContext::CSSPixelsToAppUnits(3);
       if ((mRect.width > threePx) && (mRect.height > threePx)) {

diff --git a/servo/components/style/values/specified/color.rs b/servo/components/style/values/specified/color.rs
@@ -244,6 +244,10 @@ pub enum SystemColor {
     #[css(skip)]
     TextForeground,
     #[parse(condition = "ParserContext::in_ua_or_chrome_sheet")]
+    TextSelectBackground,
+    #[parse(condition = "ParserContext::in_ua_or_chrome_sheet")]
+    TextSelectForeground,
+    #[parse(condition = "ParserContext::in_ua_or_chrome_sheet")]
     TextSelectBackgroundDisabled,
     #[parse(condition = "ParserContext::in_ua_or_chrome_sheet")]
     TextSelectBackgroundAttention,
@@ -335,11 +339,9 @@ pub enum SystemColor {
     /// Used for selected but not focused cell text.
     MozCellhighlighttext,
     /// Used for selected but not focused html cell backgrounds.
-    #[parse(aliases = "-moz-html-cellhighlight")]
-    Selecteditem,
+    MozHtmlCellhighlight,
     /// Used for selected but not focused html cell text.
-    #[parse(aliases = "-moz-html-cellhighlighttext")]
-    Selecteditemtext,
+    MozHtmlCellhighlighttext,
     /// Used to button text background when hovered.
     MozButtonhoverface,
     /// Used to button text color when hovered.

diff --git a/testing/web-platform/tests/css/css-color/parsing/system-color-valid.html b/testing/web-platform/tests/css/css-color/parsing/system-color-valid.html
@@ -23,8 +23,6 @@
 test_valid_value("color", "HighlightText", "highlighttext");
 test_valid_value("color", "LinkText", "linktext");
 test_valid_value("color", "VisitedText", "visitedtext");
-test_valid_value("color", "SelectedItem", "selecteditem");
-test_valid_value("color", "SelectedItemText", "selecteditemtext");
 </script>
 </body>
 </html>
diff --git a/toolkit/themes/shared/findbar.css b/toolkit/themes/shared/findbar.css
@@ -75,22 +75,22 @@ html|input.findbar-textbox:focus {
 }
 
 html|input.findbar-textbox:-moz-lwtheme::selection {
-  background-color: var(--lwt-toolbar-field-highlight, -moz-system-color(Higlight, light));
-  color: var(--lwt-toolbar-field-highlight-text, -moz-system-color(HighlightText, light));
+  background-color: var(--lwt-toolbar-field-highlight, -moz-system-color(text-select-background, light));
+  color: var(--lwt-toolbar-field-highlight-text, -moz-system-color(text-select-foreground, light));
 }
 
 html|input.findbar-textbox:not(:focus):-moz-lwtheme::selection {
   background-color: var(--lwt-toolbar-field-highlight, -moz-system-color(text-select-background-disabled, light));
 }
 
 :root[lwt-toolbar-field-focus-brighttext] html|input.findbar-textbox:focus::selection {
-  background-color: var(--lwt-toolbar-field-highlight, -moz-system-color(Higlight, dark));
-  color: var(--lwt-toolbar-field-highlight-text, -moz-system-color(HighlightText, dark));
+  background-color: var(--lwt-toolbar-field-highlight, -moz-system-color(text-select-background, dark));
+  color: var(--lwt-toolbar-field-highlight-text, -moz-system-color(text-select-foreground, dark));
 }
 
 :root[lwt-toolbar-field-brighttext] html|input.findbar-textbox:not(:focus)::selection {
   background-color: var(--lwt-toolbar-field-highlight, -moz-system-color(text-select-background-disabled, dark));
-  color: var(--lwt-toolbar-field-highlight-text, -moz-system-color(HighlightText, dark));
+  color: var(--lwt-toolbar-field-highlight-text, -moz-system-color(text-select-foreground, dark));
 }