Bug 1727423 - Remove BasicLayerManager. r=jrmuizel

Differential Revision: https://phabricator.services.mozilla.com/D123555

gfx/layers/LayerManager.h

@@ -56,7 +56,6 @@ class DrawTarget;
 namespace layers {
 
 class AsyncPanZoomController;
-class BasicLayerManager;
 class ClientLayerManager;
 class HostLayerManager;
 class Layer;
@@ -165,7 +164,6 @@ class LayerManager : public WindowRenderer {
 
   virtual LayerManagerComposite* AsLayerManagerComposite() { return nullptr; }
 
-  virtual BasicLayerManager* AsBasicLayerManager() { return nullptr; }
   virtual HostLayerManager* AsHostLayerManager() { return nullptr; }
 
   virtual WebRenderLayerManager* AsWebRenderLayerManager() { return nullptr; }

gfx/layers/RotatedBuffer.cpp

@@ -11,9 +11,7 @@
 #include <algorithm>  // for max
 #include <utility>    // for Move
 
-#include "BasicImplData.h"    // for BasicImplData
-#include "BasicLayersImpl.h"  // for ToData
-#include "Layers.h"           // for PaintedLayer, Layer, etc
+#include "Layers.h"  // for PaintedLayer, Layer, etc
 #include "gfx2DGlue.h"
 #include "gfxPlatform.h"         // for gfxPlatform
 #include "gfxUtils.h"            // for gfxUtils
@@ -203,36 +201,6 @@ static bool IsClippingCheap(gfx::DrawTarget* aTarget,
          aRegion.GetNumRects() <= 1;
 }
 
-void RotatedBuffer::DrawTo(PaintedLayer* aLayer, DrawTarget* aTarget,
-                           float aOpacity, CompositionOp aOp,
-                           SourceSurface* aMask, const Matrix* aMaskTransform) {
-  bool clipped = false;
-
-  // If the entire buffer is valid, we can just draw the whole thing,
-  // no need to clip. But we'll still clip if clipping is cheap ---
-  // that might let us copy a smaller region of the buffer.
-  // Also clip to the visible region if we're told to.
-  if (!aLayer->GetValidRegion().Contains(BufferRect()) ||
-      (ToData(aLayer)->GetClipToVisibleRegion() &&
-       !aLayer->GetVisibleRegion().ToUnknownRegion().Contains(BufferRect())) ||
-      IsClippingCheap(aTarget,
-                      aLayer->GetLocalVisibleRegion().ToUnknownRegion())) {
-    // We don't want to draw invalid stuff, so we need to clip. Might as
-    // well clip to the smallest area possible --- the visible region.
-    // Bug 599189 if there is a non-integer-translation transform in aTarget,
-    // we might sample pixels outside GetLocalVisibleRegion(), which is wrong
-    // and may cause gray lines.
-    gfxUtils::ClipToRegion(aTarget,
-                           aLayer->GetLocalVisibleRegion().ToUnknownRegion());
-    clipped = true;
-  }
-
-  DrawBufferWithRotation(aTarget, aOpacity, aOp, aMask, aMaskTransform);
-  if (clipped) {
-    aTarget->PopClip();
-  }
-}
-
 void RotatedBuffer::UpdateDestinationFrom(const RotatedBuffer& aSource,
                                           const gfx::IntRect& aUpdateRect) {
   DrawIterator iter;

gfx/layers/RotatedBuffer.h

@@ -98,15 +98,6 @@ class RotatedBuffer : public BorrowDrawTarget {
       gfx::SourceSurface* aMask = nullptr,
       const gfx::Matrix* aMaskTransform = nullptr) const;
 
-  /**
-   * Complete the drawing operation. The region to draw must have been
-   * drawn before this is called. The contents of the buffer are drawn
-   * to aTarget.
-   */
-  void DrawTo(PaintedLayer* aLayer, gfx::DrawTarget* aTarget, float aOpacity,
-              gfx::CompositionOp aOp, gfx::SourceSurface* aMask,
-              const gfx::Matrix* aMaskTransform);
-
   /**
    * Update the specified region of this rotated buffer with the contents
    * of a source rotated buffer.