Bug 1434446 - Enable no-unused-vars for global scope on jsm files in …

…browser/. r=mossop MozReview-Commit-ID: ERT1Fili25d
iaxat · Mar 1, 2018 · a8e2f8d · a8e2f8d
1 parent 453b78d
commit a8e2f8d
Show file tree

Hide file tree

Showing 8 changed files with 5 additions and 29 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -48,21 +48,6 @@ module.exports = {
     "rules": {
       "mozilla/use-services": "off",
     }
-  }, {
-    // XXX Bug 1434446. These directories have jsm files still being fixed, so
-    // turn off global no-unused-vars checking for them.
-    "files": [
-      "browser/components/**/*.jsm",
-      "browser/extensions/**/*.jsm",
-    ],
-    "rules": {
-      "mozilla/mark-exported-symbols-as-used": "error",
-      "no-unused-vars": ["error", {
-        "args": "none",
-        "vars": "local",
-        "varsIgnorePattern": "^EXPORTED_SYMBOLS$"
-      }]
-    }
   }, {
     // XXX Bug 1436303. These directories are still being fixed, so turn off
     // mozilla/no-cc-etc for now.

diff --git a/browser/components/customizableui/CustomizeMode.jsm b/browser/components/customizableui/CustomizeMode.jsm
@@ -12,7 +12,6 @@ const kDragDataTypePrefix = "text/toolbarwrapper-id/";
 const kSkipSourceNodePref = "browser.uiCustomization.skipSourceNodeCheck";
 const kDrawInTitlebarPref = "browser.tabs.drawInTitlebar";
 const kExtraDragSpacePref = "browser.tabs.extraDragSpace";
-const kMaxTransitionDurationMs = 2000;
 const kKeepBroadcastAttributes = "keepbroadcastattributeswhencustomizing";
 
 const kPanelItemContextMenu = "customizationPanelItemContextMenu";

diff --git a/browser/components/customizableui/PanelMultiView.jsm b/browser/components/customizableui/PanelMultiView.jsm
@@ -264,7 +264,7 @@ var AssociatedToNode = class {
 /**
  * This is associated to <panelmultiview> elements.
  */
-var PanelMultiView = class extends this.AssociatedToNode {
+var PanelMultiView = class extends AssociatedToNode {
   /**
    * Tries to open the specified <panel> and displays the main view specified
    * with the "mainViewId" attribute on the <panelmultiview> node it contains.
@@ -1138,7 +1138,7 @@ var PanelMultiView = class extends this.AssociatedToNode {
 /**
  * This is associated to <panelview> elements.
  */
-var PanelView = class extends this.AssociatedToNode {
+var PanelView = class extends AssociatedToNode {
   constructor(node) {
     super(node);
 

diff --git a/browser/components/downloads/DownloadsCommon.jsm b/browser/components/downloads/DownloadsCommon.jsm
@@ -72,8 +72,6 @@ const kDownloadsStringsRequiringPluralForm = {
   otherDownloads3: true
 };
 
-const kPartialDownloadSuffix = ".part";
-
 const kMaxHistoryResultsForLimitedView = 42;
 
 const kPrefBranch = Services.prefs.getBranch("browser.download.");

diff --git a/browser/components/downloads/DownloadsSubview.jsm b/browser/components/downloads/DownloadsSubview.jsm
@@ -22,7 +22,6 @@ ChromeUtils.defineModuleGetter(this, "FileUtils",
                                "resource://gre/modules/FileUtils.jsm");
 
 let gPanelViewInstances = new WeakMap();
-const kEvents = ["ViewShowing", "ViewHiding", "click", "command"];
 const kRefreshBatchSize = 10;
 const kMaxWaitForIdleMs = 200;
 XPCOMUtils.defineLazyGetter(this, "kButtonLabels", () => {

diff --git a/browser/components/sessionstore/SessionSaver.jsm b/browser/components/sessionstore/SessionSaver.jsm
@@ -57,7 +57,6 @@ function stopWatch(method) {
 }
 
 var stopWatchStart = stopWatch("start");
-var stopWatchCancel = stopWatch("cancel");
 var stopWatchFinish = stopWatch("finish");
 
 /**
@@ -390,4 +389,3 @@ XPCOMUtils.defineLazyPreferenceGetter(SessionSaverInternal, "_idleDelay", PREF_I
 
 var idleService = Cc["@mozilla.org/widget/idleservice;1"].getService(Ci.nsIIdleService);
 idleService.addIdleObserver(SessionSaverInternal, SessionSaverInternal._idleDelay);
-
diff --git a/browser/components/translation/YandexTranslator.jsm b/browser/components/translation/YandexTranslator.jsm
@@ -28,15 +28,13 @@ const MAX_REQUEST_CHUNKS = 1000; // Documentation says 2000.
 // is MAX_REQUESTS * MAX_REQUEST_DATA.
 const MAX_REQUESTS = 15;
 
-const YANDEX_RETURN_CODE_OK = 200;
-
 const YANDEX_ERR_KEY_INVALID               = 401; // Invalid API key
 const YANDEX_ERR_KEY_BLOCKED               = 402; // This API key has been blocked
 const YANDEX_ERR_DAILY_REQ_LIMIT_EXCEEDED  = 403; // Daily limit for requests reached
 const YANDEX_ERR_DAILY_CHAR_LIMIT_EXCEEDED = 404; // Daily limit of chars reached
-const YANDEX_ERR_TEXT_TOO_LONG             = 413; // The text size exceeds the maximum
-const YANDEX_ERR_UNPROCESSABLE_TEXT        = 422; // The text could not be translated
-const YANDEX_ERR_LANG_NOT_SUPPORTED        = 501; // The specified translation direction is not supported
+// const YANDEX_ERR_TEXT_TOO_LONG             = 413; // The text size exceeds the maximum
+// const YANDEX_ERR_UNPROCESSABLE_TEXT        = 422; // The text could not be translated
+// const YANDEX_ERR_LANG_NOT_SUPPORTED        = 501; // The specified translation direction is not supported
 
 // Errors that should activate the service unavailable handling
 const YANDEX_PERMANENT_ERRORS = [

diff --git a/browser/extensions/pocket/content/pktApi.jsm b/browser/extensions/pocket/content/pktApi.jsm
@@ -42,7 +42,6 @@
  *      usedTags:         All used tags from within the extension sorted by recency
  */
 
-const Cm = Components.manager;
 var EXPORTED_SYMBOLS = ["pktApi"];
 
 ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");