Skip to content

Commit

Permalink
Backed out changeset 15f8b27f1305 (bug 1511557) for build bustages on…
Browse files Browse the repository at this point in the history
… a CLOSED TREE.
  • Loading branch information
Razvan Maries committed Dec 14, 2018
1 parent 36ece37 commit b0b6d46
Showing 1 changed file with 5 additions and 13 deletions.
18 changes: 5 additions & 13 deletions ipc/glue/GeckoChildProcessHost.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
#include "mozilla/ipc/BrowserProcessSubThread.h"
#include "mozilla/ipc/EnvironmentMap.h"
#include "mozilla/Omnijar.h"
#include "mozilla/Scoped.h"
#include "mozilla/Telemetry.h"
#include "ProtocolUtils.h"
#include <sys/stat.h>
Expand Down Expand Up @@ -69,13 +68,6 @@
using mozilla::MonitorAutoLock;
using mozilla::ipc::GeckoChildProcessHost;

namespace mozilla {
MOZ_TYPE_SPECIFIC_SCOPED_POINTER_TEMPLATE(ScopedPRFileDesc, PRFileDesc,
PR_Close)
}

using mozilla::ScopedPRFileDesc;

#ifdef MOZ_WIDGET_ANDROID
#include "AndroidBridge.h"
#include "GeneratedJNIWrappers.h"
Expand Down Expand Up @@ -608,10 +600,10 @@ bool GeckoChildProcessHost::PerformAsyncLaunch(
const char* const childProcessType =
XRE_ChildProcessTypeToString(mProcessType);

ScopedPRFileDesc crashAnnotationReadPipe;
ScopedPRFileDesc crashAnnotationWritePipe;
if (PR_CreatePipe(&crashAnnotationReadPipe.rwget(),
&crashAnnotationWritePipe.rwget()) != PR_SUCCESS) {
PRFileDesc* crashAnnotationReadPipe;
PRFileDesc* crashAnnotationWritePipe;
if (PR_CreatePipe(&crashAnnotationReadPipe, &crashAnnotationWritePipe) !=
PR_SUCCESS) {
return false;
}

Expand Down Expand Up @@ -1114,7 +1106,7 @@ bool GeckoChildProcessHost::PerformAsyncLaunch(
CrashReporter::RegisterChildCrashAnnotationFileDescriptor(
process, crashAnnotationReadPipe);
#endif
crashAnnotationReadPipe = nullptr;
PR_Close(crashAnnotationWritePipe);

MonitorAutoLock lock(mMonitor);
mProcessState = PROCESS_CREATED;
Expand Down

0 comments on commit b0b6d46

Please sign in to comment.