Skip to content

Commit

Permalink
Bug 1717924: Stop using an external STUN server for these tests. r=mj…
Browse files Browse the repository at this point in the history
…f, a=test-only

Differential Revision: https://phabricator.services.mozilla.com/D206273
  • Loading branch information
docfaraday committed Apr 2, 2024
1 parent be437de commit b3ddb10
Showing 1 changed file with 12 additions and 7 deletions.
19 changes: 12 additions & 7 deletions dom/media/webrtc/transport/test/ice_unittest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ using namespace mozilla;

static unsigned int kDefaultTimeout = 7000;

// TODO([email protected]): This should get replaced with some non-external
// solution like discussed in bug 860775.
const std::string kDefaultStunServerHostname((char*)"stun.l.google.com");
// TODO: It would be nice to have a test STUN/TURN server that can run with
// gtest.
const std::string kDefaultStunServerHostname((char*)"");
const std::string kBogusStunServerHostname(
(char*)"stun-server-nonexistent.invalid");
const uint16_t kDefaultStunServerPort = 19305;
Expand Down Expand Up @@ -1576,12 +1576,17 @@ class WebRtcIceConnectTest : public StunTest {
peer->SetMappingType(mapping_type_);
peer->SetBlockUdp(block_udp_);
} else if (setup_stun_servers) {
std::vector<NrIceStunServer> stun_servers;
if (stun_server_address_.empty()) {
InitTestStunServer();
peer->UseTestStunServer();
} else {
std::vector<NrIceStunServer> stun_servers;

stun_servers.push_back(*NrIceStunServer::Create(
stun_server_address_, kDefaultStunServerPort, kNrIceTransportUdp));
stun_servers.push_back(*NrIceStunServer::Create(
stun_server_address_, kDefaultStunServerPort, kNrIceTransportUdp));

peer->SetStunServers(stun_servers);
peer->SetStunServers(stun_servers);
}
}
}

Expand Down

0 comments on commit b3ddb10

Please sign in to comment.