Bug 1830790 - P16 - remove localSdp and remoteSdp from internal stats…

… report;r=bwc,webidl,smaug Differential Revision: https://phabricator.services.mozilla.com/D178978
iaxat · May 31, 2023 · bc85562 · bc85562
1 parent e47d7b2
commit bc85562
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/dom/media/webrtc/WebrtcGlobal.h b/dom/media/webrtc/WebrtcGlobal.h
@@ -119,8 +119,8 @@ struct ParamTraits<mozilla::dom::RTCStatsCollection> {
 
 DEFINE_IPC_SERIALIZER_WITH_SUPER_CLASS_AND_FIELDS(
     mozilla::dom::RTCStatsReportInternal, mozilla::dom::RTCStatsCollection,
-    mClosed, mLocalSdp, mSdpHistory, mPcid, mBrowserId, mRemoteSdp, mTimestamp,
-    mCallDurationMs, mIceRestarts, mIceRollbacks, mOfferer, mConfiguration);
+    mClosed, mSdpHistory, mPcid, mBrowserId, mTimestamp, mCallDurationMs,
+    mIceRestarts, mIceRollbacks, mOfferer, mConfiguration);
 
 typedef mozilla::dom::RTCStats RTCStats;
 

diff --git a/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp b/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp
@@ -3737,10 +3737,6 @@ RefPtr<dom::RTCStatsReportPromise> PeerConnectionImpl::GetStats(
           mJsepSession->GetLocalDescription(kJsepDescriptionPendingOrCurrent);
       std::string remoteDescription =
           mJsepSession->GetRemoteDescription(kJsepDescriptionPendingOrCurrent);
-      report->mLocalSdp.Construct(
-          NS_ConvertASCIItoUTF16(localDescription.c_str()));
-      report->mRemoteSdp.Construct(
-          NS_ConvertASCIItoUTF16(remoteDescription.c_str()));
       if (!report->mSdpHistory.AppendElements(mSdpHistory, fallible)) {
         mozalloc_handle_oom(0);
       }

diff --git a/dom/webidl/RTCStatsReport.webidl b/dom/webidl/RTCStatsReport.webidl
@@ -311,8 +311,6 @@ dictionary RTCStatsReportInternal : RTCStatsCollection {
   required unsigned long                    browserId;
   RTCConfigurationInternal                  configuration;
   DOMString                                 jsepSessionErrors;
-  DOMString                                 localSdp;
-  DOMString                                 remoteSdp;
   // TODO demux from RTCStatsReportInternal in bug 1830824
   sequence<RTCSdpHistoryEntryInternal>      sdpHistory = [];
   required DOMHighResTimeStamp              timestamp;