Skip to content

Commit

Permalink
Bug 1808416 - Do not check crashreporter symbols on tsan r=jmaher
Browse files Browse the repository at this point in the history
In mozharness, setting --download-symbols=True or --download-symbols=ondemand
triggers an attempt to access the symbols url (either to download them or just
verify that they exist). asan and tsan builds only have the special "full"
symbols, which are never used by mozharness. Removing the --download-symbols
option from the command line avoids the url check entirely, which avoids
retries, warnings, and errors in the log.

Differential Revision: https://phabricator.services.mozilla.com/D165921
  • Loading branch information
gbrownmozilla committed Jan 4, 2023
1 parent b274487 commit d2a3d13
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion taskcluster/gecko_taskgraph/transforms/test/other.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ def set_download_symbols(config, tasks):
for task in tasks:
if task["test-platform"].split("/")[-1] == "debug":
task["mozharness"]["download-symbols"] = True
elif "asan" in task["build-platform"]:
elif "asan" in task["build-platform"] or "tsan" in task["build-platform"]:
if "download-symbols" in task["mozharness"]:
del task["mozharness"]["download-symbols"]
else:
Expand Down

0 comments on commit d2a3d13

Please sign in to comment.