Bug 1763783 - Part 9: Update ICU draft API guards. r=platform-i18n-re…

…viewers,jfkthame

- `UCAL_TZ_LOCAL_FORMER` and `UCAL_TZ_LOCAL_FORMER` are now stable.
- `UNUM_APPROXIMATELY_SIGN_FIELD` is a new draft API.

Depends on D143281

Differential Revision: https://phabricator.services.mozilla.com/D143282

intl/components/src/NumberFormatFields.cpp

@@ -378,7 +378,7 @@ Maybe<NumberPartType> GetPartTypeForNumberField(UNumberFormatFields fieldName,
       return Some(NumberPartType::Unit);
     case UNUM_COMPACT_FIELD:
       return Some(NumberPartType::Compact);
-#if !MOZ_SYSTEM_ICU
+#ifndef U_HIDE_DRAFT_API
     case UNUM_APPROXIMATELY_SIGN_FIELD:
       return Some(NumberPartType::ApproximatelySign);
 #endif

intl/components/src/TimeZone.cpp

@@ -169,13 +169,8 @@ Result<int32_t, ICUError> TimeZone::GetUTCOffsetMs(int64_t aLocalMilliseconds) {
   // time starts or the time zone offset is increased due to a time zone rule
   // change), t_local must be interpreted using the time zone offset before the
   // transition.
-#ifndef U_HIDE_DRAFT_API
   constexpr UTimeZoneLocalOption skippedTime = UCAL_TZ_LOCAL_FORMER;
   constexpr UTimeZoneLocalOption repeatedTime = UCAL_TZ_LOCAL_FORMER;
-#else
-  constexpr UTimeZoneLocalOption skippedTime = UTimeZoneLocalOption(0x4);
-  constexpr UTimeZoneLocalOption repeatedTime = UTimeZoneLocalOption(0x4);
-#endif
 
   UDate date = UDate(aLocalMilliseconds);