Bug 1596160: Re-enable eslint rules within layout and address eslint …

…failures in testcases r=dholbert

This patch was largely automated. It was generated by manually
editing .eslintrc.js and then running mach eslint layout --fix.

Additionally, this includes manual changes to test_bug533845.xhtml
and test_bug467442.xhtml that were necessary to appease eslint.

Differential Revision: https://phabricator.services.mozilla.com/D78615

.eslintrc.js

@@ -184,8 +184,6 @@ module.exports = {
         "mozilla/reject-importGlobalProperties": "off",
         "mozilla/no-arbitrary-setTimeout": "off",
         "mozilla/no-define-cc-etc": "off",
-        "mozilla/no-useless-parameters": "off",
-        "mozilla/no-useless-removeEventListener": "off",
         "mozilla/use-chromeutils-generateqi": "off",
         "mozilla/use-default-preference-values": "off",
         "mozilla/use-includes-instead-of-indexOf": "off",
@@ -208,7 +206,6 @@ module.exports = {
         "no-restricted-globals": "off",
         "no-return-await": "off",
         "no-sequences": "off",
-        "no-shadow": "off",
         "no-throw-literal": "off",
         "no-useless-concat": "off",
         "no-undef": "off",

layout/base/tests/chrome/test_bug420499.xhtml

@@ -78,47 +78,47 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=420499
       ok(!isCaretVisible(), "Caret shouldn't be visible");
       $("text-input").focus();
       ok(isCaretVisible(), "Caret should be visible when input focused");
-      window.addEventListener("popupshown", popupMenuShownHandler, false);
+      window.addEventListener("popupshown", popupMenuShownHandler);
       $("menu").open = true;
     }
 
     function popupMenuShownHandler() {
-      window.removeEventListener("popupshown", popupMenuShownHandler, false);
+      window.removeEventListener("popupshown", popupMenuShownHandler);
       ok(!isCaretVisible(), "Caret shouldn't be visible when menu open");
-      window.addEventListener("popuphidden", ensureParagraphFocused, false);
+      window.addEventListener("popuphidden", ensureParagraphFocused);
       $("menu").open = false;
     }
 
     function ensureParagraphFocused() {
-      window.removeEventListener("popuphidden", ensureParagraphFocused, false);
+      window.removeEventListener("popuphidden", ensureParagraphFocused);
       ok(isCaretVisible(), "Caret should have returned to previous focus");
-      window.addEventListener("popupshown", popupMenuShownHandler2, false);
+      window.addEventListener("popupshown", popupMenuShownHandler2);
       $("contextmenu").openPopup($('text-input'), "topleft" , -1 , -1 , true, true);
     }
 
     function popupMenuShownHandler2() {
-      window.removeEventListener("popupshown", popupMenuShownHandler2, false);
+      window.removeEventListener("popupshown", popupMenuShownHandler2);
       ok(isCaretVisible(), "Caret should be visible when context menu open");
-      window.addEventListener("popuphidden", ensureParagraphFocused2, false);
+      window.addEventListener("popuphidden", ensureParagraphFocused2);
       document.getElementById("contextmenu").hidePopup();
     }
 
     function ensureParagraphFocused2() {
-      window.removeEventListener("popuphidden", ensureParagraphFocused2, false);
+      window.removeEventListener("popuphidden", ensureParagraphFocused2);
       ok(isCaretVisible(), "Caret should still be visible");
-      window.addEventListener("popupshown", tooltipShownHandler, false);
+      window.addEventListener("popupshown", tooltipShownHandler);
       $("tooltip").openPopup($('text-input'), "topleft" , -1 , -1 , false, true);
     }
 
     function tooltipShownHandler() {
-      window.removeEventListener("popupshown", tooltipShownHandler, false);
+      window.removeEventListener("popupshown", tooltipShownHandler);
       ok(isCaretVisible(), "Caret should be visible when tooltip is visible");
-      window.addEventListener("popuphidden", ensureParagraphFocused3, false);
+      window.addEventListener("popuphidden", ensureParagraphFocused3);
       document.getElementById("tooltip").hidePopup();
     }
 
     function ensureParagraphFocused3() {
-      window.removeEventListener("popuphidden", ensureParagraphFocused2, false);
+      window.removeEventListener("popuphidden", ensureParagraphFocused2);
       ok(isCaretVisible(), "Caret should still be visible");
       SimpleTest.finish();
     }

layout/base/tests/chrome/test_bug533845.xhtml

@@ -24,14 +24,12 @@ SimpleTest.waitForExplicitFinish();
 function doTest() {
   let panel = document.getElementById("panel");
   panel.addEventListener("popupshown", function onpopupshown() {
-    panel.removeEventListener("popupshown", onpopupshown);
     continueTest();
     panel.addEventListener("popuphidden", function onpopuphidden() {
-      panel.removeEventListener("popuphidden", onpopuphidden);
       SimpleTest.finish();
-    });
+    }, { once: true });
     panel.hidePopup();
-  });
+  }, { once: true });
   panel.openPopup();
 }
 

layout/base/tests/chrome/test_leaf_layers_partition_browser_window.xhtml

@@ -102,7 +102,7 @@
     }
 
     function setupWindow() {
-      win.addEventListener("load", doTest, false);
+      win.addEventListener("load", doTest);
       win.focus();
     }
 

layout/generic/test/test_bug469774.xhtml

@@ -41,7 +41,7 @@ function snapShot() {
 }
 
 function doTest() {
-  window.removeEventListener("focus", doTest, false);
+  window.removeEventListener("focus", doTest);
 
   var before = snapShot();
 
@@ -61,11 +61,11 @@ function doTest() {
 
     popup.hidePopup();
     SimpleTest.finish();
-  }, false);
+  });
 }
 
 SimpleTest.waitForExplicitFinish();
-window.addEventListener("focus", doTest, false);
+window.addEventListener("focus", doTest);
 
 ]]></script>
 

layout/style/test/chrome/test_bug535806.xhtml

@@ -24,7 +24,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=535806
 
   window.addEventListener("load", function() {
       $("f").setAttribute("src", "bug535806-html.html");
-    }, false);
+    });
 
   function htmlLoaded() {
     $("f").setAttribute("src", "bug535806-xul.xhtml");

layout/xul/test/test_bug467442.xhtml

@@ -29,16 +29,14 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=467442
     let anchor = document.getElementById("anchor");
 
     panel.addEventListener("popupshown", function onpopupshown() {
-      panel.removeEventListener("popupshown", onpopupshown);
       let panelRect = panel.getBoundingClientRect();
       let anchorRect = anchor.getBoundingClientRect();
       is(panelRect.left, anchorRect.left, "Panel should be anchored to the button");
       panel.addEventListener("popuphidden", function onpopuphidden() {
-        panel.removeEventListener("popuphidden", onpopuphidden);
         SimpleTest.finish();
-      });
+      }, { once: true });
       panel.hidePopup();
-    });
+    }, { once: true });
 
     panel.openPopup(anchor, "after_start", 0, 0, false, false);
   }

layout/xul/test/test_submenuClose.xhtml

@@ -77,10 +77,10 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=1181560
     mainMenu = document.getElementById("menu");
     menuB = document.getElementById("b");
     menuC = document.getElementById("c");
-    menuB.menupopup.addEventListener("popupshown", handleBOpens, false);
-    menuB.menupopup.addEventListener("popuphidden", handleBCloses, false);
-    menuC.menupopup.addEventListener("popupshown", handleCOpens, false);
-    menuC.menupopup.addEventListener("popuphidden", handleCCloses, false);
+    menuB.menupopup.addEventListener("popupshown", handleBOpens);
+    menuB.menupopup.addEventListener("popuphidden", handleBCloses);
+    menuC.menupopup.addEventListener("popupshown", handleCOpens);
+    menuC.menupopup.addEventListener("popuphidden", handleCCloses);
     mainMenu.addEventListener("popupshown", ev => {
       synthesizeMouseAtCenter(menuB, {}, window);
     });

layout/xul/test/test_windowminmaxsize.xhtml

@@ -202,8 +202,8 @@ function titledPanelWindowOpened(panelwindow)
 {
   var panel = panelwindow.document.documentElement.firstChild;
   panel.openPopup();
-  panel.addEventListener("popupshown", () => doTitledPanelTest(panel), false);
-  panel.addEventListener("popuphidden", () => done(panelwindow), false);
+  panel.addEventListener("popupshown", () => doTitledPanelTest(panel));
+  panel.addEventListener("popuphidden", () => done(panelwindow));
 }
 
 function doTitledPanelTest(panel)