Bug 1489375 - part1 : do not recreate AudioChannelAgent. r=padenot

When calling resume() on a running AudioContext, there is no need to discard current AudioChannelAgent and then create a new one. Differential Revision: https://phabricator.services.mozilla.com/D5799
iaxat · Sep 18, 2018 · ecdffc0 · ecdffc0
1 parent 0a4467d
commit ecdffc0
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/dom/media/webaudio/AudioDestinationNode.cpp b/dom/media/webaudio/AudioDestinationNode.cpp
@@ -597,20 +597,12 @@ AudioDestinationNode::WindowAudioCaptureChanged(bool aCapture)
 nsresult
 AudioDestinationNode::CreateAudioChannelAgent()
 {
-  if (mIsOffline) {
+  if (mIsOffline || mAudioChannelAgent) {
     return NS_OK;
   }
 
-  nsresult rv = NS_OK;
-  if (mAudioChannelAgent) {
-    rv = mAudioChannelAgent->NotifyStoppedPlaying();
-    if (NS_WARN_IF(NS_FAILED(rv))) {
-      return rv;
-    }
-  }
-
   mAudioChannelAgent = new AudioChannelAgent();
-  rv = mAudioChannelAgent->InitWithWeakCallback(GetOwner(), this);
+  nsresult rv = mAudioChannelAgent->InitWithWeakCallback(GetOwner(), this);
   if (NS_WARN_IF(NS_FAILED(rv))) {
     return rv;
   }