Skip to content

Commit

Permalink
Bug 1433517 - Prevent illegal characters in MOZ_MACBUNDLE_ID r=glandium
Browse files Browse the repository at this point in the history
CFBundleIdentifiers can only contain [A-Za-z.-], and by convention
the app component is lowercase and does not contain '.'.

Make configure delete all characters other than [a-z-] when generating
MOZ_MACBUNDLE_ID from MOZ_APP_DISPLAYNAME.
  • Loading branch information
teor2345 committed Feb 5, 2018
1 parent afe5abd commit f2f259c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion old-configure.in
Original file line number Diff line number Diff line change
Expand Up @@ -4304,7 +4304,7 @@ dnl Mac bundle identifier (based on MOZ_APP_DISPLAYNAME)
# If the MOZ_MACBUNDLE_ID is defined in the configure.sh, use it
# Otherwise, use MOZ_APP_DISPLAYNAME
if test -z "$MOZ_MACBUNDLE_ID"; then
MOZ_MACBUNDLE_ID=`echo $MOZ_APP_DISPLAYNAME | tr 'A-Z' 'a-z' | tr -d '[[:blank:]]'`
MOZ_MACBUNDLE_ID=`echo $MOZ_APP_DISPLAYNAME | tr 'A-Z' 'a-z' | tr -dc 'a-z-'`
fi
MOZ_MACBUNDLE_ID=${MOZ_DISTRIBUTION_ID}.${MOZ_MACBUNDLE_ID}
if test "$MOZ_DEBUG"; then
Expand Down

0 comments on commit f2f259c

Please sign in to comment.