Bug 1586574 - apply horizontal writing mode to mathml elements. r=emilio

Differential Revision: https://phabricator.services.mozilla.com/D48279
iaxat · Dec 16, 2022 · f88b1fe · f88b1fe
1 parent a470955
commit f88b1fe
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 80 deletions.
diff --git a/layout/mathml/mathml.css b/layout/mathml/mathml.css
@@ -9,12 +9,15 @@
 
 @namespace url(http://www.w3.org/1998/Math/MathML);
 
+* {
+  writing-mode: horizontal-tb !important;
+}
+
 /**************************************************************************/
 /* <math> - outermost math element                                        */
 /**************************************************************************/
 
 math {
-  writing-mode: horizontal-tb !important;
   direction: ltr;
   unicode-bidi: embed;
   display: inline;

diff --git a/layout/printing/crashtests/crashtests.list b/layout/printing/crashtests/crashtests.list
@@ -5,7 +5,7 @@ asserts-if(Android,0-1) load 793844.html
 skip-if(Android) load 1662259.html
 skip-if(Android) load 1663722.html
 skip-if(Android) load 1671503.html
-asserts-if(!Android,1-1) load 1748277.html # Bug 1751260
+load 1748277.html # Bug 1751260
 load 1758199-1.html
 pref(layout.css.named-pages.enabled,true) load 1804571.html
 pref(layout.css.named-pages.enabled,true) load 1804798.html
diff --git a/testing/web-platform/meta/mathml/relations/css-styling/ignored-properties-001.html.ini b/testing/web-platform/meta/mathml/relations/css-styling/ignored-properties-001.html.ini
@@ -2,74 +2,3 @@
   expected:
     if (os == "android") and fission: [OK, TIMEOUT]
   max-asserts: 51
-  [mfrac layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [mpadded layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [munder layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [mtable layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [mo layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [munderover layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [menclose layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [mrow layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [maction layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [mstyle layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [msub layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [merror layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [semantics layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [msqrt layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [mphantom layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [mmultiscripts layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [ms layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [mi layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [mn layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [mtext layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [mroot layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [mover layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [msup layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
-
-  [msubsup layout is not affected by writing-mode: vertical-rl;]
-    expected: FAIL
diff --git a/.../web-platform/meta/mathml/relations/css-styling/writing-mode/force-horizontal-tb.html.ini b/.../web-platform/meta/mathml/relations/css-styling/writing-mode/force-horizontal-tb.html.ini
diff --git a/...ing/web-platform/tests/mathml/relations/css-styling/writing-mode/force-horizontal-tb.html b/...ing/web-platform/tests/mathml/relations/css-styling/writing-mode/force-horizontal-tb.html
@@ -12,6 +12,10 @@
   /* selector defined in mathml-fragments.js */
   .element {
     writing-mode: vertical-lr;
+    padding-block-start: 10px;
+    padding-block-end: 15px;
+    padding-inline-start: 20px;
+    padding-inline-end: 25px;
   }
 </style>
 </head>
@@ -21,7 +25,6 @@
     <math class="element"></math>
   </div>
   <script>
-    test(function () {
       var container = document.getElementById("container");
       for (tag in MathMLFragments) {
           container.insertAdjacentHTML("beforeend", `<math>${MathMLFragments[tag]}</math>`);
@@ -32,9 +35,16 @@
       Array.from(document.getElementsByClassName("element")).forEach(element => {
         var tag = element.tagName;
         var style = window.getComputedStyle(element);
-        assert_equals(style["writing-mode"], "horizontal-tb", `writing-mode on ${tag}`);
-      }, `writing-mode is forced to horizontal-tb on all MathML elements`);
-    });
+        test(function () {
+          assert_equals(style["writing-mode"], "horizontal-tb");
+        }, `writing-mode is forced to horizontal-tb on <${tag}> element`);
+        test(function () {
+          assert_equals(style["padding-block-start"], style["padding-top"]);
+          assert_equals(style["padding-block-end"], style["padding-bottom"]);
+          assert_equals(style["padding-inline-start"], style["padding-left"]);
+          assert_equals(style["padding-inline-end"], style["padding-right"]);
+        }, `logical properties interpreted in horizontal-tb on <${tag}> element`);
+      });
   </script>
 </body>
 </html>