Skip to content

Commit

Permalink
Bug 1491605 - Remove nsIControllerCommandGroup because it is dead cod…
Browse files Browse the repository at this point in the history
…e; r=baku

Differential Revision: https://phabricator.services.mozilla.com/D5965
  • Loading branch information
ehsan committed Sep 17, 2018
1 parent 1c48626 commit fe7b024
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 374 deletions.
1 change: 0 additions & 1 deletion dom/commandhandler/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ XPIDL_MODULE = 'commandhandler'

UNIFIED_SOURCES += [
'nsBaseCommandController.cpp',
'nsCommandGroup.cpp',
'nsCommandManager.cpp',
'nsCommandParams.cpp',
'nsControllerCommandTable.cpp',
Expand Down
296 changes: 0 additions & 296 deletions dom/commandhandler/nsCommandGroup.cpp

This file was deleted.

44 changes: 0 additions & 44 deletions dom/commandhandler/nsCommandGroup.h

This file was deleted.

26 changes: 0 additions & 26 deletions dom/xul/nsIController.idl
Original file line number Diff line number Diff line change
Expand Up @@ -36,29 +36,3 @@ interface nsICommandController : nsISupports
void getSupportedCommands(out unsigned long count,
[array, size_is(count), retval] out string commands);
};


/*
An API for registering commands in groups, to allow for
updating via nsIDOMWindow::UpdateCommands.
*/
interface nsISimpleEnumerator;

[scriptable, uuid(9F82C404-1C7B-11D5-A73C-ECA43CA836FC)]
interface nsIControllerCommandGroup : nsISupports
{

void addCommandToGroup(in string aCommand, in string aGroup);
void removeCommandFromGroup(in string aCommand, in string aGroup);

boolean isCommandInGroup(in string aCommand, in string aGroup);

/*
We should expose some methods that allow for enumeration.
*/
nsISimpleEnumerator getGroupsEnumerator();

nsISimpleEnumerator getEnumeratorForGroup(in string aGroup);

};

2 changes: 0 additions & 2 deletions editor/composer/ComposerCommandsUpdater.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -281,8 +281,6 @@ ComposerCommandsUpdater::UpdateCommandGroup(const nsAString& aCommandGroup)
NS_ENSURE_TRUE(commandUpdater, NS_ERROR_FAILURE);


// This hardcoded list of commands is temporary.
// This code should use nsIControllerCommandGroup.
if (aCommandGroup.EqualsLiteral("undo")) {
commandUpdater->CommandStatusChanged("cmd_undo");
commandUpdater->CommandStatusChanged("cmd_redo");
Expand Down
Loading

0 comments on commit fe7b024

Please sign in to comment.