ui/gtk3: Fix time lag of CandidatePanel in X11 #2741
Closed
+101
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timed `set_lookup_table()` is a workaround with the Wayland input-method protocol under the construction to stop the many D-Bus methods but it should not affect Xorg UI at least. Now `m_is_wayland flag` is inherited to the CandidatePanel and Switcher and add `m_first_set_lookup_table` flag newly to enhance the lag with the Wayland input-method protocol. Also fix compile warnings with `valac` in `xkblayout.vala`. Fixes: ibus@d5e6e71 BUG=ibus#2740
Currently the repeating key feature of IBus is disabled when the focus is changed but the feature of the Wayland compositor still happens in the Sway desktop session when invoke xterm by manual in foot. I think Sway should stop the repeating key feature when the focus is changed from the Wayland application to the non-Wayland application. I add a workaround to call `zwp_virtual_keyboard_v1_key()` with the `WL_KEYBOARD_KEY_STATE_RELEASED` flag to stop the feature of the Sway compositor after the IBus repeating key timeout.
fujiwarat
force-pushed
the
ui-x11-lag-lookup
branch
from
3071ff7 to
1d56d77
Compare
|
I can confirm this fixes #2740 for me. Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timed
set_lookup_table()is a workaround with the Waylandinput-method protocol under the construction to stop the many D-Bus
methods but it should not affect Xorg UI at least.
Now
m_is_wayland flagis inherited to the CandidatePanel and Switcherand add
m_first_set_lookup_tableflag newly to enhance the lagwith the Wayland input-method protocol.
Fixes: d5e6e71
BUG=#2740
client/wayland: Fix infinite Return key in xterm
Currently the repeating key feature of IBus is disabled when the focus
is changed but the feature of the Wayland compositor still happens in
the Sway desktop session when invoke xterm by manual in foot.
I think Sway should stop the repeating key feature when the focus is
changed from the Wayland application to the non-Wayland application.
I add a workaround to call
zwp_virtual_keyboard_v1_key()withthe
WL_KEYBOARD_KEY_STATE_RELEASEDflag to stop the feature ofthe Sway compositor after the IBus repeating key timeout.