Merge branch 'main' into patch-1

.changeset/giant-needles-pretend.md

@@ -0,0 +1,5 @@
+---
+"@threlte/extras": patch
+---
+
+imported classes as types not values in Gizmo and MeshRefractionMaterial components

apps/docs/src/content/learn/getting-started/installation.mdx

@@ -26,21 +26,6 @@ can be used with `npx`, the resulting Threlte components however require `@threl
 
 <ManualInstallGuide client:load />
 
-### Configuration
-
-#### Adapt `vite.config.js`
-
-If you are using Threlte with SvelteKit, adapt your Vite configuration to prevent `three` from being externalized for SSR by vites externalization step
-
-```js {3-5}+ title=vite.config.js
-const config = {
-  // …
-  ssr: {
-    noExternal: ['three']
-  }
-}
-```
-
 <Tip type="tip">
   [See this comment](https://github.com/threlte/threlte/issues/8#issuecomment-1024085864) for tips
   on how to reduce bundle size when working with bundlers like vite and three.js.

packages/core/vite.config.js

@@ -11,9 +11,6 @@ const config = {
     alias: {
       threlte: resolve('./src/lib')
     }
-  },
-  ssr: {
-    noExternal: ['three']
   }
 }
 

packages/create-threlte/src/templates/javascript+vitest/vite.config.js

@@ -3,9 +3,6 @@ import { defineConfig } from 'vitest/config';
 
 export default defineConfig({
 	plugins: [sveltekit()],
-	ssr: {
-		noExternal: ['three']
-	},
 	test: {
 		include: ['src/**/*.{test,spec}.{js,ts}']
 	}

packages/create-threlte/src/templates/javascript/vite.config.js

@@ -2,8 +2,5 @@ import { sveltekit } from '@sveltejs/kit/vite';
 import { defineConfig } from 'vite';
 
 export default defineConfig({
-	plugins: [sveltekit()],
-	ssr: {
-		noExternal: ['three']
-	}
+	plugins: [sveltekit()]
 });

packages/create-threlte/src/templates/typescript+vitest/vite.config.ts

@@ -3,9 +3,6 @@ import { defineConfig } from 'vitest/config'
 
 export default defineConfig({
   plugins: [sveltekit()],
-  ssr: {
-    noExternal: ['three']
-  },
   test: {
     include: ['src/**/*.{test,spec}.{js,ts}']
   }

packages/create-threlte/src/templates/typescript/vite.config.ts

@@ -2,8 +2,5 @@ import { sveltekit } from '@sveltejs/kit/vite'
 import { defineConfig } from 'vite'
 
 export default defineConfig({
-  plugins: [sveltekit()],
-  ssr: {
-    noExternal: ['three']
-  }
+  plugins: [sveltekit()]
 })

packages/create-threlte/src/templates/xr+javascript+vitest/vite.config.js

@@ -4,9 +4,6 @@ import mkcert from 'vite-plugin-mkcert';
 
 export default defineConfig({
 	plugins: [mkcert(), sveltekit()],
-	ssr: {
-		noExternal: ['three']
-	},
 	test: {
 		include: ['src/**/*.{test,spec}.{js,ts}']
 	}

packages/create-threlte/src/templates/xr+javascript/vite.config.js

@@ -3,8 +3,5 @@ import { defineConfig } from 'vite';
 import mkcert from 'vite-plugin-mkcert';
 
 export default defineConfig({
-	plugins: [mkcert(), sveltekit()],
-	ssr: {
-		noExternal: ['three']
-	}
+	plugins: [mkcert(), sveltekit()]
 });

packages/create-threlte/src/templates/xr+typescript+vitest/vite.config.ts

@@ -4,9 +4,6 @@ import mkcert from 'vite-plugin-mkcert'
 
 export default defineConfig({
   plugins: [mkcert(), sveltekit()],
-  ssr: {
-    noExternal: ['three']
-  },
   test: {
     include: ['src/**/*.{test,spec}.{js,ts}']
   }

packages/create-threlte/src/templates/xr+typescript/vite.config.ts

@@ -3,8 +3,5 @@ import { defineConfig } from 'vite'
 import mkcert from 'vite-plugin-mkcert'
 
 export default defineConfig({
-  plugins: [mkcert(), sveltekit()],
-  ssr: {
-    noExternal: ['three']
-  }
+  plugins: [mkcert(), sveltekit()]
 })

packages/extras/src/lib/components/Gizmo/Gizmo.svelte

@@ -11,7 +11,7 @@
     Quaternion,
     Raycaster,
     Scene,
-    Sprite,
+    type Sprite,
     Vector2,
     Vector3,
     Vector4,

packages/extras/src/lib/components/MeshRefractionMaterial/MeshRefractionMaterial.svelte

@@ -1,6 +1,6 @@
 <script lang="ts">
   import { T, useParent, useTask, useThrelte } from '@threlte/core'
-  import { Color, CubeTexture, Matrix4, Mesh, ShaderMaterial, Texture, Vector2 } from 'three'
+  import { Color, type CubeTexture, Matrix4, Mesh, ShaderMaterial, Texture, Vector2 } from 'three'
   import { onMount } from 'svelte'
   import { MeshBVH, MeshBVHUniformStruct, SAH } from 'three-mesh-bvh'
   import type {

packages/extras/vite.config.js

@@ -5,10 +5,7 @@ import { threeMinifier } from '@yushijinhun/three-minifier-rollup'
  * @type {import('vite').UserConfig}
  */
 const config = {
-  plugins: [sveltekit(), { ...threeMinifier(), enforce: 'pre' }],
-  ssr: {
-    noExternal: ['three']
-  }
+  plugins: [sveltekit(), { ...threeMinifier(), enforce: 'pre' }]
 }
 
 export default config

packages/flex/vite.config.js

@@ -5,10 +5,7 @@ import { threeMinifier } from '@yushijinhun/three-minifier-rollup'
  * @type {import('vite').UserConfig}
  */
 const config = {
-  plugins: [sveltekit(), { ...threeMinifier(), enforce: 'pre' }],
-  ssr: {
-    noExternal: ['three']
-  }
+  plugins: [sveltekit(), { ...threeMinifier(), enforce: 'pre' }]
 }
 
 export default config

packages/rapier/vite.config.js

@@ -5,10 +5,7 @@ import { sveltekit } from '@sveltejs/kit/vite'
  * @type {import('vite').UserConfig}
  */
 const config = {
-  plugins: [sveltekit(), { ...threeMinifier(), enforce: 'pre' }],
-  ssr: {
-    noExternal: ['three']
-  }
+  plugins: [sveltekit(), { ...threeMinifier(), enforce: 'pre' }]
 }
 
 export default config

packages/theatre/vite.config.js

@@ -5,10 +5,7 @@ import { sveltekit } from '@sveltejs/kit/vite'
  * @type {import('vite').UserConfig}
  */
 const config = {
-  plugins: [sveltekit(), { ...threeMinifier(), enforce: 'pre' }],
-  ssr: {
-    noExternal: ['three']
-  }
+  plugins: [sveltekit(), { ...threeMinifier(), enforce: 'pre' }]
 }
 
 export default config