Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use zeroKW and zeroKWH in thermal grid unit tests #1024

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Use zeroKW and zeroKWH in thermal grid unit tests #1024

merged 7 commits into from
Nov 15, 2024

Conversation

danielfeismann
Copy link
Member

resolves #1023

@danielfeismann danielfeismann added the code quality Code readability or efficiency is improved label Nov 15, 2024
@danielfeismann danielfeismann self-assigned this Nov 15, 2024
@danielfeismann danielfeismann marked this pull request as ready for review November 15, 2024 12:02
@danielfeismann danielfeismann mentioned this pull request Nov 15, 2024
Open
staudtMarius
staudtMarius requested changes Nov 15, 2024
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one small question. Should we rename zeroKWH to zeroKWh?

staudtMarius
staudtMarius approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@staudtMarius staudtMarius merged commit 9d780a7 into dev Nov 15, 2024
3 checks passed
@staudtMarius staudtMarius deleted the df/#1023-zeroKW-and-kWh-in-test branch November 15, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staudtMarius staudtMarius staudtMarius approved these changes

Assignees

@danielfeismann danielfeismann

Labels
code quality Code readability or efficiency is improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use zeroKW and zeroKWH in thermal grid unit tests
2 participants
@danielfeismann @staudtMarius