Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ThermalStorageResults having multiple entries #925

Merged
merged 15 commits into from
Oct 25, 2024
Merged

Fixed ThermalStorageResults having multiple entries #925

merged 15 commits into from
Oct 25, 2024

Conversation

danielfeismann
Copy link
Member

resolves #924

@danielfeismann danielfeismann self-assigned this Aug 24, 2024
@danielfeismann danielfeismann added the bug Something isn't working label Aug 24, 2024
@danielfeismann
Copy link
Member Author

ThermalGrid.results() will carry out both, thermalHouse and thermalStorage results whenever one of both got a change of its state. Since the state of the other hasn't changed, it was written out with the tick of the last change of it. This can and should be changed within another PR (Issue needs to be created). As workaround the tick of the result that triggered the output of the results will be used for both.

@danielfeismann danielfeismann marked this pull request as ready for review August 24, 2024 06:56
@danielfeismann danielfeismann mentioned this pull request Aug 24, 2024
Open
sebastian-peter
sebastian-peter reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now we're setting the result tick to the maximum tick of all results. But wouldn't it make more sense to only send out the results of the entity with the maximum tick? Because the other entity with a smaller result tick clearly has not changed the result.

@danielfeismann
Merge branch 'refs/heads/dev' into df/#924-ThermalStorageResults-have…
052969e 
…-multiple-entries

# Conflicts:
#	CHANGELOG.md
@danielfeismann
Copy link
Member Author

Good idea! Thanks.

@sebastian-peter
Copy link
Member

@danielfeismann Adapted the code a bit for simplicity. Let me know what you think

@danielfeismann
Copy link
Member Author

danielfeismann commented Oct 14, 2024 •
edited
Loading

@sebastian-peter: Looks good to me!

@sebastian-peter sebastian-peter merged commit 0d2f064 into dev Oct 25, 2024
3 checks passed
@sebastian-peter sebastian-peter deleted the df/#924-ThermalStorageResults-have-multiple-entries branch October 25, 2024 11:19
@danielfeismann danielfeismann mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

@jo-bao jo-bao Awaiting requested review from jo-bao

Assignees

@danielfeismann danielfeismann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ThermalStorageResults having multiple entries
2 participants
@danielfeismann @sebastian-peter