Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OfferingForm render modifiers #8401

Merged
merged 3 commits into from
Mar 7, 2025
Merged

Remove OfferingForm render modifiers #8401

merged 3 commits into from
Mar 7, 2025

Conversation

michaelchadwick
Copy link
Contributor

@netlify Netlify
Copy link

netlify bot commented Mar 5, 2025 •
edited
Loading

✅ Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit 082fb8e
🔍 Latest deploy log https://app.netlify.com/sites/ilios-frontend/deploys/67ca1fe36c11e5000801324d
😎 Deploy Preview https://deploy-preview-8401--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@michaelchadwick michaelchadwick force-pushed the remove-offering-form-render-modifiers branch from 13216fd to 028a064 Compare March 6, 2025 00:37
stopfstedt
stopfstedt reviewed Mar 6, 2025
View reviewed changes
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my comment re: this.loaded and check if this attribute can be removed.

otherwise, this looks good to me.

stopfstedt
stopfstedt approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dartajax dartajax added the run ui tests Run the expensive UI tests label Mar 6, 2025
@michaelchadwick michaelchadwick force-pushed the remove-offering-form-render-modifiers branch from ea28b09 to 082fb8e Compare March 6, 2025 22:21
@dartajax dartajax merged commit a227892 into ilios:master Mar 7, 2025
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stopfstedt stopfstedt stopfstedt approved these changes

@jrjohnson jrjohnson Awaiting requested review from jrjohnson jrjohnson is a code owner

Assignees

@dartajax dartajax

Labels
run ui tests Run the expensive UI tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelchadwick @stopfstedt @dartajax