Replace render modifiers in course rollover component #8429
+89
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
replace_render_modifier_course_rollover_component
branch
from
e81df37 to
ca12fe4
Compare
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…es tracked prop with getter. with the render-ember-modifier approach to initializing the component is going way, we can't set the course title on init anymore. i'm attempting to side-step this issue by setting the title from the given course's title on save if the user hasn't set one explicitly. replacing allCourses with a getter in the same go since this is where is started.
i don't see how the new start date cannot be set at this point. fold it in with the rst of the attributes.
stopfstedt
force-pushed
the
replace_render_modifier_course_rollover_component
branch
from
ca12fe4 to
870b705
Compare
in the save() task, i moved the call to timeout() below the form validation step, to address a flash of content issue that i was noticing (the saving-overlay would briefly blink in).
stopfstedt
force-pushed
the
replace_render_modifier_course_rollover_component
branch
from
066123c to
2f021d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs ilios/ilios#5374
i'm still a bit iffy by setting tracked props in the
save()task, but don't see another way to shoe-horn these in if the user hasn't changed the defaults before form validation runs.