Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for vocabulary selection, filter out vocabularies where all top-level terms are inactive. #8430

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

stopfstedt
Copy link
Member

Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit d556cf9
🔍 Latest deploy log https://app.netlify.com/sites/ilios-frontend/deploys/67d20627695a9900091d390e
😎 Deploy Preview https://deploy-preview-8430--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stopfstedt stopfstedt marked this pull request as ready for review March 12, 2025 22:12
@dartajax
Copy link
Member

I take it these terms are set up so if a higher level term is inactive, any sub terms are also assumed to be inactive.

@dartajax
Copy link
Member

I take it these terms are set up so if a higher level term is inactive, any sub terms are also assumed to be inactive.

Check "OEQ" for reference - the higher level terms are all inactive but the sub-terms are still active. I am fine with that - just want to make sure.

@dartajax dartajax added the run ui tests Run the expensive UI tests label Mar 12, 2025
@stopfstedt
Copy link
Member Author

stopfstedt commented Mar 12, 2025

I take it these terms are set up so if a higher level term is inactive, any sub terms are also assumed to be inactive.

Check "OEQ" for reference - the higher level terms are all inactive but the sub-terms are still active. I am fine with that - just want to make sure

yes, that's what Sascha asked for. from the corresponding ticket:

When all terms within a vocabulary are disabled at the top level (ie, if there is nothing a user can pick from the term list when tagging), that vocabulary should NOT be available in the drop down select list

@dartajax dartajax merged commit fe48275 into ilios:master Mar 13, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run ui tests Run the expensive UI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide deprecated vocabularies
3 participants