Skip to content
This repository has been archived by the owner on Nov 11, 2019. It is now read-only.

Add Memory to Stage #54

Merged
merged 2 commits into from
Feb 24, 2019
Merged

Add Memory to Stage #54

merged 2 commits into from
Feb 24, 2019

Conversation

ayushr2
Copy link
Contributor

@ayushr2 ayushr2 commented Feb 24, 2019

Added memory in the schema definition.

I looked through the codebase and do not think anything else has to change to accommodate this. But would appreciate a review.

@ayushr2 ayushr2 requested a review from nmagerko February 24, 2019 21:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 308

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.844%
Totals Coverage Status
Change from base Build 298: 0.0%
Covered Lines: 653
Relevant Lines: 735
💛 - Coveralls

nmagerko
nmagerko approved these changes Feb 24, 2019
View reviewed changes
Copy link
Contributor

@nmagerko nmagerko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to remove [WIP] tag

@ayushr2 ayushr2 changed the title [WIP] Add Memory to Stage Add Memory to Stage Feb 24, 2019
@ayushr2 ayushr2 merged commit d43a05a into master Feb 24, 2019
@ayushr2 ayushr2 deleted the add-memory branch February 24, 2019 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nmagerko nmagerko nmagerko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayushr2 @coveralls @nmagerko