This repository has been archived by the owner on Nov 11, 2019. It is now read-only.
Change worker register endpoints #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushr2
reviewed
Mar 28, 2019
ayushr2
reviewed
Mar 28, 2019
ayushr2
reviewed
Mar 28, 2019
ayushr2
reviewed
Mar 28, 2019
|
fixed! |
ayushr2
reviewed
Mar 28, 2019
ayushr2
reviewed
Mar 28, 2019
ayushr2
reviewed
Mar 28, 2019
|
tests fixed |
ayushr2
reviewed
Mar 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #61
Worker side PR illinois-cs241/broadway-grader#25
The db model is slightly different from the one in the issue description.
I kept the
_idfield but used mongo's upsert to update/insert new/existing workers.So it's probably incompatible to the old model and we may need to drop the original
worker_nodecollection before deploying(which should be fine?).On the worker side, I also enforced the use of
"heartbeat"field responded by api to make sure workers and api agree on the same heartbeat interval.Another minor change: in api's router,
id_regexallows digits in this branch. Not sure if there is any problem with that.