Skip to content

Conversation

EscapedGibbon
Copy link
Contributor

No description provided.

@EscapedGibbon EscapedGibbon linked an issue Aug 22, 2025 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Aug 22, 2025

Deploying image-js-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0b5cff4
Status: ✅  Deploy successful!
Preview URL: https://2dc3ab78.image-js-docs.pages.dev
Branch Preview URL: https://146-change-open-graph-image.image-js-docs.pages.dev

View logs

@EscapedGibbon EscapedGibbon marked this pull request as ready for review August 26, 2025 08:04
@EscapedGibbon
Copy link
Contributor Author

I believe this should do it. Title for home page of a social card was fixed, image was fixed as well. I played a bit with inkscape and added an alternative for a social card, but even without it it looks more than fine. Just had to modify image dimensions a bit.

CleanShot 2025-08-26 at 10 07 45

Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we cannot test this unless we merge it.

For the social card, I would suggest you do an iteration in which you remove the top "ImageJS" text. It's repetitive (already in the logo) and does not look great. You can also try to find a font which fits well for the text on the right.

@stropitek
Copy link
Contributor

stropitek commented Aug 26, 2025

@EscapedGibbon Please temporarily change the website url so we can test here, and revert before merging.
https://146-change-open-graph-image.image-js-docs.pages.dev/

@EscapedGibbon EscapedGibbon force-pushed the 146-change-open-graph-image-and-home-page-title branch from 0836bb3 to 0f4ed1c Compare August 26, 2025 08:53
@targos
Copy link
Member

targos commented Aug 26, 2025

Result on WhatsApp:
CleanShot 2025-08-26 at 11 06 55

@EscapedGibbon
Copy link
Contributor Author

Social cards seem to work fine, here is another example of a social card as discussed. I used "Roboto" font this time.

But, as was discussed previously, even with regular icon social card looks alright, so not something to spend too much time on.

social-card-new2

Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Need to revert the URL and decide which image we use (and delete the other one)

I think the work you started with the social card is good enough if just improved slightly. THe layout bothers me a little, the text on the right should be more balanced, have larger margins and more inter-line space.

@EscapedGibbon EscapedGibbon merged commit 349fe52 into main Aug 26, 2025
8 checks passed
@EscapedGibbon EscapedGibbon deleted the 146-change-open-graph-image-and-home-page-title branch August 26, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change open graph image and home page title
3 participants