-
Notifications
You must be signed in to change notification settings - Fork 0
fix: update social card #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update social card #149
Conversation
Deploying image-js-docs with
|
Latest commit: |
0b5cff4
|
Status: | ✅ Deploy successful! |
Preview URL: | https://2dc3ab78.image-js-docs.pages.dev |
Branch Preview URL: | https://146-change-open-graph-image.image-js-docs.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we cannot test this unless we merge it.
For the social card, I would suggest you do an iteration in which you remove the top "ImageJS" text. It's repetitive (already in the logo) and does not look great. You can also try to find a font which fits well for the text on the right.
@EscapedGibbon Please temporarily change the website url so we can test here, and revert before merging. |
0836bb3
to
0f4ed1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Need to revert the URL and decide which image we use (and delete the other one)
I think the work you started with the social card is good enough if just improved slightly. THe layout bothers me a little, the text on the right should be more balanced, have larger margins and more inter-line space.
No description provided.