Upgrade sqlparse to 0.2.4

Add test case for /api/queries/format
imloama · Feb 22, 2018 · f5d4ca8 · f5d4ca8
1 parent c65b637
commit f5d4ca8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/requirements.txt b/requirements.txt
@@ -27,7 +27,7 @@ six==1.10.0
 SQLAlchemy==1.1.4
 SQLAlchemy-Searchable==0.10.6
 SQLAlchemy-Utils>=0.29.0
-sqlparse==0.1.8
+sqlparse==0.2.4
 wsgiref==0.1.2
 honcho==0.5.0
 statsd==2.1.2

diff --git a/tests/handlers/test_queries.py b/tests/handlers/test_queries.py
@@ -183,3 +183,19 @@ def test_must_have_full_access_to_data_source(self):
         rv = self.make_request('post', '/api/queries/{}/fork'.format(query.id))
 
         self.assertEqual(rv.status_code, 403)
+
+
+class TestFormatSQLQueryAPI(BaseTestCase):
+    def test_format_sql_query(self):
+        admin = self.factory.create_admin()
+        query = 'select a,b,c FROM foobar Where x=1 and y=2;'
+        expected = """SELECT a,
+       b,
+       c
+FROM foobar
+WHERE x=1
+  AND y=2;"""
+
+        rv = self.make_request('post', '/api/queries/format', user=admin, data={'query': query})
+
+        self.assertEqual(rv.json['query'], expected)